Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9474

MiniSolrCloudCluster should not reuse ports by default

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.3
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Building on SOLR-9469, this just changes MSCC.startJettySolrRunner(JettySolrRunner) to use a different port when it restarts the passed-in Jetty. This should stop the semi-frequent test failures in CollectionStateWatchersTest.

      1. SOLR-9474.patch
        0.6 kB
        Alan Woodward

        Activity

        Hide
        romseygeek Alan Woodward added a comment -

        One-liner patch.

        Show
        romseygeek Alan Woodward added a comment - One-liner patch.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Just fyi, I've seen a lot of funkiness when on a server restart the port changes and the cores cannot recover or elect leaders because the cluster state still has the old port numbers. It seems like sometimes the port changes are updated to ZK and sometimes not. Unfortunately, I don't have that test anymore because I switched away from MiniSolrCloudCluster due to time constraints.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Just fyi, I've seen a lot of funkiness when on a server restart the port changes and the cores cannot recover or elect leaders because the cluster state still has the old port numbers. It seems like sometimes the port changes are updated to ZK and sometimes not. Unfortunately, I don't have that test anymore because I switched away from MiniSolrCloudCluster due to time constraints.
        Hide
        romseygeek Alan Woodward added a comment -

        OK, thanks Shalin. I'll watch for some exciting new test failures, then

        Show
        romseygeek Alan Woodward added a comment - OK, thanks Shalin. I'll watch for some exciting new test failures, then
        Show
        shalinmangar Shalin Shekhar Mangar added a comment - I had forgotten that I had indeed saved one such failure at https://issues.apache.org/jira/browse/SOLR-9438?focusedCommentId=15450041&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15450041
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 53c37dc9a52aa67af8870070881ddd0dda0408c0 in lucene-solr's branch refs/heads/branch_6x from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=53c37dc ]

        SOLR-9474: MiniSolrCloudCluster restarts jetties using different ports by default

        Show
        jira-bot ASF subversion and git services added a comment - Commit 53c37dc9a52aa67af8870070881ddd0dda0408c0 in lucene-solr's branch refs/heads/branch_6x from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=53c37dc ] SOLR-9474 : MiniSolrCloudCluster restarts jetties using different ports by default
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 89a91ec99daf712491975d2dcfe46ca6bd2f91c5 in lucene-solr's branch refs/heads/master from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=89a91ec ]

        SOLR-9474: MiniSolrCloudCluster restarts jetties using different ports by default

        Show
        jira-bot ASF subversion and git services added a comment - Commit 89a91ec99daf712491975d2dcfe46ca6bd2f91c5 in lucene-solr's branch refs/heads/master from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=89a91ec ] SOLR-9474 : MiniSolrCloudCluster restarts jetties using different ports by default
        Hide
        romseygeek Alan Woodward added a comment -

        Shalin Shekhar Mangar I don't think that should effect any of the tests that currently use this feature, but I'll watch out for it. Maybe in future we need to think about decoupling the name of a node from its hostname and port.

        Show
        romseygeek Alan Woodward added a comment - Shalin Shekhar Mangar I don't think that should effect any of the tests that currently use this feature, but I'll watch out for it. Maybe in future we need to think about decoupling the name of a node from its hostname and port.
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Closing after 6.3.0 release.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.3.0 release.

          People

          • Assignee:
            romseygeek Alan Woodward
            Reporter:
            romseygeek Alan Woodward
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development