Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9469

Allow JettySolrRunner to restart using a different port

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.3
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      When a JettySolrRunner is restarted, it currently tries to reuse the same port as it was running on before the restart. This can lead to stale connections, and test failures (see SOLR-6944 for an example, but it seems to be happening in other tests, CollectionStateWatchersTest for example). In plenty of cases, we don't actually need to restart on the same port, so we should add the ability to ignore previous port numbers and just come up on any port that is available.

      1. SOLR-9469.patch
        4 kB
        Alan Woodward

        Activity

        Hide
        romseygeek Alan Woodward added a comment -

        Patch, adding a boolean parameter to JettySolrRunner.start(). Default behaviour is same as before, to reuse the previous port.

        The patch applies on top of SOLR-8961, as it adds a test case to the test-framework.

        Show
        romseygeek Alan Woodward added a comment - Patch, adding a boolean parameter to JettySolrRunner.start(). Default behaviour is same as before, to reuse the previous port. The patch applies on top of SOLR-8961 , as it adds a test case to the test-framework.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 54300e4a9b44cdf63c98dfdd276c11dd60ce3e6b in lucene-solr's branch refs/heads/branch_6x from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=54300e4 ]

        SOLR-9469: Allow JettySolrRunner to restart using a different port

        Show
        jira-bot ASF subversion and git services added a comment - Commit 54300e4a9b44cdf63c98dfdd276c11dd60ce3e6b in lucene-solr's branch refs/heads/branch_6x from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=54300e4 ] SOLR-9469 : Allow JettySolrRunner to restart using a different port
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit a79a8edbb474aab0dd163c9bd06c8a1ccc881acc in lucene-solr's branch refs/heads/master from Alan Woodward
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a79a8ed ]

        SOLR-9469: Allow JettySolrRunner to restart using a different port

        Show
        jira-bot ASF subversion and git services added a comment - Commit a79a8edbb474aab0dd163c9bd06c8a1ccc881acc in lucene-solr's branch refs/heads/master from Alan Woodward [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a79a8ed ] SOLR-9469 : Allow JettySolrRunner to restart using a different port
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Closing after 6.3.0 release.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.3.0 release.

          People

          • Assignee:
            romseygeek Alan Woodward
            Reporter:
            romseygeek Alan Woodward
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development