Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9451

Make clusterstatus command logging less verbose

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.3, 7.0
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Today when we run a cluster status call, the logs get filled up with ZkStateReader messages like this. If a user has a lot of collections this can get quite verbose and likely not useful.

      INFO  - 2016-08-29 12:10:55.533; [   ] org.apache.solr.handler.admin.CollectionsHandler; Invoked Collection Action :clusterstatus with params json.nl=map&indent=true&action=CLUSTERSTATUS&wt=json and sendToOCPQueue=true
      INFO  - 2016-08-29 12:10:55.535; [   ] org.apache.solr.common.cloud.ZkStateReader; Load collection config from: [/collections/test1]
      INFO  - 2016-08-29 12:10:55.535; [   ] org.apache.solr.common.cloud.ZkStateReader; path=[/collections/test1] [configName]=[test1] specified config exists in ZooKeeper
      INFO  - 2016-08-29 12:10:55.536; [   ] org.apache.solr.common.cloud.ZkStateReader; Load collection config from: [/collections/gettingstarted]
      INFO  - 2016-08-29 12:10:55.537; [   ] org.apache.solr.common.cloud.ZkStateReader; path=[/collections/gettingstarted] [configName]=[gettingstarted] specified config exists in ZooKeeper
      ......
      
      1. SOLR-9451.patch
        2 kB
        Varun Thacker
      2. SOLR-9451.patch
        2 kB
        Varun Thacker

        Activity

        Hide
        varunthacker Varun Thacker added a comment -

        Converted the logging lines to debug level

        Show
        varunthacker Varun Thacker added a comment - Converted the logging lines to debug level
        Hide
        erickerickson Erick Erickson added a comment -

        +1.

        The important thing to see in the logs is when it fails, otherwise we an assume success. I think the success case is so buried in the output that it's rarely useful. And if there's some confusion about what config was actually loaded, I usually pull it up in the Admin UI anyway, that way I know absolutely what Solr got rather than what I think I specified....

        Perhaps enhance the error message by including the ZK path in the "Specified config does not exist...." message?

        Show
        erickerickson Erick Erickson added a comment - +1. The important thing to see in the logs is when it fails , otherwise we an assume success. I think the success case is so buried in the output that it's rarely useful. And if there's some confusion about what config was actually loaded, I usually pull it up in the Admin UI anyway, that way I know absolutely what Solr got rather than what I think I specified.... Perhaps enhance the error message by including the ZK path in the "Specified config does not exist...." message?
        Hide
        varunthacker Varun Thacker added a comment -

        Patch which folds in Ericks feedback . I'll commit this soon

        Show
        varunthacker Varun Thacker added a comment - Patch which folds in Ericks feedback . I'll commit this soon
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 61955efc504a36ef85e44a1e2e47b9c8bef130bf in lucene-solr's branch refs/heads/master from Varun Thacker
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=61955ef ]

        SOLR-9451: Make clusterstatus command logging less verbose

        Show
        jira-bot ASF subversion and git services added a comment - Commit 61955efc504a36ef85e44a1e2e47b9c8bef130bf in lucene-solr's branch refs/heads/master from Varun Thacker [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=61955ef ] SOLR-9451 : Make clusterstatus command logging less verbose
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e8eadedb85c577ec2aed84d0281d45774f75bdc9 in lucene-solr's branch refs/heads/branch_6x from Varun Thacker
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e8eaded ]

        SOLR-9451: Make clusterstatus command logging less verbose

        Show
        jira-bot ASF subversion and git services added a comment - Commit e8eadedb85c577ec2aed84d0281d45774f75bdc9 in lucene-solr's branch refs/heads/branch_6x from Varun Thacker [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e8eaded ] SOLR-9451 : Make clusterstatus command logging less verbose
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Closing after 6.3.0 release.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.3.0 release.

          People

          • Assignee:
            varunthacker Varun Thacker
            Reporter:
            varunthacker Varun Thacker
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development