Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9447

Do not clone SolrInputDocument if update processor chain does not contain custom processors

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.3, 7.0
    • Component/s: SolrCloud
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      In SOLR-3215 we started cloning documents before adding them locally and send the cloned copy to replicas. This was done because processors after DistributedUpdateProcessor can affect the docs before they are sent to the replicas.

      However, we can avoid the deep copy if we know for sure that the processors after DUP are one of (LogUpdateProcessor, RunUpdateProcessor, TolerantUpdateProcessor) which definitely do not modify the document. This ensures that the common case is optimized.

        Attachments

        1. SOLR-9447.patch
          2 kB
          Shalin Shekhar Mangar

          Activity

            People

            • Assignee:
              shalinmangar Shalin Shekhar Mangar
              Reporter:
              shalinmangar Shalin Shekhar Mangar
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: