Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9445

Admin requests are retried by CloudSolrClient and LBHttpSolrClient on failure

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.2
    • Fix Version/s: 6.2.1, 6.3, master (7.0)
    • Component/s: SolrCloud
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Another bug found during SOLR-9438. I saw that shard split requests were being retried more times than the attempts made by the test. I traced it to LBHttpSolrClient which retries automatically on 404 or 403 or 503 or 500 errors except when the request is an update.

      Each admin request is retried on failure as many times as the number of live nodes.

      1. SOLR-9445.patch
        12 kB
        Shalin Shekhar Mangar

        Issue Links

          Activity

          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -
          1. Moves ADMIN_PATHS set to CommonParams
          2. This set is used in LBHttpSolrClient to determine if a request is retryable or not in addition to the IsUpdateRequest check
          3. the isUpdateRequest variable is renamed to isNonRetryable because it is true for both update and admin requests
          4. CloudSolrClientTest#testNonRetryableRequests is a new test which fails without the fix but passes with them.

          I'll commit shortly.

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Moves ADMIN_PATHS set to CommonParams This set is used in LBHttpSolrClient to determine if a request is retryable or not in addition to the IsUpdateRequest check the isUpdateRequest variable is renamed to isNonRetryable because it is true for both update and admin requests CloudSolrClientTest#testNonRetryableRequests is a new test which fails without the fix but passes with them. I'll commit shortly.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit ae40929f0b13f5cbf83b0700bab694fd7a65f660 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ae40929 ]

          SOLR-9445: Admin requests are retried by CloudSolrClient and LBHttpSolrClient on failure

          Show
          jira-bot ASF subversion and git services added a comment - Commit ae40929f0b13f5cbf83b0700bab694fd7a65f660 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ae40929 ] SOLR-9445 : Admin requests are retried by CloudSolrClient and LBHttpSolrClient on failure
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 5556a9b4def7a4320dcd537ae2cd1ed20d341f03 in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5556a9b ]

          SOLR-9445: Admin requests are retried by CloudSolrClient and LBHttpSolrClient on failure
          (cherry picked from commit ae40929)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 5556a9b4def7a4320dcd537ae2cd1ed20d341f03 in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5556a9b ] SOLR-9445 : Admin requests are retried by CloudSolrClient and LBHttpSolrClient on failure (cherry picked from commit ae40929)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit df9a642a8918ea626579a590f573f7205a081cd7 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=df9a642 ]

          SOLR-9445: Fix failures in TestLocalFSCloudBackupRestore due to changed code path which return SolrExceptions instead of SolrServerExceptions

          Show
          jira-bot ASF subversion and git services added a comment - Commit df9a642a8918ea626579a590f573f7205a081cd7 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=df9a642 ] SOLR-9445 : Fix failures in TestLocalFSCloudBackupRestore due to changed code path which return SolrExceptions instead of SolrServerExceptions
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 4f316bc199359188d4fcad534f1f49cb260bd877 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4f316bc ]

          SOLR-9445: Removed unused import

          Show
          jira-bot ASF subversion and git services added a comment - Commit 4f316bc199359188d4fcad534f1f49cb260bd877 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4f316bc ] SOLR-9445 : Removed unused import
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7cf7bfdf0c90e56979db0b5a06aabacadd3ee9b4 in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7cf7bfd ]

          SOLR-9445: Fix failures in TestLocalFSCloudBackupRestore due to changed code path which return SolrExceptions instead of SolrServerExceptions
          (cherry picked from commit df9a642)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7cf7bfdf0c90e56979db0b5a06aabacadd3ee9b4 in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7cf7bfd ] SOLR-9445 : Fix failures in TestLocalFSCloudBackupRestore due to changed code path which return SolrExceptions instead of SolrServerExceptions (cherry picked from commit df9a642)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d4954dad23240a518c9d5f0832ad500d6e2bef09 in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d4954da ]

          SOLR-9445: Removed unused import
          (cherry picked from commit 4f316bc)

          Show
          jira-bot ASF subversion and git services added a comment - Commit d4954dad23240a518c9d5f0832ad500d6e2bef09 in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d4954da ] SOLR-9445 : Removed unused import (cherry picked from commit 4f316bc)
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Re-opened to back-port to 6.2.1

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Re-opened to back-port to 6.2.1
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit b34f9b6fe590a46aef7792e0313f88721f1caded in lucene-solr's branch refs/heads/branch_6_2 from Shalin Shekhar Mangar
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b34f9b6 ]

          SOLR-9445: Fix failures in TestLocalFSCloudBackupRestore due to changed code path which return SolrExceptions instead of SolrServerExceptions
          (cherry picked from commit df9a642)

          (cherry picked from commit 7cf7bfd)

          Show
          jira-bot ASF subversion and git services added a comment - Commit b34f9b6fe590a46aef7792e0313f88721f1caded in lucene-solr's branch refs/heads/branch_6_2 from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b34f9b6 ] SOLR-9445 : Fix failures in TestLocalFSCloudBackupRestore due to changed code path which return SolrExceptions instead of SolrServerExceptions (cherry picked from commit df9a642) (cherry picked from commit 7cf7bfd)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a435e9d33f81aece9cd42a36a620dd6baa98d4ac in lucene-solr's branch refs/heads/branch_6_2 from Shalin Shekhar Mangar
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a435e9d ]

          SOLR-9445: Removed unused import
          (cherry picked from commit 4f316bc)

          (cherry picked from commit d4954da)

          Show
          jira-bot ASF subversion and git services added a comment - Commit a435e9d33f81aece9cd42a36a620dd6baa98d4ac in lucene-solr's branch refs/heads/branch_6_2 from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a435e9d ] SOLR-9445 : Removed unused import (cherry picked from commit 4f316bc) (cherry picked from commit d4954da)
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Closing after 6.2.1 release

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.2.1 release

            People

            • Assignee:
              shalinmangar Shalin Shekhar Mangar
              Reporter:
              shalinmangar Shalin Shekhar Mangar
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development