Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9385

add QParser.getParser(String,SolrQueryRequest) variant

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.2, master (7.0)
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      For a relative majority (~32) of callers this variant will eliminate the "What do i pass in for the default (since i do not have one)?" question, compared to a relative minority (~19) of callers that pass in a default other than the default.

      (Noticed as part of SOLR-8542 work.)

      1. SOLR-9385.patch
        24 kB
        Christine Poerschke
      2. SOLR-9385.patch
        24 kB
        Christine Poerschke

        Activity

        Hide
        dsmiley David Smiley added a comment -

        +1 love it!

        getParser's javadocs refer to QParserPlugin.DEFAULT_QTYPE but it'd be more clear if in addition it stated it like "lucene" (QParserPlugin.DEFAULT_QTYPE) so it's immediately clear to anyone reading it without having to go chasing that constant down.

        BTW, I anticipate you're going to add me to CHANGES.txt – please don't. IMO this feedback is too trivial to warrant it.

        Show
        dsmiley David Smiley added a comment - +1 love it! getParser's javadocs refer to QParserPlugin.DEFAULT_QTYPE but it'd be more clear if in addition it stated it like "lucene" (QParserPlugin.DEFAULT_QTYPE) so it's immediately clear to anyone reading it without having to go chasing that constant down. BTW, I anticipate you're going to add me to CHANGES.txt – please don't. IMO this feedback is too trivial to warrant it.
        Hide
        cpoerschke Christine Poerschke added a comment -

        Thanks for the review and mentioning about the javadocs, it made me go see if there is a test already for QParserPlugin.DEFAULT_QTYPE being "lucene" (as the javadocs will mention) and i didn't find such a test and so adding it as part of the patch.

        Show
        cpoerschke Christine Poerschke added a comment - Thanks for the review and mentioning about the javadocs, it made me go see if there is a test already for QParserPlugin.DEFAULT_QTYPE being "lucene" (as the javadocs will mention) and i didn't find such a test and so adding it as part of the patch.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 9d784a6693496e46aeddbb25193cb1e8ec0b54b2 in lucene-solr's branch refs/heads/master from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9d784a6 ]

        SOLR-9385: Add QParser.getParser(String,SolrQueryRequest) variant.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 9d784a6693496e46aeddbb25193cb1e8ec0b54b2 in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9d784a6 ] SOLR-9385 : Add QParser.getParser(String,SolrQueryRequest) variant.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit fc9a010e5839fd957efbef16eeecdada0014d759 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fc9a010 ]

        SOLR-9385: Add QParser.getParser(String,SolrQueryRequest) variant.

        Show
        jira-bot ASF subversion and git services added a comment - Commit fc9a010e5839fd957efbef16eeecdada0014d759 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fc9a010 ] SOLR-9385 : Add QParser.getParser(String,SolrQueryRequest) variant.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit dbe6f6a108986535ae2057af9bfd33e742048788 in lucene-solr's branch refs/heads/master from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dbe6f6a ]

        SOLR-9385: remove unused import in SpellCheckComponent.java

        Show
        jira-bot ASF subversion and git services added a comment - Commit dbe6f6a108986535ae2057af9bfd33e742048788 in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dbe6f6a ] SOLR-9385 : remove unused import in SpellCheckComponent.java
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ae80f3ed0323fdf634c82635a85dff5aafb19fba in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ae80f3e ]

        SOLR-9385: remove unused import in SpellCheckComponent.java

        Show
        jira-bot ASF subversion and git services added a comment - Commit ae80f3ed0323fdf634c82635a85dff5aafb19fba in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ae80f3e ] SOLR-9385 : remove unused import in SpellCheckComponent.java

          People

          • Assignee:
            cpoerschke Christine Poerschke
            Reporter:
            cpoerschke Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development