Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9381

Snitch for freedisk uses root path not Solr home

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.1, master (7.0)
    • Fix Version/s: 6.2.1, 6.3, master (7.0)
    • Component/s: SolrCloud
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None
    • Flags:
      Patch

      Description

      The path used for the freedisk snitch value is hardcoded to / whereas it should be using Solr home. It's fairly common to use hardware for Solr with multiple physical disks on different mount points, with multiple Solr instances running on the box, each pointing its Solr home to a different disk. In this case, the value reported for the freedisk snitch value is wrong, because it's based on the root filesystem space.

      Patch changes this to use solr home from the CoreContainer.

      1. SOLR-9381.patch
        4 kB
        Tim Owen
      2. SOLR-9381.patch
        3 kB
        Tim Owen

        Activity

        Hide
        TimOwen Tim Owen added a comment -

        This code was last changed by Ramkumar Aiyengar and Noble Paul .. do you think this fix is appropriate in all cases?

        Show
        TimOwen Tim Owen added a comment - This code was last changed by Ramkumar Aiyengar and Noble Paul .. do you think this fix is appropriate in all cases?
        Hide
        noble.paul Noble Paul added a comment -

        In reality solr.home also may not be right. cores are created at CoreContainer.getCoreRootDirectory()

        Show
        noble.paul Noble Paul added a comment - In reality solr.home also may not be right. cores are created at CoreContainer.getCoreRootDirectory()
        Hide
        TimOwen Tim Owen added a comment -

        Thanks, I'll make that change soon and replace the patch.

        Show
        TimOwen Tim Owen added a comment - Thanks, I'll make that change soon and replace the patch.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c56d832349a32fc3f975d4a41a52e7348cc88111 in lucene-solr's branch refs/heads/master from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c56d832 ]

        SOLR-9381: Snitch for freedisk uses '/' instead of 'coreRootDirectory'

        Show
        jira-bot ASF subversion and git services added a comment - Commit c56d832349a32fc3f975d4a41a52e7348cc88111 in lucene-solr's branch refs/heads/master from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c56d832 ] SOLR-9381 : Snitch for freedisk uses '/' instead of 'coreRootDirectory'
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ced96c5fd5f8c960ada66d4d10aecdcd5bc69a9d in lucene-solr's branch refs/heads/branch_6x from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ced96c5 ]

        SOLR-9381: Snitch for freedisk uses '/' instead of 'coreRootDirectory'

        Show
        jira-bot ASF subversion and git services added a comment - Commit ced96c5fd5f8c960ada66d4d10aecdcd5bc69a9d in lucene-solr's branch refs/heads/branch_6x from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ced96c5 ] SOLR-9381 : Snitch for freedisk uses '/' instead of 'coreRootDirectory'
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c56d832349a32fc3f975d4a41a52e7348cc88111 in lucene-solr's branch refs/heads/apiv2 from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c56d832 ]

        SOLR-9381: Snitch for freedisk uses '/' instead of 'coreRootDirectory'

        Show
        jira-bot ASF subversion and git services added a comment - Commit c56d832349a32fc3f975d4a41a52e7348cc88111 in lucene-solr's branch refs/heads/apiv2 from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c56d832 ] SOLR-9381 : Snitch for freedisk uses '/' instead of 'coreRootDirectory'
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Re-opened to back-port to 6.2.1

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Re-opened to back-port to 6.2.1
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f4673ca4763964950eaedf2e172f2f5015669da0 in lucene-solr's branch refs/heads/branch_6_2 from Noble Paul
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f4673ca ]

        SOLR-9381: Snitch for freedisk uses '/' instead of 'coreRootDirectory'

        (cherry picked from commit ced96c5)

        Show
        jira-bot ASF subversion and git services added a comment - Commit f4673ca4763964950eaedf2e172f2f5015669da0 in lucene-solr's branch refs/heads/branch_6_2 from Noble Paul [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f4673ca ] SOLR-9381 : Snitch for freedisk uses '/' instead of 'coreRootDirectory' (cherry picked from commit ced96c5)
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Closing after 6.2.1 release

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.2.1 release

          People

          • Assignee:
            noble.paul Noble Paul
            Reporter:
            TimOwen Tim Owen
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development