Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9378

Avoid sending the shard.url parameter in shard requests

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • None
    • main (10.0), 9.3
    • search, SolrCloud
    • None

    Description

      The shard.url parameter contains a list of all replicas for a shard. One of those is chosen by the HttpShardHandler to execute the request. So, it is used only within the context of processing request on a distributor node as a special storage for a list of replicas urls between the prep and execution phase of HttpShardHandler. There is no real need to send this parameter down to the chosen shard.

      However, Hoss pointed out to me that removing this would break ShardAugmenterFactory so we need to figure out if/how we can do this. Personally, I don't think it is at all useful to write down ​all​ replicas with the document without telling which replica really served the query.

      Attachments

        1. SOLR-9378.patch
          18 kB
          Chris M. Hostetter
        2. SOLR-9378-1.patch
          21 kB
          Chris M. Hostetter
        3. SOLR-9378-2.patch
          22 kB
          Chris M. Hostetter

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            hossman Chris M. Hostetter
            shalin Shalin Shekhar Mangar
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment