Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9365

Reduce noise in solr logs during graceful shutdown

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.3, 7.0
    • Component/s: SolrCloud
    • Security Level: Public (Default Security Level. Issues are Public)

      Description

      There is too much unnecessary logging of exceptions during a graceful shutdown. This is mostly due to:

      1. Watcher invocations fired after the zk callback executor is shutdown, and
      2. Session expiry because of zkclient or embedded zk server shutdown

      We should add a simple check for such conditions to reduce noise in our logs.

      1. SOLR-9365.patch
        3 kB
        Cao Manh Dat

        Activity

        Hide
        caomanhdat Cao Manh Dat added a comment -

        First patch for this issue, It remove some boilerplate error when graceful shutdown solr cluster :

        • RejectedExecutionException when watcher being executed after the zk callback is shutdown
        • Cannot find core by name when election happen after the cores is shutdown
        Show
        caomanhdat Cao Manh Dat added a comment - First patch for this issue, It remove some boilerplate error when graceful shutdown solr cluster : RejectedExecutionException when watcher being executed after the zk callback is shutdown Cannot find core by name when election happen after the cores is shutdown
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 3fe14866838a9939a940b954fd97b8ad9be2226e in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3fe1486 ]

        SOLR-9365: Reduce noise in solr logs during graceful shutdown

        Show
        jira-bot ASF subversion and git services added a comment - Commit 3fe14866838a9939a940b954fd97b8ad9be2226e in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3fe1486 ] SOLR-9365 : Reduce noise in solr logs during graceful shutdown
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 47a85502085e75493576bb805d62d493c9025ed8 in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=47a8550 ]

        SOLR-9365: Reduce noise in solr logs during graceful shutdown

        (cherry picked from commit 3fe1486)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 47a85502085e75493576bb805d62d493c9025ed8 in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=47a8550 ] SOLR-9365 : Reduce noise in solr logs during graceful shutdown (cherry picked from commit 3fe1486)
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        I added another such check in ZkController.runLeaderProcess() method.

        Thanks Dat!

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - I added another such check in ZkController.runLeaderProcess() method. Thanks Dat!
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Closing after 6.3.0 release.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.3.0 release.

          People

          • Assignee:
            caomanhdat Cao Manh Dat
            Reporter:
            shalinmangar Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development