Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9358

[AngularUI] In Cloud->Tree file view area, collapse metadata by default

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.2, 7.0
    • Component/s: Admin UI
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      Spinoff from SOLR-8379

      In Cloud->Tree UI, the metadata section on top of file content takes up valuable space. Suggest to collapse that part by default and make it possible to expand on demand by clicking. That will avoid scrolling on small screens.

      1. Metadata expanded.png
        87 kB
        Jan Høydahl
      2. Metadata with arrow.png
        101 kB
        Jan Høydahl
      3. Metadata with plus.png
        97 kB
        Jan Høydahl
      4. SOLR-9358.patch
        2 kB
        Jan Høydahl
      5. SOLR-9358-plusimg.patch
        2 kB
        Jan Høydahl

        Activity

        Hide
        janhoy Jan Høydahl added a comment - - edited

        This is how it will look like by default:

        And this is after expanding:

        I'm using unicode chars ▽ (#x25bd) and ▷ (#x25b7) directly in JS code, it works in Chrome and Firefox on Mac. Any concerns with this approach? See also this article.

        Show
        janhoy Jan Høydahl added a comment - - edited This is how it will look like by default: And this is after expanding: I'm using unicode chars ▽ (#x25bd) and ▷ (#x25b7) directly in JS code, it works in Chrome and Firefox on Mac. Any concerns with this approach? See also this article .
        Hide
        janhoy Jan Høydahl added a comment -

        Upayavira or Erick Erickson: appreciate your blessing before committing.

        Show
        janhoy Jan Høydahl added a comment - Upayavira or Erick Erickson : appreciate your blessing before committing.
        Hide
        upayavira Upayavira added a comment -

        Absolutely. The metadata isn't something I've ever paid attention to - it is always the data that I want to see, so you have my blessing.

        Show
        upayavira Upayavira added a comment - Absolutely. The metadata isn't something I've ever paid attention to - it is always the data that I want to see, so you have my blessing.
        Hide
        upayavira Upayavira added a comment -

        Regarding the unicode arrows, go look in the codebase, you'll find an images directory full of icons. I'm sure you'll find appropriate arrows in there that will give a consistent styling with the rest of the UI.

        Show
        upayavira Upayavira added a comment - Regarding the unicode arrows, go look in the codebase, you'll find an images directory full of icons. I'm sure you'll find appropriate arrows in there that will give a consistent styling with the rest of the UI.
        Hide
        janhoy Jan Høydahl added a comment -

        The best I could find was toggle-small-expand.png and toggle-small.png . Are you aware of arrow style symbols too? Personally I think those looks better

        Show
        janhoy Jan Høydahl added a comment - The best I could find was toggle-small-expand.png and toggle-small.png . Are you aware of arrow style symbols too? Personally I think those looks better
        Hide
        erickerickson Erick Erickson added a comment -

        The functionality looks fine, I'll leave it to Upayavira to argue about the arrows...

        I like removing the metadata by default, that saves considerable space.

        Show
        erickerickson Erick Erickson added a comment - The functionality looks fine, I'll leave it to Upayavira to argue about the arrows... I like removing the metadata by default, that saves considerable space.
        Hide
        janhoy Jan Høydahl added a comment -

        Here's an alternative patch using the plus image through CSS instead of arrow.

        Show
        janhoy Jan Høydahl added a comment - Here's an alternative patch using the plus image through CSS instead of arrow.
        Hide
        janhoy Jan Høydahl added a comment -

        Alternatively we could use chevron-small-expand.png as is done in e.g. Plugins/stats. I'm fine with any...

        Show
        janhoy Jan Høydahl added a comment - Alternatively we could use chevron-small-expand.png as is done in e.g. Plugins/stats. I'm fine with any...
        Hide
        upayavira Upayavira added a comment -

        That plus sign looks good to me. I'd just like us to use something that is consistent with the existing UI. Go for it!

        Show
        upayavira Upayavira added a comment - That plus sign looks good to me. I'd just like us to use something that is consistent with the existing UI. Go for it!
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d86c369533f0d3fc3cda9d15440521f39d84b750 in lucene-solr's branch refs/heads/master from Jan Høydahl
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d86c369 ]

        SOLR-9358: [AngularUI] In Cloud->Tree file view area, collapse metadata by default

        Show
        jira-bot ASF subversion and git services added a comment - Commit d86c369533f0d3fc3cda9d15440521f39d84b750 in lucene-solr's branch refs/heads/master from Jan Høydahl [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d86c369 ] SOLR-9358 : [AngularUI] In Cloud->Tree file view area, collapse metadata by default
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 0dc1cf5ddda83240ed05df86d414a1f7a0e8d44e in lucene-solr's branch refs/heads/branch_6x from Jan Høydahl
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0dc1cf5 ]

        SOLR-9358: [AngularUI] In Cloud->Tree file view area, collapse metadata by default
        (cherry picked from commit d86c369)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 0dc1cf5ddda83240ed05df86d414a1f7a0e8d44e in lucene-solr's branch refs/heads/branch_6x from Jan Høydahl [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0dc1cf5 ] SOLR-9358 : [AngularUI] In Cloud->Tree file view area, collapse metadata by default (cherry picked from commit d86c369)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d86c369533f0d3fc3cda9d15440521f39d84b750 in lucene-solr's branch refs/heads/apiv2 from Jan Høydahl
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d86c369 ]

        SOLR-9358: [AngularUI] In Cloud->Tree file view area, collapse metadata by default

        Show
        jira-bot ASF subversion and git services added a comment - Commit d86c369533f0d3fc3cda9d15440521f39d84b750 in lucene-solr's branch refs/heads/apiv2 from Jan Høydahl [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d86c369 ] SOLR-9358 : [AngularUI] In Cloud->Tree file view area, collapse metadata by default
        Hide
        mikemccand Michael McCandless added a comment -

        Bulk close resolved issues after 6.2.0 release.

        Show
        mikemccand Michael McCandless added a comment - Bulk close resolved issues after 6.2.0 release.

          People

          • Assignee:
            janhoy Jan Høydahl
            Reporter:
            janhoy Jan Høydahl
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development