Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9350

JSON Facet method:"stream" configurable use of filter cache threshold

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.2
    • Component/s: Facet Module
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      When using method:"stream" in the JSON facet API, the code will currently always use the filter cache for each value. This basically blows out the filter cache. The code has smarts to pick a doc count threshold to use the filter cache, however a small bug prevents it's use.

      1. SOLR_9350.patch
        1 kB
        David Smiley

        Activity

        Hide
        dsmiley David Smiley added a comment - - edited

        The bug was locally declaring a variable by the same name as a field. This issue might be considered a bug, or improvement since the API works but now it's more efficient

        Show
        dsmiley David Smiley added a comment - - edited The bug was locally declaring a variable by the same name as a field. This issue might be considered a bug, or improvement since the API works but now it's more efficient
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit b63bb5167abad6da30e09fa405f8b99e11a8ff21 in lucene-solr's branch refs/heads/master from David Smiley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b63bb51 ]

        SOLR-9350: JSON Facet and method=stream: cacheDf threshold now gates use of the filter cache

        Show
        jira-bot ASF subversion and git services added a comment - Commit b63bb5167abad6da30e09fa405f8b99e11a8ff21 in lucene-solr's branch refs/heads/master from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b63bb51 ] SOLR-9350 : JSON Facet and method=stream: cacheDf threshold now gates use of the filter cache
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 91d7b53d9c02804b02f282ff0ff403d21fa36f9b in lucene-solr's branch refs/heads/branch_6x from David Smiley
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=91d7b53 ]

        SOLR-9350: JSON Facet and method=stream: cacheDf threshold now gates use of the filter cache
        (cherry picked from commit b63bb51)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 91d7b53d9c02804b02f282ff0ff403d21fa36f9b in lucene-solr's branch refs/heads/branch_6x from David Smiley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=91d7b53 ] SOLR-9350 : JSON Facet and method=stream: cacheDf threshold now gates use of the filter cache (cherry picked from commit b63bb51)
        Hide
        dsmiley David Smiley added a comment -

        I gave you credit Yonik Seeley since your optimization/feature was there, it just wasn't activated

        Show
        dsmiley David Smiley added a comment - I gave you credit Yonik Seeley since your optimization/feature was there, it just wasn't activated
        Hide
        yseeley@gmail.com Yonik Seeley added a comment -

        Thanks, changes look good!

        Show
        yseeley@gmail.com Yonik Seeley added a comment - Thanks, changes look good!
        Hide
        mikemccand Michael McCandless added a comment -

        Bulk close resolved issues after 6.2.0 release.

        Show
        mikemccand Michael McCandless added a comment - Bulk close resolved issues after 6.2.0 release.

          People

          • Assignee:
            dsmiley David Smiley
            Reporter:
            dsmiley David Smiley
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development