Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9335

Move solr stats collections to use LongAdder

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.2, master (7.0)
    • Component/s: None
    • Security Level: Public (Default Security Level. Issues are Public)
    • Labels:
      None

      Description

      With Java 8 we can use LongAdder which has more throughput under high contention .

      These classes of Solr should benefit from LongAdder

      • Caches ( ConcurentLRUCache / LRUCache )
      • Searches ( RequestHandlerBase )
      • Updates ( DirectUpdateHandler2 )
      1. SOLR-9335.patch
        25 kB
        Varun Thacker
      2. SOLR-9335.patch
        20 kB
        Varun Thacker

        Activity

        Hide
        dsmiley David Smiley added a comment -

        +1 LGTM

        Show
        dsmiley David Smiley added a comment - +1 LGTM
        Hide
        varunthacker Varun Thacker added a comment -

        Thanks David for the review!

        Updated patch which fixes the test case which was broken by this. I'll run tests and if everything goes fine commit it tomorrow

        Show
        varunthacker Varun Thacker added a comment - Thanks David for the review! Updated patch which fixes the test case which was broken by this. I'll run tests and if everything goes fine commit it tomorrow
        Hide
        jwartes Jeff Wartes added a comment -

        fwiw, SOLR-8241 involves cache implementations that (among other improvements) uses LongAddr, and the author has been having trouble getting committer attention.

        Show
        jwartes Jeff Wartes added a comment - fwiw, SOLR-8241 involves cache implementations that (among other improvements) uses LongAddr, and the author has been having trouble getting committer attention.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f906862afe2ba4ef7ac521555ee59a86ef0b2a75 in lucene-solr's branch refs/heads/master from Varun Thacker
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f906862 ]

        SOLR-9335: Switch Solr cache/search/update stats counters to use LongAdder

        Show
        jira-bot ASF subversion and git services added a comment - Commit f906862afe2ba4ef7ac521555ee59a86ef0b2a75 in lucene-solr's branch refs/heads/master from Varun Thacker [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f906862 ] SOLR-9335 : Switch Solr cache/search/update stats counters to use LongAdder
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 7b6a16c30b114eadb120c47e8ec1b7f513306054 in lucene-solr's branch refs/heads/branch_6x from Varun Thacker
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7b6a16c ]

        SOLR-9335: Switch Solr cache/search/update stats counters to use LongAdder

        Show
        jira-bot ASF subversion and git services added a comment - Commit 7b6a16c30b114eadb120c47e8ec1b7f513306054 in lucene-solr's branch refs/heads/branch_6x from Varun Thacker [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7b6a16c ] SOLR-9335 : Switch Solr cache/search/update stats counters to use LongAdder
        Hide
        mikemccand Michael McCandless added a comment -

        Bulk close resolved issues after 6.2.0 release.

        Show
        mikemccand Michael McCandless added a comment - Bulk close resolved issues after 6.2.0 release.

          People

          • Assignee:
            varunthacker Varun Thacker
            Reporter:
            varunthacker Varun Thacker
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development