Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.3, 7.0
    • Component/s: SolrCloud
    • Labels:
      None

      Activity

      Hide
      dsmiley David Smiley added a comment -

      I think the existence of this issue is confusing considering the parent issue has basically the same title. For features that have 2 parts, (non-cloud/standalone then cloud), I think it's fine and less JIRA noise to have 2 issues, with the second depending on the first via a link.

      Show
      dsmiley David Smiley added a comment - I think the existence of this issue is confusing considering the parent issue has basically the same title. For features that have 2 parts, (non-cloud/standalone then cloud), I think it's fine and less JIRA noise to have 2 issues, with the second depending on the first via a link.
      Hide
      hgadre Hrishikesh Gadre added a comment -

      David Smiley Thanks for the feedback. I think that make sense. I just thought having sub-tasks would help us to organize the work appropriately. But JIRA linking can also work.

      BTW I have implemented the collection level snapshots functionality. I have pushed a private branch here,
      https://github.com/hgadre/lucene-solr/commit/a0ffa0ffffafa6b88fb4aa4ccf4d7b9c7a2ebd17

      Once you commit the changes for SOLR-9269, I will rebase and submit the pull request.

      Show
      hgadre Hrishikesh Gadre added a comment - David Smiley Thanks for the feedback. I think that make sense. I just thought having sub-tasks would help us to organize the work appropriately. But JIRA linking can also work. BTW I have implemented the collection level snapshots functionality. I have pushed a private branch here, https://github.com/hgadre/lucene-solr/commit/a0ffa0ffffafa6b88fb4aa4ccf4d7b9c7a2ebd17 Once you commit the changes for SOLR-9269 , I will rebase and submit the pull request.
      Hide
      dsmiley David Smiley added a comment -

      Hrishikesh Gadre I'm hopeful you'll get committer attention on this from one of your colleagues. There are other things vying for my time. Take care and maybe I'll see you at L/S Revolution this year.

      Show
      dsmiley David Smiley added a comment - Hrishikesh Gadre I'm hopeful you'll get committer attention on this from one of your colleagues. There are other things vying for my time. Take care and maybe I'll see you at L/S Revolution this year.
      Hide
      hgadre Hrishikesh Gadre added a comment -

      David Smiley Thanks for the help w.r.t. SOLR-9269. Here is the pull request for this functionality.

      https://github.com/apache/lucene-solr/pull/65

      Show
      hgadre Hrishikesh Gadre added a comment - David Smiley Thanks for the help w.r.t. SOLR-9269 . Here is the pull request for this functionality. https://github.com/apache/lucene-solr/pull/65
      Hide
      yseeley@gmail.com Yonik Seeley added a comment -

      Mostly reviewing this from the perspective of public API and changes to existing code, and it looks good to me!
      super minor: the use of public API constants in the tests mean that one can change one of them and still have everything work. I often tend to use literals in tests, and I've seen others assert the constants are the expected literal.

      Show
      yseeley@gmail.com Yonik Seeley added a comment - Mostly reviewing this from the perspective of public API and changes to existing code, and it looks good to me! super minor: the use of public API constants in the tests mean that one can change one of them and still have everything work. I often tend to use literals in tests, and I've seen others assert the constants are the expected literal.
      Hide
      yseeley@gmail.com Yonik Seeley added a comment -

      Starting to run unit tests now, and will commit later if everything looks good.

      Show
      yseeley@gmail.com Yonik Seeley added a comment - Starting to run unit tests now, and will commit later if everything looks good.
      Hide
      hgadre Hrishikesh Gadre added a comment -

      Yonik Seeley Thanks for the review. I have made a few changes over the weekend. Let me update the patch and send it out for review.

      Show
      hgadre Hrishikesh Gadre added a comment - Yonik Seeley Thanks for the review. I have made a few changes over the weekend. Let me update the patch and send it out for review.
      Hide
      hgadre Hrishikesh Gadre added a comment -

      Yonik Seeley I have updated the PR with all the changes. Please take a look.

      Show
      hgadre Hrishikesh Gadre added a comment - Yonik Seeley I have updated the PR with all the changes. Please take a look.
      Hide
      jira-bot ASF subversion and git services added a comment -

      Commit 57ba96145ce8233034c67ffaead22d3bd7f3460f in lucene-solr's branch refs/heads/master from Yonik Seeley
      [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=57ba961 ]

      SOLR-9326: Ability to create/delete/list snapshots at collection level.

      Show
      jira-bot ASF subversion and git services added a comment - Commit 57ba96145ce8233034c67ffaead22d3bd7f3460f in lucene-solr's branch refs/heads/master from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=57ba961 ] SOLR-9326 : Ability to create/delete/list snapshots at collection level.
      Hide
      yseeley@gmail.com Yonik Seeley added a comment -

      Committed. Thanks Hrishikesh!

      Show
      yseeley@gmail.com Yonik Seeley added a comment - Committed. Thanks Hrishikesh!
      Hide
      ctargett Cassandra Targett added a comment -

      Hrishikesh Gadre, can you provide some better information on how this is used by users so we can add documentation on this for the Solr Ref Guide? Or perhaps it is not ready to be documented?

      Show
      ctargett Cassandra Targett added a comment - Hrishikesh Gadre , can you provide some better information on how this is used by users so we can add documentation on this for the Solr Ref Guide? Or perhaps it is not ready to be documented?
      Hide
      hgadre Hrishikesh Gadre added a comment -

      Cassandra Targett I am waiting for SOLR-9688 ( which in turn requires SOLR-9055) to be committed. That way I can provide a comprehensive documentation. Does that make sense ?

      Show
      hgadre Hrishikesh Gadre added a comment - Cassandra Targett I am waiting for SOLR-9688 ( which in turn requires SOLR-9055 ) to be committed. That way I can provide a comprehensive documentation. Does that make sense ?
      Hide
      ctargett Cassandra Targett added a comment -

      Sure. I'll put this into the Ref Guide backlog then, and we'll wait for the rest to be ready.

      Show
      ctargett Cassandra Targett added a comment - Sure. I'll put this into the Ref Guide backlog then, and we'll wait for the rest to be ready.
      Hide
      shalinmangar Shalin Shekhar Mangar added a comment -

      Closing after 6.3.0 release.

      Show
      shalinmangar Shalin Shekhar Mangar added a comment - Closing after 6.3.0 release.

        People

        • Assignee:
          yseeley@gmail.com Yonik Seeley
          Reporter:
          hgadre Hrishikesh Gadre
        • Votes:
          0 Vote for this issue
          Watchers:
          6 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development