What does "just count" mean? Will I not be able to delete a specific replica, or is this in addition to being able to delete a selected replica? I think that having an API like "delete replicas such that only X remain" is fine, but I would like to also be able to specify which replica I want to delete (since in my case I need to control that).

The command would take the following parameters

• count: no:of replicas to be removed
• collection : (required) The collection name
• shard : (optional) . If shard is absent, 'count' no:of replicas from each shard will be removed

The old functionality continues to be there. This kicks in when 'count' is specified as a parameter

Thanks Noble Paul. The issue description is a bit misleading (should accept just count) but thanks for clarifying.

Noble Paul When you mean intelligently, I am assuming the following

1) If it is the only replica it would not get deleted.
2) If there are multiple replicas, then it will remove the replica that is not the leader (to lessen operations in the cluster)

Let me know if there is anything else that is needed. I am testing out patch for this as we speak.

Screenshots with
a) API with Count param and intelligent removal
b) API with count and only 1 replica remaining
c) API with count and more replicas are requested than present
d) Old API call without count param working as expected

Noble Paul Please let me know if this is missing anything

Looks mostly fine. Can you add a test case?

Sure. Let me try that out.

With Tests. Ran ant test with full suite and the ant test with -Dtestcase=DeleteReplicaTest to verify all passed.

Can you just update the patch to the current trunk

It is already rebased on top of current master. Did you mean commit to trunk?

I refactored everything out from OverseerCollectionMessageHandler I don't think this applies to the trunk after that

further optimized cache

Ok i will rebase on master again. BTW i think you uploaded the patch for 9310 here.

Noble Paul Rebased on master. Ran E2e Tests and unit tests.

GitHub user nitingithub opened a pull request:

https://github.com/apache/lucene-solr/pull/70

DELETEREPLICA should be able to accept just count and remove replicas intelligently

DELETEREPLICA should be able to accept just count and remove replicas intelligently
SOLR-9319

More details: https://issues.apache.org/jira/browse/SOLR-9319

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitingithub/lucene-solr master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/70.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #70

commit 332e447f085e779e4b56ab0617bf095385e5ffae
Author: Nitin Sharma <nitin.sharma@bloomreach.com>
Date: 2016-08-23T02:44:39Z

DELETEREPLICA should be able to accept just count and remove replicas intelligenty
SOLR-9319

The testcases could use the async option. The rest look fine

Github user nitingithub closed the pull request at:

https://github.com/apache/lucene-solr/pull/70

GitHub user nitingithub opened a pull request:

https://github.com/apache/lucene-solr/pull/72

SOLR-9319 - DELETEREPLICA should be able to accept just count and remove replicas intelligently

Added functionality and one test in async mode and other in sync mode

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nitingithub/lucene-solr master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/lucene-solr/pull/72.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #72

commit 332e447f085e779e4b56ab0617bf095385e5ffae
Author: Nitin Sharma <nitin.sharma@bloomreach.com>
Date: 2016-08-23T02:44:39Z

DELETEREPLICA should be able to accept just count and remove replicas intelligenty
SOLR-9319

commit 6cb119d12915d486eb40b63887d6a83abe08a523
Author: Nitin Sharma <nitin.sharma@bloomreach.com>
Date: 2016-08-25T22:00:21Z

Adding one more test in async mode

commit c2a1855d305cd61e57f6b07a35395bb11463fa9c
Author: Nitin Sharma <nitin.sharma@bloomreach.com>
Date: 2016-08-25T22:02:13Z

Adding one more test in async mode

Noble Paul Added one test in async mode and the other in sync mode. Closed the old pull request #70. Raised a new one #72.

Can you post a .patch file. I git a bizarre patch when I download from github

look at the multiple Test files

Hi Noble,

I think if you put a ".patch" after the pull request URL you get the actual patch : https://github.com/apache/lucene-solr/pull/72.patch

I know that . If you want to know the problem look at the screenshot I have osted

Updated patch

Noble Paul Any updates to the patch needed?

don't think so. Will review more and commit it after SOLR-9461

Thanks!

Commit e203c9af95461216d9ff39a108c86c5ce4308f5f in lucene-solr's branch refs/heads/master from Noble Paul
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e203c9a ]

SOLR-9319: DELETEREPLICA can accept a 'count' and remove appropriate replicas

Commit 4b8f574418770f6872b7d3cbfca6bc028a910426 in lucene-solr's branch refs/heads/branch_6x from Noble Paul
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4b8f574 ]

SOLR-9319: DELETEREPLICA can accept a 'count' and remove appropriate replicas

Commit 1a78ab621ff24e9d31d6f6e80c8771012ceac2d7 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1a78ab6 ]

SOLR-9319: Move to the right section in CHANGES.txt

Commit b5f5bb10aca8b6fd7cf4445ca1e2adee9c7a2ad4 in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b5f5bb1 ]

SOLR-9319: Move to the right section in CHANGES.txt

(cherry picked from commit 1a78ab6)

Commit 11a98a89fd63271f969ae1072159c410ad6417cc in lucene-solr's branch refs/heads/branch_6x from Alan Woodward
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=11a98a8 ]

SOLR-9132: Cut over DeleteReplica tests

Also fixes some bugs in CollectionAdminRequest.DeleteReplica from SOLR-9319

Commit be4233cb567a8e65ef67d0fc1c8e47936e155a23 in lucene-solr's branch refs/heads/master from Alan Woodward
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=be4233c ]

SOLR-9132: Cut over DeleteReplica tests

Also fixes some bugs in CollectionAdminRequest.DeleteReplica from SOLR-9319