Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9300

fix replace expression in GetMavenDependenciesTask's dependencyToArtifactId method.

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.6, 6.2, 7.0
    • Component/s: None
    • Labels:
      None

      Description

      Fix replace expression in GetMavenDependenciesTask's dependencyToArtifactId method. (Christine Poerschke, Daniel Collins)

      One line replace vs. replaceAll in GetMavenDependenciesTask.java since String replace takes the CharSequence (or char) literally and String replaceAll (or replaceFirst) takes a regular expression such a "(?<!solr-)analysis-".

      (As an aside, in case anyone else is also wondering about the meaning of (?<!solr-) in the expression, the Pattern javadocs list a special construct (?<!X) as

      X, via zero-width negative lookbehind

      and the Lookahead and Lookbehind Zero-Length Assertions tutorial helped us understand the meaning of that list entry.)

        Attachments

        1. SOLR-9300.patch
          0.8 kB
          Christine Poerschke

          Issue Links

            Activity

              People

              • Assignee:
                cpoerschke Christine Poerschke
                Reporter:
                cpoerschke Christine Poerschke
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: