[SOLR-9295] Remove Unicode BOM (U+FEFF) from text files in codebase

• Type: Bug
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 7.0
• Fix Version/s: 6.2, 7.0
• Component/s: scripts and tools
• Assignee: Unassigned
• Reporter: Shawn Heisey
• Created: 11/Jul/16 18:05
• Updated: 08/Jun/19 15:37
• Resolved: 12/Oct/16 21:06

Description

When starting Solr built from the master branch on Windows, this is what you see:

C:\Users\elyograg\git\lucene-solr\solr>bin\solr start

C:\Users\elyograg\git\lucene-solr\solr>@REM
'@REM' is not recognized as an internal or external command,
operable program or batch file.

The three extra characters, found at the very beginning of the solr.cmd script, are a Unicode BOM, and are invisible to vim, notepad, and notepad++.

The problem does not exist in 6.1.0, but IS present in branch_6x and master.

Using grep to find this character in the entire codebase, I found one other relevant file with a BOM. All others were binary (images, jars, git pack files, etc):

./solr/webapp/web/js/lib/jquery.blockUI.js