Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 6.0, 6.1
    • Fix Version/s: 6.2, 7.0
    • Component/s: Admin UI
    • Labels:

      Description

      Using the Core Admin page on the new Admin UI, there is no way to submit a Swap Cores request. After choosing the Swap action for an existing core and selecting a core to swap with, clicking the Swap Cores button does nothing.

        Issue Links

          Activity

          Hide
          elyograg Shawn Heisey added a comment -

          Core swapping would do very bad things if you're in cloud mode. So I need to make sure you're not in cloud mode. If you are, then it would be correct for it to not work, but you should get an error message instead of what's happening now.

          If you're not in cloud mode, then this is a bigger problem. Note that you should be able to use the CoreAdmin API directly (in non-cloud mode) to accomplish the swap. I would like to know whether this works, or if it's just the admin UI.

          https://cwiki.apache.org/confluence/display/solr/CoreAdmin+API

          Show
          elyograg Shawn Heisey added a comment - Core swapping would do very bad things if you're in cloud mode. So I need to make sure you're not in cloud mode. If you are, then it would be correct for it to not work, but you should get an error message instead of what's happening now. If you're not in cloud mode, then this is a bigger problem. Note that you should be able to use the CoreAdmin API directly (in non-cloud mode) to accomplish the swap. I would like to know whether this works, or if it's just the admin UI. https://cwiki.apache.org/confluence/display/solr/CoreAdmin+API
          Hide
          elyograg Shawn Heisey added a comment -

          Just tried it myself with a newly downloaded Solr 6.1.0.

          The old admin UI works. The new one doesn't. When Nikitas says that the "Swap" button does nothing ... he means that absolutely nothing happens. It's not just that the swap doesn't happen ... the UI literally doesn't change at all.

          Show
          elyograg Shawn Heisey added a comment - Just tried it myself with a newly downloaded Solr 6.1.0. The old admin UI works. The new one doesn't. When Nikitas says that the "Swap" button does nothing ... he means that absolutely nothing happens. It's not just that the swap doesn't happen ... the UI literally doesn't change at all.
          Hide
          erickerickson Erick Erickson added a comment -

          Hmmm, Anyone with UI and Angular JS skills would be very welcome. The new UI has a lot of possibilities for expanding its functionality and the burden shouldn't be on a single person who's already done yeoman's duty with it. I'm totally clueless here...

          Show
          erickerickson Erick Erickson added a comment - Hmmm, Anyone with UI and Angular JS skills would be very welcome. The new UI has a lot of possibilities for expanding its functionality and the burden shouldn't be on a single person who's already done yeoman's duty with it. I'm totally clueless here...
          Hide
          elyograg Shawn Heisey added a comment -

          Same problem in the master branch.

          Show
          elyograg Shawn Heisey added a comment - Same problem in the master branch.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user arafalov opened a pull request:

          https://github.com/apache/lucene-solr/pull/63

          SOLR-9232: Fixed Core Swap implementation

          Fixed:

          • Incorrect non-scoped variable use that hid the message and shadowed the root case
          • Fixed incorrect branch condition
          • Fixed missing request parameter to actually trigger the SWAP command

          Tested on Chrome and Firefox on mac against latest master.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/arafalov/lucene-solr-contributions alex-SOLR-9232

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/lucene-solr/pull/63.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #63


          commit b0b4052bb6d11ca5f4e2a91359a00dd61b3068a1
          Author: Alexandre Rafalovitch <arafalov@gmail.com>
          Date: 2016-08-03T09:06:18Z

          Merge pull request #1 from apache/master

          Update to latest Apache master

          commit ecb511714c2cf8d3def482d254f419a26d36ff0f
          Author: Alexandre Rafalovitch <arafalov@gmail.com>
          Date: 2016-08-04T03:01:35Z

          SOLR-9232: Fix Core Swap implementation


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user arafalov opened a pull request: https://github.com/apache/lucene-solr/pull/63 SOLR-9232 : Fixed Core Swap implementation Fixed: Incorrect non-scoped variable use that hid the message and shadowed the root case Fixed incorrect branch condition Fixed missing request parameter to actually trigger the SWAP command Tested on Chrome and Firefox on mac against latest master. You can merge this pull request into a Git repository by running: $ git pull https://github.com/arafalov/lucene-solr-contributions alex- SOLR-9232 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/63.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #63 commit b0b4052bb6d11ca5f4e2a91359a00dd61b3068a1 Author: Alexandre Rafalovitch <arafalov@gmail.com> Date: 2016-08-03T09:06:18Z Merge pull request #1 from apache/master Update to latest Apache master commit ecb511714c2cf8d3def482d254f419a26d36ff0f Author: Alexandre Rafalovitch <arafalov@gmail.com> Date: 2016-08-04T03:01:35Z SOLR-9232 : Fix Core Swap implementation
          Hide
          arafalov Alexandre Rafalovitch added a comment -

          Fixed and tested for non-Cloud use. If the functionality not suitable for Cloud, perhaps we need a separate JIRA to hide the button when in cloud mode. But this one (regression) has been fixed.

          Show
          arafalov Alexandre Rafalovitch added a comment - Fixed and tested for non-Cloud use. If the functionality not suitable for Cloud, perhaps we need a separate JIRA to hide the button when in cloud mode. But this one (regression) has been fixed.
          Hide
          arafalov Alexandre Rafalovitch added a comment -

          In the cloud mode, there is Cores screen and the Collections screen does not have Swap button. So, we only need to cover the standalone mode.

          Show
          arafalov Alexandre Rafalovitch added a comment - In the cloud mode, there is Cores screen and the Collections screen does not have Swap button. So, we only need to cover the standalone mode.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f20e2f3a941c8ffd3f4bac5607bb4b5f782cc29d in lucene-solr's branch refs/heads/master from Alexandre Rafalovitch
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f20e2f3 ]

          SOLR-9232: Fix Swap Cores in Admin UI

          Show
          jira-bot ASF subversion and git services added a comment - Commit f20e2f3a941c8ffd3f4bac5607bb4b5f782cc29d in lucene-solr's branch refs/heads/master from Alexandre Rafalovitch [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f20e2f3 ] SOLR-9232 : Fix Swap Cores in Admin UI
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9ba422ac4482bb6e367d2c0a7a7dc9c3998ab1f9 in lucene-solr's branch refs/heads/branch_6x from Alexandre Rafalovitch
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9ba422a ]

          SOLR-9232: Fix Swap Cores in Admin UI

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9ba422ac4482bb6e367d2c0a7a7dc9c3998ab1f9 in lucene-solr's branch refs/heads/branch_6x from Alexandre Rafalovitch [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9ba422a ] SOLR-9232 : Fix Swap Cores in Admin UI
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user arafalov closed the pull request at:

          https://github.com/apache/lucene-solr/pull/63

          Show
          githubbot ASF GitHub Bot added a comment - Github user arafalov closed the pull request at: https://github.com/apache/lucene-solr/pull/63
          Hide
          mikemccand Michael McCandless added a comment -

          Bulk close resolved issues after 6.2.0 release.

          Show
          mikemccand Michael McCandless added a comment - Bulk close resolved issues after 6.2.0 release.

            People

            • Assignee:
              arafalov Alexandre Rafalovitch
              Reporter:
              tampakis Nikitas Tampakis
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development