Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9209

DIH JdbcDataSource - improve extensibility part 2

    Details

      Description

      This is a follow up to SOLR-8616. Due to changes in SOLR-8612 it's now no longer possible without additional modifications to use a different ResultSetIterator class. The attached patch solves this.

      1. SOLR-9209.patch
        4 kB
        Mikhail Khludnev
      2. SOLR-9209.patch
        1 kB
        Kristine Jetzke

        Issue Links

          Activity

          Hide
          mkhludnev Mikhail Khludnev added a comment -

          TODO add the test attached to SOLR-9256

          Show
          mkhludnev Mikhail Khludnev added a comment - TODO add the test attached to SOLR-9256
          Hide
          mkhludnev Mikhail Khludnev added a comment -

          adding the test method from SOLR-9256. I'm going to commit it soon.

          Show
          mkhludnev Mikhail Khludnev added a comment - adding the test method from SOLR-9256 . I'm going to commit it soon.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 209bfcf02131e6c9196d3f9f6bd69d7ae2a6fc63 in lucene-solr's branch refs/heads/master from Mikhail Khludnev
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=209bfcf ]

          SOLR-9209,SOLR-9256: extracting
          JdbcDataSource.createResultSetIterator(), adding a test for
          ResultSetIterator.hasNext()

          Show
          jira-bot ASF subversion and git services added a comment - Commit 209bfcf02131e6c9196d3f9f6bd69d7ae2a6fc63 in lucene-solr's branch refs/heads/master from Mikhail Khludnev [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=209bfcf ] SOLR-9209 , SOLR-9256 : extracting JdbcDataSource.createResultSetIterator(), adding a test for ResultSetIterator.hasNext()
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 77409fd43264e57d1b65f5fee3b9c7277d2f740a in lucene-solr's branch refs/heads/branch_6x from Mikhail Khludnev
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=77409fd ]

          SOLR-9209,SOLR-9256: extracting
          JdbcDataSource.createResultSetIterator(), adding a test for
          ResultSetIterator.hasNext()

          Show
          jira-bot ASF subversion and git services added a comment - Commit 77409fd43264e57d1b65f5fee3b9c7277d2f740a in lucene-solr's branch refs/heads/branch_6x from Mikhail Khludnev [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=77409fd ] SOLR-9209 , SOLR-9256 : extracting JdbcDataSource.createResultSetIterator(), adding a test for ResultSetIterator.hasNext()

            People

            • Assignee:
              mkhludnev Mikhail Khludnev
              Reporter:
              tinexw Kristine Jetzke
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development