Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9180

need better cloud & RTG testing of TestPseudoReturnFields

    Details

    • Type: Test
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.2, master (7.0)
    • Component/s: None
    • Labels:
      None

      Description

      on the mailing list, Charles Sanders noted that the [explain] transformer wasn't working in Solr 5(.5.1) - showing a sample query that indicated he was using SolrCloud.

      In 6.0 and on master this works fine, so whatever bug affects 5.x was fixed at some point – but we don't appear to have any cloud based tests that invoke [explain], so we should add something akin to TestPseudoReturnFields to ensure no regressions in the future.

      1. SOLR-9180.patch
        77 kB
        Hoss Man
      2. SOLR-9180.patch
        76 kB
        Hoss Man
      3. SOLR-9180.patch
        37 kB
        Hoss Man

        Issue Links

          Activity

          Hide
          hossman Hoss Man added a comment -

          work in progress patch...

          TestPseudoReturnFields has some asserts that claim they "also check real-time-get from transaction log" – but the test setup is going out of it's way to disable the updateLog (blaming schema12.xml for not suppporting _version_)

          When i tried to fix this to do a true RTG against uncommitted data, I encountered what appears to be a legitimate bug using a psuedo-fields in that situtation – so as i've been making my way building up a new "TestCloudPseudoReturnFields" i've been keeping an eye out for opportunities to add more RTG equivilences of the existing search+asserts as well (in both single node and cloud mode situations) and it looks like there's more then one bug in each situation.

          (You can see the problematic assertions in the patch, but the tests due currently pass due to strategically placed Assume calls to prevent the problematic assertions from running – that way new failures jump out at me easier as i beef up the test(s))

          Show
          hossman Hoss Man added a comment - work in progress patch... TestPseudoReturnFields has some asserts that claim they "also check real-time-get from transaction log" – but the test setup is going out of it's way to disable the updateLog (blaming schema12.xml for not suppporting _version_ ) When i tried to fix this to do a true RTG against uncommitted data, I encountered what appears to be a legitimate bug using a psuedo-fields in that situtation – so as i've been making my way building up a new "TestCloudPseudoReturnFields" i've been keeping an eye out for opportunities to add more RTG equivilences of the existing search+asserts as well (in both single node and cloud mode situations) and it looks like there's more then one bug in each situation. (You can see the problematic assertions in the patch, but the tests due currently pass due to strategically placed Assume calls to prevent the problematic assertions from running – that way new failures jump out at me easier as i beef up the test(s))
          Hide
          hossman Hoss Man added a comment -

          this has taken longer then i originally expected, but now we have some nice and comprehensive tests of various types of psueod-fields in both single node and cloud mode, when doing searchers and when doing RTG, and with RTG using both commited docs and uncommited docs.

          as attached, all tests pass but this is only because of a lot of @AwaitsFix annotations.

          My next step will be to open new jiras for each distinct type of failure seen in these tests, and update the @AwaitsFix for each failure accordingly, then commit & backport the tests to 6x before trying to tackle these individual issues

          Show
          hossman Hoss Man added a comment - this has taken longer then i originally expected, but now we have some nice and comprehensive tests of various types of psueod-fields in both single node and cloud mode, when doing searchers and when doing RTG, and with RTG using both commited docs and uncommited docs. as attached, all tests pass but this is only because of a lot of @AwaitsFix annotations. My next step will be to open new jiras for each distinct type of failure seen in these tests, and update the @AwaitsFix for each failure accordingly, then commit & backport the tests to 6x before trying to tackle these individual issues
          Hide
          hossman Hoss Man added a comment -

          updated patch with all nocommits updated to point at new jiras (linked tothis one)

          A few nocommits related to an idea i had to improve the test further, but i just left those as TODO since i don't want to tackle that until/unless the rest of the known bugs get resolved (i don't want to risk introducing test bugs before the code bugs are resolved)

          plan to commit this patch as is soon unless anyone spots any flaws?

          Show
          hossman Hoss Man added a comment - updated patch with all nocommits updated to point at new jiras (linked tothis one) A few nocommits related to an idea i had to improve the test further, but i just left those as TODO since i don't want to tackle that until/unless the rest of the known bugs get resolved (i don't want to risk introducing test bugs before the code bugs are resolved) plan to commit this patch as is soon unless anyone spots any flaws?
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit fee9526208375fec6a7651249b182fbca1a29703 in lucene-solr's branch refs/heads/branch_6x from Chris Hostetter
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fee9526 ]

          SOLR-9180: More comprehensive tests of psuedo-fields for RTG and SolrCloud requests

          This commit also includes new @AwaitsFix'ed tests for the following known issues...

          • SOLR-9285 ArrayIndexOutOfBoundsException when ValueSourceAugmenter used with RTG on uncommitted doc
          • SOLR-9286 SolrCloud RTG: psuedo-fields (like ValueSourceAugmenter, [shard], etc...) silently fails (even for committed doc)
          • SOLR-9287 single node RTG: NPE if score is requested
          • SOLR-9288 RTG: fl=[docid] silently missing for uncommitted docs
          • SOLR-9289 SolrCloud RTG: fl=[docid] silently ignored for all docs

          (cherry picked from commit ae316f1e39e58d89758f997913a38059d74ccb47)

          Show
          jira-bot ASF subversion and git services added a comment - Commit fee9526208375fec6a7651249b182fbca1a29703 in lucene-solr's branch refs/heads/branch_6x from Chris Hostetter [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fee9526 ] SOLR-9180 : More comprehensive tests of psuedo-fields for RTG and SolrCloud requests This commit also includes new @AwaitsFix'ed tests for the following known issues... SOLR-9285 ArrayIndexOutOfBoundsException when ValueSourceAugmenter used with RTG on uncommitted doc SOLR-9286 SolrCloud RTG: psuedo-fields (like ValueSourceAugmenter, [shard] , etc...) silently fails (even for committed doc) SOLR-9287 single node RTG: NPE if score is requested SOLR-9288 RTG: fl= [docid] silently missing for uncommitted docs SOLR-9289 SolrCloud RTG: fl= [docid] silently ignored for all docs (cherry picked from commit ae316f1e39e58d89758f997913a38059d74ccb47)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit f69e624645f62e1f2224f5ddb035379491a7a0ce in lucene-solr's branch refs/heads/branch_6x from Chris Hostetter
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f69e624 ]

          Merge remote-tracking branch 'refs/remotes/origin/branch_6x' into branch_6x (SOLR-9180)

          Show
          jira-bot ASF subversion and git services added a comment - Commit f69e624645f62e1f2224f5ddb035379491a7a0ce in lucene-solr's branch refs/heads/branch_6x from Chris Hostetter [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f69e624 ] Merge remote-tracking branch 'refs/remotes/origin/branch_6x' into branch_6x ( SOLR-9180 )
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit ae316f1e39e58d89758f997913a38059d74ccb47 in lucene-solr's branch refs/heads/master from Chris Hostetter
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ae316f1 ]

          SOLR-9180: More comprehensive tests of psuedo-fields for RTG and SolrCloud requests

          This commit also includes new @AwaitsFix'ed tests for the following known issues...

          • SOLR-9285 ArrayIndexOutOfBoundsException when ValueSourceAugmenter used with RTG on uncommitted doc
          • SOLR-9286 SolrCloud RTG: psuedo-fields (like ValueSourceAugmenter, [shard], etc...) silently fails (even for committed doc)
          • SOLR-9287 single node RTG: NPE if score is requested
          • SOLR-9288 RTG: fl=[docid] silently missing for uncommitted docs
          • SOLR-9289 SolrCloud RTG: fl=[docid] silently ignored for all docs
          Show
          jira-bot ASF subversion and git services added a comment - Commit ae316f1e39e58d89758f997913a38059d74ccb47 in lucene-solr's branch refs/heads/master from Chris Hostetter [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ae316f1 ] SOLR-9180 : More comprehensive tests of psuedo-fields for RTG and SolrCloud requests This commit also includes new @AwaitsFix'ed tests for the following known issues... SOLR-9285 ArrayIndexOutOfBoundsException when ValueSourceAugmenter used with RTG on uncommitted doc SOLR-9286 SolrCloud RTG: psuedo-fields (like ValueSourceAugmenter, [shard] , etc...) silently fails (even for committed doc) SOLR-9287 single node RTG: NPE if score is requested SOLR-9288 RTG: fl= [docid] silently missing for uncommitted docs SOLR-9289 SolrCloud RTG: fl= [docid] silently ignored for all docs
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 1125a8a8efd53f387d10da1658d005db03cf6ccc in lucene-solr's branch refs/heads/master from Chris Hostetter
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1125a8a ]

          Merge remote-tracking branch 'refs/remotes/origin/master' (SOLR-9180)

          Show
          jira-bot ASF subversion and git services added a comment - Commit 1125a8a8efd53f387d10da1658d005db03cf6ccc in lucene-solr's branch refs/heads/master from Chris Hostetter [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1125a8a ] Merge remote-tracking branch 'refs/remotes/origin/master' ( SOLR-9180 )
          Hide
          mikemccand Michael McCandless added a comment -

          Bulk close resolved issues after 6.2.0 release.

          Show
          mikemccand Michael McCandless added a comment - Bulk close resolved issues after 6.2.0 release.

            People

            • Assignee:
              hossman Hoss Man
              Reporter:
              hossman Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development