Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9136

Separate out the error statistics into server-side error vs client-side error

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: trunk, 6.1
    • Component/s: None
    • Labels:
      None

      Description

      Currently Solr counts both server-side errors (5xx) and client-side errors (4xx) under the same statistic "errors". Operationally it's beneficial to have those errors separated out so different teams can be alerted depending on if Solr is seeing lots of server errors vs. client errors.

      1. SOLR-9136.patch
        3 kB
        Erick Erickson
      2. SOLR-9136.patch
        3 kB
        Jessica Cheng Mallet
      3. SOLR-9136.patch
        3 kB
        Jessica Cheng Mallet

        Activity

        Hide
        erickerickson Erick Erickson added a comment - - edited

        Jessica:

        I'm always in favor of returning more data to the user. I do have one question though in terms of existing installations. An installation that looked at "errors" will now see that value drop by "clientErrors".

        Personally I think this is OK, it's easier to explain than "we didn't change 'errors' because...."

        Hmmm, What do you (or others) think about returning "errors" as the sum of client errors and server errors like now, but returning two new bits like this?

        lst.add("errors", numServerErrors.longValue() + numClientErrors.longValue());
        lst.add("clientErrors", numClientErrors.longValue());
        lst.add("serverErrors", numServerErrors.longValue());

        That would leave existing behavior intact but provide the additional info.

        I'm not so much recommending that as throwing it out there for discussion.

        +1 generally though.

        Show
        erickerickson Erick Erickson added a comment - - edited Jessica: I'm always in favor of returning more data to the user. I do have one question though in terms of existing installations. An installation that looked at "errors" will now see that value drop by "clientErrors". Personally I think this is OK, it's easier to explain than "we didn't change 'errors' because...." Hmmm, What do you (or others) think about returning "errors" as the sum of client errors and server errors like now, but returning two new bits like this? lst.add("errors", numServerErrors.longValue() + numClientErrors.longValue()); lst.add("clientErrors", numClientErrors.longValue()); lst.add("serverErrors", numServerErrors.longValue()); That would leave existing behavior intact but provide the additional info. I'm not so much recommending that as throwing it out there for discussion. +1 generally though.
        Hide
        mewmewball Jessica Cheng Mallet added a comment -

        Sure I like that. I'll make the change. Thanks!

        Show
        mewmewball Jessica Cheng Mallet added a comment - Sure I like that. I'll make the change. Thanks!
        Hide
        erickerickson Erick Erickson added a comment -

        Same patch with CHANGES.txt entry.

        Show
        erickerickson Erick Erickson added a comment - Same patch with CHANGES.txt entry.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 49c81bd8691305cc7d7f8b3d58ed3bfb1dc1e7dc in lucene-solr's branch refs/heads/master from Erick
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=49c81bd ]

        SOLR-9136: Separate out the error statistics into server-side error vs client-side error

        Show
        jira-bot ASF subversion and git services added a comment - Commit 49c81bd8691305cc7d7f8b3d58ed3bfb1dc1e7dc in lucene-solr's branch refs/heads/master from Erick [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=49c81bd ] SOLR-9136 : Separate out the error statistics into server-side error vs client-side error
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e4210b29a83f676583d1db327d2a3d1e10bfb9ad in lucene-solr's branch refs/heads/branch_6x from Erick
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e4210b2 ]

        SOLR-9136: Separate out the error statistics into server-side error vs client-side error

        Show
        jira-bot ASF subversion and git services added a comment - Commit e4210b29a83f676583d1db327d2a3d1e10bfb9ad in lucene-solr's branch refs/heads/branch_6x from Erick [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e4210b2 ] SOLR-9136 : Separate out the error statistics into server-side error vs client-side error
        Hide
        erickerickson Erick Erickson added a comment -

        Thanks Jessica!

        Show
        erickerickson Erick Erickson added a comment - Thanks Jessica!
        Hide
        tomasflobbe Tomás Fernández Löbbe added a comment -

        Erick Erickson Fix Version 6.1?

        Show
        tomasflobbe Tomás Fernández Löbbe added a comment - Erick Erickson Fix Version 6.1?

          People

          • Assignee:
            Unassigned
            Reporter:
            mewmewball Jessica Cheng Mallet
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development