Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9134

RestManager.addManagedResource returns null instead of newly created instance

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5.2, 5.6, 6.0.1, 6.1, master (7.0)
    • Component/s: None
    • Labels:
      None

      Description

      This seems unintended, or if it's intended shall we clarify the javadocs w.r.t. when null/non-null is returned?

      1. SOLR-9134.patch
        1 kB
        Christine Poerschke

        Activity

        Hide
        cpoerschke Christine Poerschke added a comment -

        Steve Rowe and/or Timothy Potter - would you have any thoughts on this patch/ticket? Thanks.

        Show
        cpoerschke Christine Poerschke added a comment - Steve Rowe and/or Timothy Potter - would you have any thoughts on this patch/ticket? Thanks.
        Hide
        thelabdude Timothy Potter added a comment -

        Looks good to me +1

        Show
        thelabdude Timothy Potter added a comment - Looks good to me +1
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1b809e784a413e304ae3f0059a6dd1bde18c2193 in lucene-solr's branch refs/heads/master from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1b809e7 ]

        SOLR-9134: Fix RestManager.addManagedResource return value.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1b809e784a413e304ae3f0059a6dd1bde18c2193 in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1b809e7 ] SOLR-9134 : Fix RestManager.addManagedResource return value.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c432e44264e92a2558ec59500789b0fa0c2c2d0a in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c432e44 ]

        SOLR-9134: Fix RestManager.addManagedResource return value.

        Show
        jira-bot ASF subversion and git services added a comment - Commit c432e44264e92a2558ec59500789b0fa0c2c2d0a in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c432e44 ] SOLR-9134 : Fix RestManager.addManagedResource return value.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 0c27bf76bfdf26760130383080fb0794bf42bd83 in lucene-solr's branch refs/heads/branch_5x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0c27bf7 ]

        SOLR-9134: Fix RestManager.addManagedResource return value.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 0c27bf76bfdf26760130383080fb0794bf42bd83 in lucene-solr's branch refs/heads/branch_5x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0c27bf7 ] SOLR-9134 : Fix RestManager.addManagedResource return value.
        Hide
        steve_rowe Steve Rowe added a comment -

        Christine, if you want to push to branch_6_0, I think it's okay to include this in the 6.0.1 RC, which I've been unsuccessfully trying to make today.

        Show
        steve_rowe Steve Rowe added a comment - Christine, if you want to push to branch_6_0, I think it's okay to include this in the 6.0.1 RC, which I've been unsuccessfully trying to make today.
        Hide
        cpoerschke Christine Poerschke added a comment -

        Timothy Potter - thanks for the review. Steve Rowe - good idea, I will push to branch_6_0 shortly.

        Show
        cpoerschke Christine Poerschke added a comment - Timothy Potter - thanks for the review. Steve Rowe - good idea, I will push to branch_6_0 shortly.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 8217549a4385dcfc439cd024183c079b96e59f90 in lucene-solr's branch refs/heads/branch_6_0 from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8217549 ]

        SOLR-9134: Fix RestManager.addManagedResource return value.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 8217549a4385dcfc439cd024183c079b96e59f90 in lucene-solr's branch refs/heads/branch_6_0 from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8217549 ] SOLR-9134 : Fix RestManager.addManagedResource return value.
        Hide
        cpoerschke Christine Poerschke added a comment -

        branch_6_0 push done. As far as the solr/CHANGES.txt entries on master and branch_6x go, should I be relocating the entry from the 6.1 to the 6.0.1. section now or would that happen as part of the 6.0.1 RC process?

        Show
        cpoerschke Christine Poerschke added a comment - branch_6_0 push done. As far as the solr/CHANGES.txt entries on master and branch_6x go, should I be relocating the entry from the 6.1 to the 6.0.1. section now or would that happen as part of the 6.0.1 RC process?
        Hide
        steve_rowe Steve Rowe added a comment -

        Thanks Christine.

        I'll take care of moving CHANGES.txt entries for this issue on branch_6x and master (along with all other backported issues), after the 6.0.1 release vote passes.

        Show
        steve_rowe Steve Rowe added a comment - Thanks Christine. I'll take care of moving CHANGES.txt entries for this issue on branch_6x and master (along with all other backported issues), after the 6.0.1 release vote passes.
        Hide
        steve_rowe Steve Rowe added a comment -

        Bulk close issues included in the 6.0.1 release.

        Show
        steve_rowe Steve Rowe added a comment - Bulk close issues included in the 6.0.1 release.
        Hide
        steve_rowe Steve Rowe added a comment - - edited

        Reopening to backport to 5.5.2.

        Show
        steve_rowe Steve Rowe added a comment - - edited Reopening to backport to 5.5.2.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit bdd35e9de6ecfabf32368e7e4b78db02939a7543 in lucene-solr's branch refs/heads/branch_5_5 from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bdd35e9 ]

        SOLR-9134: Fix RestManager.addManagedResource return value.

        Show
        jira-bot ASF subversion and git services added a comment - Commit bdd35e9de6ecfabf32368e7e4b78db02939a7543 in lucene-solr's branch refs/heads/branch_5_5 from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bdd35e9 ] SOLR-9134 : Fix RestManager.addManagedResource return value.
        Hide
        steve_rowe Steve Rowe added a comment -

        Bulk close issues released with 5.5.2.

        Show
        steve_rowe Steve Rowe added a comment - Bulk close issues released with 5.5.2.

          People

          • Assignee:
            cpoerschke Christine Poerschke
            Reporter:
            cpoerschke Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development