Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9121

ant precommit fails on ant check-lib-versions

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.1
    • Component/s: None
    • Labels:
      None
    1. SOLR-9121.patch
      4 kB
      Christine Poerschke
    2. SOLR-9121-passthrough.patch
      4 kB
      Steve Rowe

      Issue Links

        Activity

        Hide
        cpoerschke Christine Poerschke added a comment -

        Attaching rough patch, it seems to work but setting/variable names could perhaps be different?

        Show
        cpoerschke Christine Poerschke added a comment - Attaching rough patch, it seems to work but setting/variable names could perhaps be different?
        Hide
        steve_rowe Steve Rowe added a comment -

        Thanks Christine, I'm trying to figure out if there is a simpler way to pass through the ivysettings.xml property, the root of the problem being the fact that this property isn't visible from LibVersionsCheckTask.

        I agree the names are not great. The point of SOLR-9109 is to allow the user to supply a custom ivysettings.xml, and ideally they shouldn't have to know that the build uses a nesting strategy to set Ivy variables for dependencies' versions.

        At a minimum, if we end up going with your patch, the name of the passed-in nested ivy settings file shouldn't include the word "default", since when the user supplies a custom one, it won't be that.

        Show
        steve_rowe Steve Rowe added a comment - Thanks Christine, I'm trying to figure out if there is a simpler way to pass through the ivysettings.xml property, the root of the problem being the fact that this property isn't visible from LibVersionsCheckTask. I agree the names are not great. The point of SOLR-9109 is to allow the user to supply a custom ivysettings.xml, and ideally they shouldn't have to know that the build uses a nesting strategy to set Ivy variables for dependencies' versions. At a minimum, if we end up going with your patch, the name of the passed-in nested ivy settings file shouldn't include the word "default", since when the user supplies a custom one, it won't be that.
        Hide
        steve_rowe Steve Rowe added a comment - - edited

        This patch passes through the Ant property ivysettings.xml as an Ivy variable, which (for me anyway) allows the check-lib-versions task to succeed.

        Christine, what do you think?

        Show
        steve_rowe Steve Rowe added a comment - - edited This patch passes through the Ant property ivysettings.xml as an Ivy variable, which (for me anyway) allows the check-lib-versions task to succeed. Christine, what do you think?
        Hide
        cpoerschke Christine Poerschke added a comment -

        Hi Steve, for me the check-lib-versions task succeeds also with the passthrough patch.

        Patch looks good to me, it's neat how the getProject().getProperty("ivysettings.xml") means that the default-nested-ivy-settings.xml file (or my-custom-nested-ivy-settings.xml with SOLR-9109) can be used without cluttering up the attributes passed to the LibVersionsCheckTask task itself.

        Show
        cpoerschke Christine Poerschke added a comment - Hi Steve, for me the check-lib-versions task succeeds also with the passthrough patch. Patch looks good to me, it's neat how the getProject().getProperty("ivysettings.xml") means that the default-nested-ivy-settings.xml file (or my-custom-nested-ivy-settings.xml with SOLR-9109 ) can be used without cluttering up the attributes passed to the LibVersionsCheckTask task itself.
        Hide
        steve_rowe Steve Rowe added a comment -

        Thanks Christine, I'll go commit now.

        Show
        steve_rowe Steve Rowe added a comment - Thanks Christine, I'll go commit now.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit be5172631d9da0ec4ba0e501c4f964153d952d3b in lucene-solr's branch refs/heads/master from Steve Rowe
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=be51726 ]

        SOLR-9121: Fix check-lib-versions task to pass through the "ivysettings.xml" property as an Ivy variable so that the nested ivy settings file can be located when parsing the top-level ivy settings file.

        Show
        jira-bot ASF subversion and git services added a comment - Commit be5172631d9da0ec4ba0e501c4f964153d952d3b in lucene-solr's branch refs/heads/master from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=be51726 ] SOLR-9121 : Fix check-lib-versions task to pass through the "ivysettings.xml" property as an Ivy variable so that the nested ivy settings file can be located when parsing the top-level ivy settings file.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 01ed4a5f7d837047306aaa37e0f4f2cdda8fb72a in lucene-solr's branch refs/heads/branch_6x from Steve Rowe
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=01ed4a5 ]

        SOLR-9121: Fix check-lib-versions task to pass through the "ivysettings.xml" property as an Ivy variable so that the nested ivy settings file can be located when parsing the top-level ivy settings file.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 01ed4a5f7d837047306aaa37e0f4f2cdda8fb72a in lucene-solr's branch refs/heads/branch_6x from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=01ed4a5 ] SOLR-9121 : Fix check-lib-versions task to pass through the "ivysettings.xml" property as an Ivy variable so that the nested ivy settings file can be located when parsing the top-level ivy settings file.
        Hide
        steve_rowe Steve Rowe added a comment -

        I'll resolve once Jenkins has succeeded, e.g. http://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/16768/, which has the revision of the commit on this issue: be51726.

        Show
        steve_rowe Steve Rowe added a comment - I'll resolve once Jenkins has succeeded, e.g. http://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/16768/ , which has the revision of the commit on this issue: be51726.
        Hide
        steve_rowe Steve Rowe added a comment -

        Resolving; Jenkins succeeded on master: http://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/16769/.

        Show
        steve_rowe Steve Rowe added a comment - Resolving; Jenkins succeeded on master: http://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/16769/ .

          People

          • Assignee:
            steve_rowe Steve Rowe
            Reporter:
            cpoerschke Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development