Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9119

ValueSourceParser.addParser should be private

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.1, 7.0
    • Component/s: None
    • Labels:
      None

      Description

      these static helper methods should only be used by the static init code in the same class for registering the default list of valuesource parsers. Plugin writters should never use these – the fact that they are public is dangerous and leaves us open to bugs if/when plugin writers (or tests) try to use them and may affect other cores/collections in the same JVM.

        Activity

        Hide
        hossman Hoss Man added a comment -

        patch for master making the apis for modifying the "standard" list of value source parsers private.

        On branch_6x we can leave these public, but mark them deprecated - that would at least help prevent mistakes like tests/plugins shipping with solr (and initially developed against master) from trying to muck with this stuff (which is how i discovered this in the first place)

        Show
        hossman Hoss Man added a comment - patch for master making the apis for modifying the "standard" list of value source parsers private. On branch_6x we can leave these public, but mark them deprecated - that would at least help prevent mistakes like tests/plugins shipping with solr (and initially developed against master) from trying to muck with this stuff (which is how i discovered this in the first place)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit dc67fcde51e4896bd032d1c77f5289ef24150081 in lucene-solr's branch refs/heads/branch_6x from Chris Hostetter
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dc67fcd ]

        SOLR-9119: several static methods in ValueSourceParser have been made private in master, and deprecated here

        (cherry picked from commit e9f65fe0f8d2cf6fecdf5b3ba08adc71c0bc16be) ... with modifications

        Show
        jira-bot ASF subversion and git services added a comment - Commit dc67fcde51e4896bd032d1c77f5289ef24150081 in lucene-solr's branch refs/heads/branch_6x from Chris Hostetter [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dc67fcd ] SOLR-9119 : several static methods in ValueSourceParser have been made private in master, and deprecated here (cherry picked from commit e9f65fe0f8d2cf6fecdf5b3ba08adc71c0bc16be) ... with modifications
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit e9f65fe0f8d2cf6fecdf5b3ba08adc71c0bc16be in lucene-solr's branch refs/heads/master from Chris Hostetter
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e9f65fe ]

        SOLR-9119: several static methods in ValueSourceParser have been made private

        Show
        jira-bot ASF subversion and git services added a comment - Commit e9f65fe0f8d2cf6fecdf5b3ba08adc71c0bc16be in lucene-solr's branch refs/heads/master from Chris Hostetter [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e9f65fe ] SOLR-9119 : several static methods in ValueSourceParser have been made private

          People

          • Assignee:
            hossman Hoss Man
            Reporter:
            hossman Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development