Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9117

Leaking the first SolrCore after reload

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 5.5.2, 5.6, 6.0.1, 6.1, 7.0
    • None

    Description

      When a SolrCore for a particular index is created for the first time, it's added to the SolrCores#createdCores map. However, this map doesn't get updated when this core is reloaded, leading to the first SolrCore being leaked.

      Taking a look at how createdCores is used, it seems like it doesn't serve any purpose (its only read is in SolrCores#getAllCoreNames, which includes entries from SolrCores.cores anyway), so I'm proposing a patch to remove the createdCores map completely. However, if someone else knows that createdCores exist for a reason, I'll be happy to change the fix to updating the createdCores map when reload is called.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            shalin Shalin Shekhar Mangar
            mewmewball Jessica Cheng Mallet
            Votes:
            0 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment