Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9117

Leaking the first SolrCore after reload

    Details

    • Flags:
      Patch

      Description

      When a SolrCore for a particular index is created for the first time, it's added to the SolrCores#createdCores map. However, this map doesn't get updated when this core is reloaded, leading to the first SolrCore being leaked.

      Taking a look at how createdCores is used, it seems like it doesn't serve any purpose (its only read is in SolrCores#getAllCoreNames, which includes entries from SolrCores.cores anyway), so I'm proposing a patch to remove the createdCores map completely. However, if someone else knows that createdCores exist for a reason, I'll be happy to change the fix to updating the createdCores map when reload is called.

      1. SOLR-9117.patch
        2 kB
        Jessica Cheng Mallet

        Activity

        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Thanks Jessica! I don't see why/how createdCores is useful so +1 on removing it.

        I'll commit this in a day if no one objects to it.

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Thanks Jessica! I don't see why/how createdCores is useful so +1 on removing it. I'll commit this in a day if no one objects to it.
        Hide
        erickerickson Erick Erickson added a comment -

        Shalin Shekhar Mangar I assigned this to myself just so I don't lose track of it, not to take it away from you . Please go ahead and commit if you get to it before I do.

        Show
        erickerickson Erick Erickson added a comment - Shalin Shekhar Mangar I assigned this to myself just so I don't lose track of it, not to take it away from you . Please go ahead and commit if you get to it before I do.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d1202a8f8d223a6148e79628e63e7677dd4325a6 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d1202a8 ]

        SOLR-9117: The first SolrCore is leaked after reload

        Show
        jira-bot ASF subversion and git services added a comment - Commit d1202a8f8d223a6148e79628e63e7677dd4325a6 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d1202a8 ] SOLR-9117 : The first SolrCore is leaked after reload
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ba7698e4e70f5851e22fb47e2ca595ba983b134a in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ba7698e ]

        SOLR-9117: The first SolrCore is leaked after reload
        (cherry picked from commit d1202a8)

        Show
        jira-bot ASF subversion and git services added a comment - Commit ba7698e4e70f5851e22fb47e2ca595ba983b134a in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ba7698e ] SOLR-9117 : The first SolrCore is leaked after reload (cherry picked from commit d1202a8)
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Thanks Jessica!

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Thanks Jessica!
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 4bc3477fbf9be688c14bbb07f5982d5f4b615591 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4bc3477 ]

        SOLR-9117: Write contributor's full name in change log

        Show
        jira-bot ASF subversion and git services added a comment - Commit 4bc3477fbf9be688c14bbb07f5982d5f4b615591 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4bc3477 ] SOLR-9117 : Write contributor's full name in change log
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 894650d3525672a18c4eba7bf4d836f132d03b8d in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=894650d ]

        SOLR-9117: Write contributor's full name in change log
        (cherry picked from commit 4bc3477)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 894650d3525672a18c4eba7bf4d836f132d03b8d in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=894650d ] SOLR-9117 : Write contributor's full name in change log (cherry picked from commit 4bc3477)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 3e19c5ad1b1a401c9ccc491d8d2c95bd0878424d in lucene-solr's branch refs/heads/branch_6_0 from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3e19c5a ]

        SOLR-9117: The first SolrCore is leaked after reload
        (cherry picked from commit d1202a8)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 3e19c5ad1b1a401c9ccc491d8d2c95bd0878424d in lucene-solr's branch refs/heads/branch_6_0 from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3e19c5a ] SOLR-9117 : The first SolrCore is leaked after reload (cherry picked from commit d1202a8)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c7510a0fdd93329ec04c853c8557f4a3f2309eaf in lucene-solr's branch refs/heads/branch_6_0 from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c7510a0 ]

        SOLR-9117: Write contributor's full name in change log
        (cherry picked from commit 4bc3477)

        Show
        jira-bot ASF subversion and git services added a comment - Commit c7510a0fdd93329ec04c853c8557f4a3f2309eaf in lucene-solr's branch refs/heads/branch_6_0 from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c7510a0 ] SOLR-9117 : Write contributor's full name in change log (cherry picked from commit 4bc3477)
        Hide
        steve_rowe Steve Rowe added a comment -

        Reopening to backport to 5.6 and 5.5.2.

        Show
        steve_rowe Steve Rowe added a comment - Reopening to backport to 5.6 and 5.5.2.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 8fcaa8568b1e00a12b07e5a5cb396c3da2f65b0e in lucene-solr's branch refs/heads/branch_5_5 from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8fcaa85 ]

        SOLR-9117: The first SolrCore is leaked after reload
        (cherry picked from commit d1202a8)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 8fcaa8568b1e00a12b07e5a5cb396c3da2f65b0e in lucene-solr's branch refs/heads/branch_5_5 from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8fcaa85 ] SOLR-9117 : The first SolrCore is leaked after reload (cherry picked from commit d1202a8)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1df6d4f078de33ac3f49dd33b09d3ae8c90f5137 in lucene-solr's branch refs/heads/branch_5x from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1df6d4f ]

        SOLR-9117: The first SolrCore is leaked after reload
        (cherry picked from commit d1202a8)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1df6d4f078de33ac3f49dd33b09d3ae8c90f5137 in lucene-solr's branch refs/heads/branch_5x from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1df6d4f ] SOLR-9117 : The first SolrCore is leaked after reload (cherry picked from commit d1202a8)
        Hide
        steve_rowe Steve Rowe added a comment -

        Bulk close issues released with 5.5.2.

        Show
        steve_rowe Steve Rowe added a comment - Bulk close issues released with 5.5.2.

          People

          • Assignee:
            shalinmangar Shalin Shekhar Mangar
            Reporter:
            mewmewball Jessica Cheng Mallet
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development