Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9115

Get rid of javax.xml.bind.DatatypeConverter in Solr's SimplePostTool

    Details

    • Type: Task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.0
    • Fix Version/s: 6.0.1, 6.1, 7.0
    • Component/s: scripts and tools
    • Labels:
      None

      Description

      Our builds failed with Java 9 build 118 because by default several Java EE features were disabled by default in Java 9. This affects JAXB and CORBA, which are no longer visible by default.

      Lucene is clean of those features but Solr uses javax.xml.bind.DatatypeConverter in SimplePostTool, which is not visible by default in Java 9. Interestingly it uses this to encode the username/password to BASE64. Since Java 8 there is java.util.Base64, so we don't need the hack anymore.

      1. SOLR-9115.patch
        2 kB
        Uwe Schindler

        Activity

        Hide
        thetaphi Uwe Schindler added a comment -

        Simple patch. I will commit this soon, so Java 9 builds succeed.

        Show
        thetaphi Uwe Schindler added a comment - Simple patch. I will commit this soon, so Java 9 builds succeed.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 6620fd1421e230db51929b879395419b6f8d5102 in lucene-solr's branch refs/heads/master from Uwe Schindler
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6620fd1 ]

        SOLR-9115: Get rid of javax.xml.bind.DatatypeConverter in Solr's SimplePostTool

        Show
        jira-bot ASF subversion and git services added a comment - Commit 6620fd1421e230db51929b879395419b6f8d5102 in lucene-solr's branch refs/heads/master from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6620fd1 ] SOLR-9115 : Get rid of javax.xml.bind.DatatypeConverter in Solr's SimplePostTool
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d01bc2c78f3191bf65bd4f65e241503d404550cf in lucene-solr's branch refs/heads/branch_6x from Uwe Schindler
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d01bc2c ]

        SOLR-9115: Get rid of javax.xml.bind.DatatypeConverter in Solr's SimplePostTool

        Show
        jira-bot ASF subversion and git services added a comment - Commit d01bc2c78f3191bf65bd4f65e241503d404550cf in lucene-solr's branch refs/heads/branch_6x from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d01bc2c ] SOLR-9115 : Get rid of javax.xml.bind.DatatypeConverter in Solr's SimplePostTool
        Hide
        thetaphi Uwe Schindler added a comment -

        Here is the official statement about this by Alan Bateman: http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-May/004309.html

        Personally I am very happy that this stuff was removed from JDK by default. But we have to check stuff like TIKA that may use the activation or JAXB libraries. If needed we will need to add some "-addmods" in the startup scripts for Java 9.

        Show
        thetaphi Uwe Schindler added a comment - Here is the official statement about this by Alan Bateman: http://mail.openjdk.java.net/pipermail/jdk9-dev/2016-May/004309.html Personally I am very happy that this stuff was removed from JDK by default. But we have to check stuff like TIKA that may use the activation or JAXB libraries. If needed we will need to add some "-addmods" in the startup scripts for Java 9.
        Hide
        thetaphi Uwe Schindler added a comment -

        Reopen for backport to 6.0.1

        Show
        thetaphi Uwe Schindler added a comment - Reopen for backport to 6.0.1
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 24381c23d5300143aa8e078ca662184fe179b6ab in lucene-solr's branch refs/heads/branch_6_0 from Uwe Schindler
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=24381c2 ]

        SOLR-9115: Get rid of javax.xml.bind.DatatypeConverter in Solr's SimplePostTool

        1. Conflicts:
        2. solr/CHANGES.txt
        Show
        jira-bot ASF subversion and git services added a comment - Commit 24381c23d5300143aa8e078ca662184fe179b6ab in lucene-solr's branch refs/heads/branch_6_0 from Uwe Schindler [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=24381c2 ] SOLR-9115 : Get rid of javax.xml.bind.DatatypeConverter in Solr's SimplePostTool Conflicts: solr/CHANGES.txt
        Hide
        thetaphi Uwe Schindler added a comment -

        I backported this to 6.0.1, because this prevents use of SimplePostTool in Java 9, which also breaks Jenkins.

        Show
        thetaphi Uwe Schindler added a comment - I backported this to 6.0.1, because this prevents use of SimplePostTool in Java 9, which also breaks Jenkins.
        Hide
        steve_rowe Steve Rowe added a comment -

        Bulk close issues included in the 6.0.1 release.

        Show
        steve_rowe Steve Rowe added a comment - Bulk close issues included in the 6.0.1 release.

          People

          • Assignee:
            thetaphi Uwe Schindler
            Reporter:
            thetaphi Uwe Schindler
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development