[SOLR-9093] fix TopGroupsShardResponseProcessor.java:105 NullPointerException

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 5.5.2, 5.6, 6.0.1, 6.1, 7.0
• Assignee: Christine Poerschke
• Reporter: Christine Poerschke
• Created: 09/May/16 18:57
• Updated: 19/Dec/19 02:16
• Resolved: 17/Jun/16 21:17

Description

e.g. http://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/16693/testReport/junit/org.apache.solr/TestDistributedSearch/test/

org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException: Error from server at http://127.0.0.1:44706//collection1: java.lang.NullPointerException
	at org.apache.solr.search.grouping.distributed.responseprocessor.TopGroupsShardResponseProcessor.process(TopGroupsShardResponseProcessor.java:105)
	at org.apache.solr.handler.component.QueryComponent.handleGroupedResponses(QueryComponent.java:753)
	at org.apache.solr.handler.component.QueryComponent.handleResponses(QueryComponent.java:736)
	at org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:420)
	at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:155)
	at org.apache.solr.core.SolrCore.execute(SolrCore.java:2016)
...

A minimalistic fix would be

-          if (t instanceof SolrServerException) {
+          if (t instanceof SolrServerException && t.getCause() != null) {

but perhaps equally valid would be to tweak the logic, similar to the SearchHandler.java#L440 logic, the difference being cause vs. root-cause for SolrServerException exceptions and throwable vs. throwable.cause for other exceptions.

Issue Links

• links to: GitHub Pull Request #1101