Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9093

fix TopGroupsShardResponseProcessor.java:105 NullPointerException

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5.2, 5.6, 6.0.1, 6.1, master (7.0)
    • Component/s: None
    • Labels:
      None

      Description

      e.g. http://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/16693/testReport/junit/org.apache.solr/TestDistributedSearch/test/

      org.apache.solr.client.solrj.impl.HttpSolrClient$RemoteSolrException: Error from server at http://127.0.0.1:44706//collection1: java.lang.NullPointerException
      	at org.apache.solr.search.grouping.distributed.responseprocessor.TopGroupsShardResponseProcessor.process(TopGroupsShardResponseProcessor.java:105)
      	at org.apache.solr.handler.component.QueryComponent.handleGroupedResponses(QueryComponent.java:753)
      	at org.apache.solr.handler.component.QueryComponent.handleResponses(QueryComponent.java:736)
      	at org.apache.solr.handler.component.SearchHandler.handleRequestBody(SearchHandler.java:420)
      	at org.apache.solr.handler.RequestHandlerBase.handleRequest(RequestHandlerBase.java:155)
      	at org.apache.solr.core.SolrCore.execute(SolrCore.java:2016)
      ...
      

      A minimalistic fix would be

      -          if (t instanceof SolrServerException) {
      +          if (t instanceof SolrServerException && t.getCause() != null) {
      

      but perhaps equally valid would be to tweak the logic, similar to the SearchHandler.java#L440 logic, the difference being cause vs. root-cause for SolrServerException exceptions and throwable vs. throwable.cause for other exceptions.

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c4e8673bf06dfffe78796e30fc34373baa85252b in lucene-solr's branch refs/heads/master from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c4e8673 ]

        SOLR-9093: Fix NullPointerException in TopGroupsShardResponseProcessor.

        Show
        jira-bot ASF subversion and git services added a comment - Commit c4e8673bf06dfffe78796e30fc34373baa85252b in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c4e8673 ] SOLR-9093 : Fix NullPointerException in TopGroupsShardResponseProcessor.
        Hide
        cpoerschke Christine Poerschke added a comment -
        Show
        cpoerschke Christine Poerschke added a comment - master: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/c4e8673b branch_6x: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/574a6a9d branch_5x: http://git-wip-us.apache.org/repos/asf/lucene-solr/commit/b0e3b13a (Not sure why the bot didn't update this JIRA ticket for the branch commits, perhaps a blip.)
        Hide
        steve_rowe Steve Rowe added a comment -

        Reopening to backport to 6.0.1.

        Show
        steve_rowe Steve Rowe added a comment - Reopening to backport to 6.0.1.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit eabbed7787edab2e7d0a4b8f588f053ff5a8f963 in lucene-solr's branch refs/heads/branch_6_0 from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=eabbed7 ]

        SOLR-9093: Fix NullPointerException in TopGroupsShardResponseProcessor.

        Show
        jira-bot ASF subversion and git services added a comment - Commit eabbed7787edab2e7d0a4b8f588f053ff5a8f963 in lucene-solr's branch refs/heads/branch_6_0 from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=eabbed7 ] SOLR-9093 : Fix NullPointerException in TopGroupsShardResponseProcessor.
        Hide
        steve_rowe Steve Rowe added a comment -

        Bulk close issues included in the 6.0.1 release.

        Show
        steve_rowe Steve Rowe added a comment - Bulk close issues included in the 6.0.1 release.
        Hide
        steve_rowe Steve Rowe added a comment - - edited

        Reopening to backport to 5.5.2.

        Show
        steve_rowe Steve Rowe added a comment - - edited Reopening to backport to 5.5.2.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 8f04a8843e0834997c08665875219eb747b60fff in lucene-solr's branch refs/heads/branch_5_5 from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8f04a88 ]

        SOLR-9093: Fix NullPointerException in TopGroupsShardResponseProcessor.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 8f04a8843e0834997c08665875219eb747b60fff in lucene-solr's branch refs/heads/branch_5_5 from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8f04a88 ] SOLR-9093 : Fix NullPointerException in TopGroupsShardResponseProcessor.
        Hide
        steve_rowe Steve Rowe added a comment -

        Bulk close issues released with 5.5.2.

        Show
        steve_rowe Steve Rowe added a comment - Bulk close issues released with 5.5.2.

          People

          • Assignee:
            cpoerschke Christine Poerschke
            Reporter:
            cpoerschke Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development