[SOLR-9081] Make SolrTestCaseJ4.beforeClass() / .afterClass() public so it works with Mockito

• Type: Bug
• Status: Closed
• Priority: Blocker
• Resolution: Fixed
• Affects Version/s: 5.5, 5.5.1, 6.0, 6.0.1
• Fix Version/s: 6.1
• Component/s: Tests
• Assignee: Alan Woodward
• Reporter: Georg Sorst
• Created: 06/May/16 21:56
• Updated: 17/Jun/16 13:11
• Resolved: 03/Jun/16 13:33

Description

SolrTestCaseJ4.beforeClass() / SolrTestCaseJ4.afterClass() are currently defined as private static void. This causes problems with Mockito, which requires all test framework methods (including @BeforeClass / @AfterClass) to be public.

The following test case will show this:

MockitoTest.java

package com.example;

import org.apache.solr.SolrTestCaseJ4;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.runners.MockitoJUnitRunner;

@RunWith(MockitoJUnitRunner.class)
public class MockitoTest extends SolrTestCaseJ4 {

    @Test
    public void testSomething() {
      /* Nothing to do, the test runner will fail right away */
    }
}

It will fail with java.lang.Exception: Method beforeClass() should be public

The very trivial fix is to change both methods to public static void