Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9066

Make CountMetric return long instead of double

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: 6.0
    • Fix Version/s: 6.1
    • Component/s: None
    • Labels:
      None

      Description

      CountMetric currently is forced to return a double when it should return a long. This causes issues with SQL integration. The Metric abstract class getValue() should be a Number and not a double. A few minor changes must be made to the other *Metric classes to support this.

      1. SOLR-9066.patch
        13 kB
        Kevin Risden

        Issue Links

          Activity

          Hide
          risdenk Kevin Risden added a comment -

          This cleans up a few other items related to Metrics as well.

          • getValue returns Number instead of double
          • Removes serializable.
          • Removes unnecessary boxing

          Tests pass locally for me for solr.client.solrj.io.*

          Show
          risdenk Kevin Risden added a comment - This cleans up a few other items related to Metrics as well. getValue returns Number instead of double Removes serializable. Removes unnecessary boxing Tests pass locally for me for solr.client.solrj.io.*
          Hide
          risdenk Kevin Risden added a comment -

          Joel Bernstein Dennis Gove - Thoughts on this change?

          Show
          risdenk Kevin Risden added a comment - Joel Bernstein Dennis Gove - Thoughts on this change?
          Hide
          joel.bernstein Joel Bernstein added a comment -

          Seems OK to me. As long as all the specifics around long and double handling in the metric implementations are left in place this should be fine.

          Show
          joel.bernstein Joel Bernstein added a comment - Seems OK to me. As long as all the specifics around long and double handling in the metric implementations are left in place this should be fine.
          Hide
          dpgove Dennis Gove added a comment -

          I agree. Seems fine to me.

          Show
          dpgove Dennis Gove added a comment - I agree. Seems fine to me.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e15bab37a105e27063bd5155b9af85a9a8139608 in lucene-solr's branch refs/heads/master from Kevin Risden
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e15bab3 ]

          SOLR-9066: Make CountMetric return long instead of double

          Show
          jira-bot ASF subversion and git services added a comment - Commit e15bab37a105e27063bd5155b9af85a9a8139608 in lucene-solr's branch refs/heads/master from Kevin Risden [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e15bab3 ] SOLR-9066 : Make CountMetric return long instead of double
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit eb1da08d543e87cb8de2291551398db701790176 in lucene-solr's branch refs/heads/branch_6x from Kevin Risden
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=eb1da08 ]

          SOLR-9066: Make CountMetric return long instead of double

          Show
          jira-bot ASF subversion and git services added a comment - Commit eb1da08d543e87cb8de2291551398db701790176 in lucene-solr's branch refs/heads/branch_6x from Kevin Risden [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=eb1da08 ] SOLR-9066 : Make CountMetric return long instead of double

            People

            • Assignee:
              risdenk Kevin Risden
              Reporter:
              risdenk Kevin Risden
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development