Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9059

NPE in SolrClientCache following collection reload

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0.1, 6.1
    • Component/s: None
    • Labels:
      None

      Description

      Currently the StreamHandler opens the client cache only once when the StreamHandler is initialized. During a collection reload the client cache is closed by the closeHook, but not re-opened. This causes null pointers as the CloudSolrClient sets the zkStateReader = null when it's closed.

      A simple fix for this is to have the SolrClientCache clear it's internal map of clients after closing. The next time the cache is accessed it will then create new clients.

      1. SOLR-9059.patch
        3 kB
        Joel Bernstein
      2. SOLR-9059.patch
        2 kB
        Joel Bernstein

        Activity

        Hide
        joel.bernstein Joel Bernstein added a comment -

        Patch with test case that reproduces the issue.

        Show
        joel.bernstein Joel Bernstein added a comment - Patch with test case that reproduces the issue.
        Hide
        joel.bernstein Joel Bernstein added a comment -

        Patch with fix to the SolrClientCache.

        Show
        joel.bernstein Joel Bernstein added a comment - Patch with fix to the SolrClientCache.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit fc6c24a9d457da858cc033b4adc6e86ecd660870 in lucene-solr's branch refs/heads/master from jbernste
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fc6c24a ]

        SOLR-9059: NPE in SolrClientCache following collection reload

        Show
        jira-bot ASF subversion and git services added a comment - Commit fc6c24a9d457da858cc033b4adc6e86ecd660870 in lucene-solr's branch refs/heads/master from jbernste [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fc6c24a ] SOLR-9059 : NPE in SolrClientCache following collection reload
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1b746be0f7f7ab10425fae2fc1e1253ec3c1bc72 in lucene-solr's branch refs/heads/master from jbernste
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1b746be ]

        SOLR-9059: Update CHANGES.txt

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1b746be0f7f7ab10425fae2fc1e1253ec3c1bc72 in lucene-solr's branch refs/heads/master from jbernste [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1b746be ] SOLR-9059 : Update CHANGES.txt
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 0cb7d83193cb7e5c6cc3b2fb3b169402b0134aeb in lucene-solr's branch refs/heads/branch_6x from jbernste
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0cb7d83 ]

        SOLR-9059: NPE in SolrClientCache following collection reload

        Conflicts:
        solr/core/src/test/org/apache/solr/handler/TestSQLHandler.java

        Show
        jira-bot ASF subversion and git services added a comment - Commit 0cb7d83193cb7e5c6cc3b2fb3b169402b0134aeb in lucene-solr's branch refs/heads/branch_6x from jbernste [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0cb7d83 ] SOLR-9059 : NPE in SolrClientCache following collection reload Conflicts: solr/core/src/test/org/apache/solr/handler/TestSQLHandler.java
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f588374bcc8f4c3425a185f1791f89ce7a29bcc6 in lucene-solr's branch refs/heads/branch_6x from jbernste
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f588374 ]

        SOLR-9059: Update CHANGES.txt

        Show
        jira-bot ASF subversion and git services added a comment - Commit f588374bcc8f4c3425a185f1791f89ce7a29bcc6 in lucene-solr's branch refs/heads/branch_6x from jbernste [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f588374 ] SOLR-9059 : Update CHANGES.txt
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 9f5bcc5b3cd977d8b3c59bd7122ba3c1f78e3d42 in lucene-solr's branch refs/heads/branch_6_0 from jbernste
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9f5bcc5 ]

        SOLR-9059: NPE in SolrClientCache following collection reload

        Conflicts:
        solr/core/src/test/org/apache/solr/handler/TestSQLHandler.java

        Show
        jira-bot ASF subversion and git services added a comment - Commit 9f5bcc5b3cd977d8b3c59bd7122ba3c1f78e3d42 in lucene-solr's branch refs/heads/branch_6_0 from jbernste [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9f5bcc5 ] SOLR-9059 : NPE in SolrClientCache following collection reload Conflicts: solr/core/src/test/org/apache/solr/handler/TestSQLHandler.java
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c29552a1c7fca516b4c31377dd789f7b5db5a6d3 in lucene-solr's branch refs/heads/branch_6_0 from jbernste
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c29552a ]

        SOLR-9059: Update CHANGES.txt

        Show
        jira-bot ASF subversion and git services added a comment - Commit c29552a1c7fca516b4c31377dd789f7b5db5a6d3 in lucene-solr's branch refs/heads/branch_6_0 from jbernste [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c29552a ] SOLR-9059 : Update CHANGES.txt
        Hide
        steve_rowe Steve Rowe added a comment -

        Reopening to backport to 6.0.1.

        Show
        steve_rowe Steve Rowe added a comment - Reopening to backport to 6.0.1.
        Hide
        steve_rowe Steve Rowe added a comment -

        Bulk close issues included in the 6.0.1 release.

        Show
        steve_rowe Steve Rowe added a comment - Bulk close issues included in the 6.0.1 release.

          People

          • Assignee:
            joel.bernstein Joel Bernstein
            Reporter:
            joel.bernstein Joel Bernstein
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development