Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9047

zkcli should allow alternative locations for log4j configuration

    Details

      Description

      zkcli uses the log4j configuration in the local directory:

      sdir="`dirname \"$0\"`"
      
      PATH=$JAVA_HOME/bin:$PATH $JVM -Dlog4j.configuration=file:$sdir/log4j.properties -classpath "$sdir/../../solr-webapp/webapp/WEB-INF/lib/*:$sdir/../../lib/ext/*" org.apache.solr.cloud.ZkCLI ${1+"$@"}
      

      which is a reasonable default, but often people want to use a "global" log4j configuration. For example, one may define a log4j configuration that writes to an external log directory and want to point to this rather than copying it to each source checkout.

      1. SOLR-9047.patch
        2 kB
        Gregory Chanan
      2. SOLR-9047.patch
        2 kB
        Gregory Chanan

        Activity

        Hide
        hossman Hoss Man added a comment -

        is it time to just kill zkcli and move it's functionality into bin/solr ?

        Show
        hossman Hoss Man added a comment - is it time to just kill zkcli and move it's functionality into bin/solr ?
        Hide
        gchanan Gregory Chanan added a comment -

        is it time to just kill zkcli and move it's functionality into bin/solr ?

        probably . In any case that would be a 7.x change, right? This would be useful in 6.x imo.

        Show
        gchanan Gregory Chanan added a comment - is it time to just kill zkcli and move it's functionality into bin/solr ? probably . In any case that would be a 7.x change, right? This would be useful in 6.x imo.
        Hide
        gchanan Gregory Chanan added a comment -

        Here's a patch that lets you specify the log4j configuration file via the LOG4J_PROPS environment variable.

        I'd appreciate someone looking at the windows code since I can't test.

        Show
        gchanan Gregory Chanan added a comment - Here's a patch that lets you specify the log4j configuration file via the LOG4J_PROPS environment variable. I'd appreciate someone looking at the windows code since I can't test.
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        Looks okay to me, though caps style doesn't match existing in the batch file.

        Show
        markrmiller@gmail.com Mark Miller added a comment - Looks okay to me, though caps style doesn't match existing in the batch file.
        Hide
        gchanan Gregory Chanan added a comment -

        Here's a patch that matches the caps style (I had been copying the style from solr.cmd)

        Show
        gchanan Gregory Chanan added a comment - Here's a patch that matches the caps style (I had been copying the style from solr.cmd)
        Hide
        cpoerschke Christine Poerschke added a comment -

        Looks okay to me too (though can't test on windows either).

        Show
        cpoerschke Christine Poerschke added a comment - Looks okay to me too (though can't test on windows either).
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 0dec8f9415a9d97a93870a416e96366db60a72fa in lucene-solr's branch refs/heads/master from Gregory Chanan
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0dec8f9 ]

        SOLR-9047: zkcli should allow alternative locations for log4j configuration

        Show
        jira-bot ASF subversion and git services added a comment - Commit 0dec8f9415a9d97a93870a416e96366db60a72fa in lucene-solr's branch refs/heads/master from Gregory Chanan [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0dec8f9 ] SOLR-9047 : zkcli should allow alternative locations for log4j configuration
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 67ebfb1cc257808e53f74d9c38a9729ded87a330 in lucene-solr's branch refs/heads/branch_6x from Gregory Chanan
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=67ebfb1 ]

        SOLR-9047: zkcli should allow alternative locations for log4j configuration

        Show
        jira-bot ASF subversion and git services added a comment - Commit 67ebfb1cc257808e53f74d9c38a9729ded87a330 in lucene-solr's branch refs/heads/branch_6x from Gregory Chanan [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=67ebfb1 ] SOLR-9047 : zkcli should allow alternative locations for log4j configuration
        Hide
        gchanan Gregory Chanan added a comment -

        Thanks for taking a look Mark and Christine. Committed to trunk and 6.1.

        Show
        gchanan Gregory Chanan added a comment - Thanks for taking a look Mark and Christine. Committed to trunk and 6.1.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ad152d23d5e70121f5e6ddc4bae5dabb288b96c2 in lucene-solr's branch refs/heads/branch_6x from Gregory Chanan
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ad152d2 ]

        SOLR-9047: fix windows script

        Show
        jira-bot ASF subversion and git services added a comment - Commit ad152d23d5e70121f5e6ddc4bae5dabb288b96c2 in lucene-solr's branch refs/heads/branch_6x from Gregory Chanan [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ad152d2 ] SOLR-9047 : fix windows script
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 6e2d80d3a8f4434499bbeee81afa47a52252c143 in lucene-solr's branch refs/heads/master from Gregory Chanan
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6e2d80d ]

        SOLR-9047: fix windows script

        Show
        jira-bot ASF subversion and git services added a comment - Commit 6e2d80d3a8f4434499bbeee81afa47a52252c143 in lucene-solr's branch refs/heads/master from Gregory Chanan [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6e2d80d ] SOLR-9047 : fix windows script
        Hide
        hossman Hoss Man added a comment -

        Manually correcting fixVersion per Step #S5 of LUCENE-7271

        Show
        hossman Hoss Man added a comment - Manually correcting fixVersion per Step #S5 of LUCENE-7271
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 66c16651baa88a2dcdef392e2f76870334136821 in lucene-solr's branch refs/heads/branch_5_5 from Gregory Chanan
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=66c1665 ]

        SOLR-9047: zkcli should allow alternative locations for log4j configuration

        Show
        jira-bot ASF subversion and git services added a comment - Commit 66c16651baa88a2dcdef392e2f76870334136821 in lucene-solr's branch refs/heads/branch_5_5 from Gregory Chanan [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=66c1665 ] SOLR-9047 : zkcli should allow alternative locations for log4j configuration
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 1eb3093311682a2db108dd5e6d6f4aea52bee973 in lucene-solr's branch refs/heads/branch_5x from Gregory Chanan
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1eb3093 ]

        SOLR-9047: zkcli should allow alternative locations for log4j configuration

        Show
        jira-bot ASF subversion and git services added a comment - Commit 1eb3093311682a2db108dd5e6d6f4aea52bee973 in lucene-solr's branch refs/heads/branch_5x from Gregory Chanan [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1eb3093 ] SOLR-9047 : zkcli should allow alternative locations for log4j configuration
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c64b1194af9328c4da7bc5f5f08cbac93db3e7bf in lucene-solr's branch refs/heads/branch_5x from Steve Rowe
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c64b119 ]

        SOLR-9047: Remove misplaced CHANGES entry

        Show
        jira-bot ASF subversion and git services added a comment - Commit c64b1194af9328c4da7bc5f5f08cbac93db3e7bf in lucene-solr's branch refs/heads/branch_5x from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c64b119 ] SOLR-9047 : Remove misplaced CHANGES entry
        Hide
        steve_rowe Steve Rowe added a comment -

        Reopening to backport to 6.0.2, 5.6 and 5.5.2.

        Show
        steve_rowe Steve Rowe added a comment - Reopening to backport to 6.0.2, 5.6 and 5.5.2.
        Hide
        steve_rowe Steve Rowe added a comment -

        Bulk close issues released with 5.5.2.

        Show
        steve_rowe Steve Rowe added a comment - Bulk close issues released with 5.5.2.

          People

          • Assignee:
            gchanan Gregory Chanan
            Reporter:
            gchanan Gregory Chanan
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development