Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-9028

fix bugs in (add sanity checks for) SSL clientAuth testing

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.0.1, 6.1
    • Component/s: None
    • Labels:
      None

      Description

      While looking into SOLR-8970 i realized there was a whole heap of problems with how clientAuth was being handled in tests. Notably: it wasn't actaully being used when the randomization selects it (aparently due to a copy/paste mistake in SOLR-7166). But there are few other misc issues (improper usage of sysprops overrides for tests, missuage of keystore/truststore in test clients, etc..)

      I'm working up a patch to fix all of this, and add some much needed tests to explicitly verify both SSL and clientAuth that will include some "false positive" verifications, and some "test the test" checks.

      1. os.x.failure.txt
        194 kB
        Steve Rowe
      2. SOLR-9028.patch
        36 kB
        Hoss Man
      3. SOLR-9028.patch
        34 kB
        Hoss Man
      4. SOLR-9028.patch
        33 kB
        Hoss Man
      5. SOLR-9028.patch
        30 kB
        Hoss Man
      6. SOLR-9028.patch
        26 kB
        Hoss Man
      7. SOLR-9028.patch
        22 kB
        Hoss Man
      8. SOLR-9028-branch_6_0-remove-httpclient-builder-method.patch
        5 kB
        Steve Rowe

        Issue Links

          Activity

          Hide
          hossman Hoss Man added a comment -

          Here's my current in progress patch (summary of chagnes below). Feedback on the changes/tests or suggestions for additional tests i haven't thought of yet would be appreciated.

          In particular: I would really love it if someone on OSX could run the new and improved TestMiniSolrCloudClusterSSL and let me know if it passes for you – clientAuth randomization in SolrTestCaseJ4 has been completley disabled on OSX for a long time due to some consistent failures that no one ever got to the bottom of, and I'm wondering if it was a JVM bug that's still a problem with modern JVMs and/or if my changes to SSLTestConfig resolved whatever the underlying problem is (if not, i have another avenue to explore - see nocommit in SolrTestCaseJ4)


          In this patch...

          • SSLConfig
            • jdocs that clientAuth and all other settings are ignored unless useSSL is true
            • fix createContextFactory to pay attention to clientAuth setting & only use trustStore when it's set
            • fix Boolean.getBoolean usage
          • SSLTestConfig
            • some refacotring & jdocs
            • fix bug when building test client SSL Context
              • trust store & keystore have to be swapped from clients perspective
          • SolrTestCaseJ4
            • make clientAuth randomization more likely
          • TestMiniSolrCloudClusterSSL
            • don't rely on random sslConfig, test explicit SSL scenerios w/distinct test clusters
            • add sanity check asserts of things like baseURL when we expect to be using SSL
            • assert no false positives when requiring clientAuth by doing a HEAD request from a client w/o any client certs
          Show
          hossman Hoss Man added a comment - Here's my current in progress patch (summary of chagnes below). Feedback on the changes/tests or suggestions for additional tests i haven't thought of yet would be appreciated. In particular: I would really love it if someone on OSX could run the new and improved TestMiniSolrCloudClusterSSL and let me know if it passes for you – clientAuth randomization in SolrTestCaseJ4 has been completley disabled on OSX for a long time due to some consistent failures that no one ever got to the bottom of, and I'm wondering if it was a JVM bug that's still a problem with modern JVMs and/or if my changes to SSLTestConfig resolved whatever the underlying problem is (if not, i have another avenue to explore - see nocommit in SolrTestCaseJ4) In this patch... SSLConfig jdocs that clientAuth and all other settings are ignored unless useSSL is true fix createContextFactory to pay attention to clientAuth setting & only use trustStore when it's set fix Boolean.getBoolean usage SSLTestConfig some refacotring & jdocs fix bug when building test client SSL Context trust store & keystore have to be swapped from clients perspective SolrTestCaseJ4 make clientAuth randomization more likely TestMiniSolrCloudClusterSSL don't rely on random sslConfig, test explicit SSL scenerios w/distinct test clusters add sanity check asserts of things like baseURL when we expect to be using SSL assert no false positives when requiring clientAuth by doing a HEAD request from a client w/o any client certs
          Hide
          steve_rowe Steve Rowe added a comment -

          Fails for me on OS X 10.11.4, os.x.failure.txt is test output. java -version says:

          java version "1.8.0_77"
          Java(TM) SE Runtime Environment (build 1.8.0_77-b03)
          Java HotSpot(TM) 64-Bit Server VM (build 25.77-b03, mixed mode)
          
          Show
          steve_rowe Steve Rowe added a comment - Fails for me on OS X 10.11.4, os.x.failure.txt is test output. java -version says: java version "1.8.0_77" Java(TM) SE Runtime Environment (build 1.8.0_77-b03) Java HotSpot(TM) 64-Bit Server VM (build 25.77-b03, mixed mode)
          Hide
          hossman Hoss Man added a comment -

          Fails for me on OS X 10.11.4 ...

          Thanks steve,

          The failure you're seeing seems to jive with what was reported in SOLR-3854 when the choice was made to explicitly disable all clientAuth testing on OSX – it would be nice to get to the bottom of that, and i have some theories (see nocommits still in patch) but i'm not going to stress out about it too much just yet.

          Here's an update patch that resolves most of the nocommits in TestMiniSolrCloudClusterSSL.

          I still need to review & sanity check one expected failure case in that class, and I want to write another "test the test" class that does rely on SolrTestCaseJ4's randomization logic to initialize a SSLTestConfig, but then spot checks that the clients/servers created by SolrTestCaseJ4/MiniSolrCloudCluster match the expectations based on whats in SSLTestConfig.

          Show
          hossman Hoss Man added a comment - Fails for me on OS X 10.11.4 ... Thanks steve, The failure you're seeing seems to jive with what was reported in SOLR-3854 when the choice was made to explicitly disable all clientAuth testing on OSX – it would be nice to get to the bottom of that, and i have some theories (see nocommits still in patch) but i'm not going to stress out about it too much just yet. Here's an update patch that resolves most of the nocommits in TestMiniSolrCloudClusterSSL. I still need to review & sanity check one expected failure case in that class, and I want to write another "test the test" class that does rely on SolrTestCaseJ4's randomization logic to initialize a SSLTestConfig, but then spot checks that the clients/servers created by SolrTestCaseJ4/MiniSolrCloudCluster match the expectations based on whats in SSLTestConfig.
          Hide
          hossman Hoss Man added a comment -

          my latest patch...

          • refactored TestMiniSolrCloudClusterSSL so i could easily write a new TestSSLRandomization
            • this new "test the test test" checks all the same stuff as TestMiniSolrCloudClusterSSL against the SolrTestCaseJ4 randomized SSLTestConfig
          • refactored some overly complex code in SSLTestConfig
          • added notes & assumes regarding newly spun off SOLR-9039 (Mac OS X clientAuth testing issue)

          ...putting this issue on the backburner until i can get to the bottom of SOLR-9040.

          Show
          hossman Hoss Man added a comment - my latest patch... refactored TestMiniSolrCloudClusterSSL so i could easily write a new TestSSLRandomization this new "test the test test" checks all the same stuff as TestMiniSolrCloudClusterSSL against the SolrTestCaseJ4 randomized SSLTestConfig refactored some overly complex code in SSLTestConfig added notes & assumes regarding newly spun off SOLR-9039 (Mac OS X clientAuth testing issue) ...putting this issue on the backburner until i can get to the bottom of SOLR-9040 .
          Hide
          hossman Hoss Man added a comment -

          Updated patch that builds off the existing test work to include a new checks specifically for the bug in SOLR-9040.

          With only this patch, testSslAndNoClientAuth & testSslAndClientAuth now both fail – if you layer the patch in SOLR-9040 on top, testSslAndClientAuth still fails. Looking into that now.

          Show
          hossman Hoss Man added a comment - Updated patch that builds off the existing test work to include a new checks specifically for the bug in SOLR-9040 . With only this patch, testSslAndNoClientAuth & testSslAndClientAuth now both fail – if you layer the patch in SOLR-9040 on top, testSslAndClientAuth still fails. Looking into that now.
          Hide
          hossman Hoss Man added a comment -

          Working on SOLR-9040 helped me discover some stuff about when/how exactly the JVM reads in the javax.net.ssl.* sys props to build the default SSLContext – notably: it's a singleton, so we can't change the sysprops after startup and expect it to do what is expected. (And there doesn't appear to be ably convinience classes/methods for loading a "custom" SSLContext that obeys those properties by default unless/until you override them)

          In this updated patch, I've added test code to preserve the SSLContext.getDefault() on test class init, and use SSLContext.setDefaul() during testing to mimic the effects of how the JVM should behave if the corisponding javax.net.ssl.* properties had been set. (then restore the preserved default in an @After method)

          This seems to be working well.

          I briefly considered eliminating all of the explicit modifications of HttpCiientUtil's HttpClientBuilder / SchemaRegistryProvider in these tests, so we were always mimicing how a solrj code will behave by default when these props are set, but ultimately I think the current mix of both styles of getting an SSLContext are better – it helps us test both the "solrj client expects to use standard javax sys properties" approach, and the "solrj client code explicitly using HttpCiientUtil to say 'use these options for ssl'" approach.

          There's still a handful of nocommits, that fall into two categories:

          • I want to cleanup some of the SSLTestConfig methods that only exist in master and have weird side effects (introduced in SOLR-4509)
          • I think it might makes sense to promote the the SSLContext.getDefault/setDefault preservation to SolrTestCaseJ4 ... but i'm not 100% certain yet. Need to think it through more.
          Show
          hossman Hoss Man added a comment - Working on SOLR-9040 helped me discover some stuff about when/how exactly the JVM reads in the javax.net.ssl.* sys props to build the default SSLContext – notably: it's a singleton, so we can't change the sysprops after startup and expect it to do what is expected. (And there doesn't appear to be ably convinience classes/methods for loading a "custom" SSLContext that obeys those properties by default unless/until you override them) In this updated patch, I've added test code to preserve the SSLContext.getDefault() on test class init, and use SSLContext.setDefaul() during testing to mimic the effects of how the JVM should behave if the corisponding javax.net.ssl.* properties had been set. (then restore the preserved default in an @After method) This seems to be working well. I briefly considered eliminating all of the explicit modifications of HttpCiientUtil's HttpClientBuilder / SchemaRegistryProvider in these tests, so we were always mimicing how a solrj code will behave by default when these props are set, but ultimately I think the current mix of both styles of getting an SSLContext are better – it helps us test both the "solrj client expects to use standard javax sys properties" approach, and the "solrj client code explicitly using HttpCiientUtil to say 'use these options for ssl'" approach. There's still a handful of nocommits, that fall into two categories: I want to cleanup some of the SSLTestConfig methods that only exist in master and have weird side effects (introduced in SOLR-4509 ) I think it might makes sense to promote the the SSLContext.getDefault/setDefault preservation to SolrTestCaseJ4 ... but i'm not 100% certain yet. Need to think it through more.
          Hide
          hossman Hoss Man added a comment -

          Updated patch...

          I want to cleanup some of the SSLTestConfig methods that only exist in master and have weird side effects (introduced in SOLR-4509)

          done.

          I think it might makes sense to promote the the SSLContext.getDefault/setDefault preservation to SolrTestCaseJ4 ... but i'm not 100% certain yet. Need to think it through more.

          I decided this is probably not a good idea – no reason to add to the number of things SolrTestCaseJ4 is doing automagically w/o a need for it.


          I think this is basically ready ... I'm going to hammer on tests w/it for a bit.

          Show
          hossman Hoss Man added a comment - Updated patch... I want to cleanup some of the SSLTestConfig methods that only exist in master and have weird side effects (introduced in SOLR-4509 ) done. I think it might makes sense to promote the the SSLContext.getDefault/setDefault preservation to SolrTestCaseJ4 ... but i'm not 100% certain yet. Need to think it through more. I decided this is probably not a good idea – no reason to add to the number of things SolrTestCaseJ4 is doing automagically w/o a need for it. I think this is basically ready ... I'm going to hammer on tests w/it for a bit.
          Hide
          steve_rowe Steve Rowe added a comment - - edited

          Rerunning on OS X, when I apply the latest patch on master and run ant -Dtestcase=TestMiniSolrCloudClusterSSL test, I get BUILD SUCCESSFUL.

          Show
          steve_rowe Steve Rowe added a comment - - edited Rerunning on OS X, when I apply the latest patch on master and run ant -Dtestcase=TestMiniSolrCloudClusterSSL test , I get BUILD SUCCESSFUL .
          Hide
          steve_rowe Steve Rowe added a comment -

          On OS X from solr/, ant test passes for me with the latest patch on master. I also ran the other new test TestSSLRandomization by itself, and it passed.

          Show
          steve_rowe Steve Rowe added a comment - On OS X from solr/ , ant test passes for me with the latest patch on master. I also ran the other new test TestSSLRandomization by itself, and it passed.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 791d1e73933a88ef78a06a529d5dcb2fd9e01807 in lucene-solr's branch refs/heads/master from Chris Hostetter (Unused)
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=791d1e7 ]

          SOLR-9028: Fixed some test related bugs preventing SSL + ClientAuth from ever being tested

          Show
          jira-bot ASF subversion and git services added a comment - Commit 791d1e73933a88ef78a06a529d5dcb2fd9e01807 in lucene-solr's branch refs/heads/master from Chris Hostetter (Unused) [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=791d1e7 ] SOLR-9028 : Fixed some test related bugs preventing SSL + ClientAuth from ever being tested
          Hide
          hossman Hoss Man added a comment -

          Note: one small diff between the last patch and this commit is that in the patch i had cranked up the odds of randomizing the trySslClientAuth boolean in in SolrTestCaseJ4 ... i dialed that back down to the existing odds before committing.

          Working on backport now ... some significant changes in the HttpClient config stuff between 6x and master due to SOLR-4509, so this won't be trivial.

          Show
          hossman Hoss Man added a comment - Note: one small diff between the last patch and this commit is that in the patch i had cranked up the odds of randomizing the trySslClientAuth boolean in in SolrTestCaseJ4 ... i dialed that back down to the existing odds before committing. Working on backport now ... some significant changes in the HttpClient config stuff between 6x and master due to SOLR-4509 , so this won't be trivial.
          Hide
          steve_rowe Steve Rowe added a comment -

          Working on backport now ... some significant changes in the HttpClient config stuff between 6x and master due to SOLR-4509, so this won't be trivial.

          Maybe SOLR-4509 will be backported to 6.x? If so, couldn't backporting this issue wait for that?

          Show
          steve_rowe Steve Rowe added a comment - Working on backport now ... some significant changes in the HttpClient config stuff between 6x and master due to SOLR-4509 , so this won't be trivial. Maybe SOLR-4509 will be backported to 6.x? If so, couldn't backporting this issue wait for that?
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 48f2b2a3bbfacd5d2a6d2b395ab573305e8c6612 in lucene-solr's branch refs/heads/master from Chris Hostetter (Unused)
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=48f2b2a ]

          SOLR-9028: relax the SSLHandshakeException expectation - in some platforms/java# diff IOExceptions are thrown

          Show
          jira-bot ASF subversion and git services added a comment - Commit 48f2b2a3bbfacd5d2a6d2b395ab573305e8c6612 in lucene-solr's branch refs/heads/master from Chris Hostetter (Unused) [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=48f2b2a ] SOLR-9028 : relax the SSLHandshakeException expectation - in some platforms/java# diff IOExceptions are thrown
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7aecf344b15fb7f1a3136198ca590efd9eec7164 in lucene-solr's branch refs/heads/branch_6x from Chris Hostetter (Unused)
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7aecf34 ]

          SOLR-9028: Fixed some test related bugs preventing SSL + ClientAuth from ever being tested
          (cherry picked from commit 791d1e7)

          Conflicts:
          solr/core/src/test/org/apache/solr/cloud/SSLMigrationTest.java
          solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java
          solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
          solr/test-framework/src/java/org/apache/solr/util/SSLTestConfig.java

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7aecf344b15fb7f1a3136198ca590efd9eec7164 in lucene-solr's branch refs/heads/branch_6x from Chris Hostetter (Unused) [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7aecf34 ] SOLR-9028 : Fixed some test related bugs preventing SSL + ClientAuth from ever being tested (cherry picked from commit 791d1e7) Conflicts: solr/core/src/test/org/apache/solr/cloud/SSLMigrationTest.java solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java solr/test-framework/src/java/org/apache/solr/util/SSLTestConfig.java
          Hide
          hossman Hoss Man added a comment -

          Maybe SOLR-4509 will be backported to 6.x? If so, couldn't backporting this issue wait for that?

          That doesn't seem likely - it involves a lot of incompatible changes to the solrj level client APIs (completely eliminated HttpConfigurer for the new Builder stuff).

          I've already got the 6x changes for SOLR-9028 ready (just hammering tests locally) so i'd rather go ahead and commit so we have the tests in place – if SOLR-4509 does get backported it should be fairly easy to just revert the 6x commits for this issue & re-merge the master commits. (I'll make a note to that effect in SOLR-4509 once i commit)

          Show
          hossman Hoss Man added a comment - Maybe SOLR-4509 will be backported to 6.x? If so, couldn't backporting this issue wait for that? That doesn't seem likely - it involves a lot of incompatible changes to the solrj level client APIs (completely eliminated HttpConfigurer for the new Builder stuff). I've already got the 6x changes for SOLR-9028 ready (just hammering tests locally) so i'd rather go ahead and commit so we have the tests in place – if SOLR-4509 does get backported it should be fairly easy to just revert the 6x commits for this issue & re-merge the master commits. (I'll make a note to that effect in SOLR-4509 once i commit)
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 8e8f6c1fa8b40dc6a7385551a79fdcdd240f5427 in lucene-solr's branch refs/heads/branch_6x from Chris Hostetter (Unused)
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8e8f6c1 ]

          SOLR-9028: Fix 2 SSL test related bugs...

          1) SolrTestCaseJ4 should always reset the HttpClientConfigurer in afterClass, regardless of wether ssl was used
          (when SSL is not used, the active configurer explicitly excludes SSL)
          2) HttpClientUtilTest.testSSLSystemProperties made no sense as written. setSSLSystemProperties() didn't have any
          effect on what was being tested, even if it was useful it would only have affected what keystore/truststore were
          used, not wether HTTPS was supported or not.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 8e8f6c1fa8b40dc6a7385551a79fdcdd240f5427 in lucene-solr's branch refs/heads/branch_6x from Chris Hostetter (Unused) [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8e8f6c1 ] SOLR-9028 : Fix 2 SSL test related bugs... 1) SolrTestCaseJ4 should always reset the HttpClientConfigurer in afterClass, regardless of wether ssl was used (when SSL is not used, the active configurer explicitly excludes SSL) 2) HttpClientUtilTest.testSSLSystemProperties made no sense as written. setSSLSystemProperties() didn't have any effect on what was being tested, even if it was useful it would only have affected what keystore/truststore were used, not wether HTTPS was supported or not.
          Hide
          steve_rowe Steve Rowe added a comment -

          Reopening to backport to 6.0.1.

          Show
          steve_rowe Steve Rowe added a comment - Reopening to backport to 6.0.1.
          Hide
          steve_rowe Steve Rowe added a comment -

          Since SOLR-8097 will land in 6.1, I had to modify the 7aecf344b15fb7f1a3136198ca590efd9eec7164 commit under this issue when backporting to branch_6_0 to remove calls to SolrTestCaseJ4.getHttpSolrClient() - see attached patch.

          Show
          steve_rowe Steve Rowe added a comment - Since SOLR-8097 will land in 6.1, I had to modify the 7aecf344b15fb7f1a3136198ca590efd9eec7164 commit under this issue when backporting to branch_6_0 to remove calls to SolrTestCaseJ4.getHttpSolrClient() - see attached patch.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 9645d4213292121d2f011f5440684ea25d7beaa3 in lucene-solr's branch refs/heads/branch_6_0 from Chris Hostetter
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9645d42 ]

          SOLR-9028: Fixed some test related bugs preventing SSL + ClientAuth from ever being tested
          (cherry picked from commit 791d1e7)

          Conflicts:
          solr/core/src/test/org/apache/solr/cloud/SSLMigrationTest.java
          solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java
          solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java
          solr/test-framework/src/java/org/apache/solr/util/SSLTestConfig.java

          Conflicts:
          solr/core/src/test/org/apache/solr/cloud/TestMiniSolrCloudClusterSSL.java

          For branch_6_0: Since SOLR-8097 will land in 6.1, remove calls in TestMiniSolrCloudClusterSSL to SolrTestCaseJ4.getHttpSolrClient().

          Show
          jira-bot ASF subversion and git services added a comment - Commit 9645d4213292121d2f011f5440684ea25d7beaa3 in lucene-solr's branch refs/heads/branch_6_0 from Chris Hostetter [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9645d42 ] SOLR-9028 : Fixed some test related bugs preventing SSL + ClientAuth from ever being tested (cherry picked from commit 791d1e7) Conflicts: solr/core/src/test/org/apache/solr/cloud/SSLMigrationTest.java solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java solr/test-framework/src/java/org/apache/solr/util/SSLTestConfig.java Conflicts: solr/core/src/test/org/apache/solr/cloud/TestMiniSolrCloudClusterSSL.java For branch_6_0: Since SOLR-8097 will land in 6.1, remove calls in TestMiniSolrCloudClusterSSL to SolrTestCaseJ4.getHttpSolrClient().
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit fdd8d17af4e78ebb65159d74c5cb7a7d46bc2f80 in lucene-solr's branch refs/heads/branch_6_0 from Chris Hostetter
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fdd8d17 ]

          SOLR-9028: Fix 2 SSL test related bugs...

          1) SolrTestCaseJ4 should always reset the HttpClientConfigurer in afterClass, regardless of wether ssl was used
          (when SSL is not used, the active configurer explicitly excludes SSL)
          2) HttpClientUtilTest.testSSLSystemProperties made no sense as written. setSSLSystemProperties() didn't have any
          effect on what was being tested, even if it was useful it would only have affected what keystore/truststore were
          used, not wether HTTPS was supported or not.

          Show
          jira-bot ASF subversion and git services added a comment - Commit fdd8d17af4e78ebb65159d74c5cb7a7d46bc2f80 in lucene-solr's branch refs/heads/branch_6_0 from Chris Hostetter [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fdd8d17 ] SOLR-9028 : Fix 2 SSL test related bugs... 1) SolrTestCaseJ4 should always reset the HttpClientConfigurer in afterClass, regardless of wether ssl was used (when SSL is not used, the active configurer explicitly excludes SSL) 2) HttpClientUtilTest.testSSLSystemProperties made no sense as written. setSSLSystemProperties() didn't have any effect on what was being tested, even if it was useful it would only have affected what keystore/truststore were used, not wether HTTPS was supported or not.
          Hide
          steve_rowe Steve Rowe added a comment -

          Bulk close issues included in the 6.0.1 release.

          Show
          steve_rowe Steve Rowe added a comment - Bulk close issues included in the 6.0.1 release.

            People

            • Assignee:
              hossman Hoss Man
              Reporter:
              hossman Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development