Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8659 Improve Solr JDBC Driver to support more SQL Clients
  3. SOLR-9020

Implement StatementImpl/ResultSetImpl get/set fetch* methods and proper errors for traversal methods

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.0
    • Fix Version/s: 6.1
    • Component/s: SolrJ
    • Labels:
      None

      Description

      There are 4 methods related to fetch in StatementImpl and 4 methods related to fetch in ResultSetImpl. ResultSetImpl has some traversal methods that don't make sense with the fetch direction. It would make sense to implement them to support more SQL clients.

      1. SOLR-9020.patch
        11 kB
        Kevin Risden

        Issue Links

          Activity

          Hide
          risdenk Kevin Risden added a comment -

          Patch with tests.

          Show
          risdenk Kevin Risden added a comment - Patch with tests.
          Hide
          risdenk Kevin Risden added a comment -

          As part of this found that there is a SQLFeatureNotSupportedException that can be thrown for some methods. I'm going to create a separate JIRA to audit the SQL classes and replace the UnsupportedOperationExceptions with SQLFeatureNotSupportedException where applicable.

          Show
          risdenk Kevin Risden added a comment - As part of this found that there is a SQLFeatureNotSupportedException that can be thrown for some methods. I'm going to create a separate JIRA to audit the SQL classes and replace the UnsupportedOperationExceptions with SQLFeatureNotSupportedException where applicable.
          Hide
          risdenk Kevin Risden added a comment -

          This should be good to go. Joel Bernstein - Can you take a look?

          Show
          risdenk Kevin Risden added a comment - This should be good to go. Joel Bernstein - Can you take a look?
          Hide
          joel.bernstein Joel Bernstein added a comment -

          Looks good to me.

          Show
          joel.bernstein Joel Bernstein added a comment - Looks good to me.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a9a842f05dcebb6b86a6f47354aa760a83763e6c in lucene-solr's branch refs/heads/master from Kevin Risden
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a9a842f ]

          SOLR-9020: Implement StatementImpl/ResultSetImpl get/set fetch* methods and proper errors for traversal methods

          Show
          jira-bot ASF subversion and git services added a comment - Commit a9a842f05dcebb6b86a6f47354aa760a83763e6c in lucene-solr's branch refs/heads/master from Kevin Risden [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a9a842f ] SOLR-9020 : Implement StatementImpl/ResultSetImpl get/set fetch* methods and proper errors for traversal methods
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d914ec4a67c42466f19e46169754965a7d5af35c in lucene-solr's branch refs/heads/branch_6x from Kevin Risden
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d914ec4 ]

          SOLR-9020: Implement StatementImpl/ResultSetImpl get/set fetch* methods and proper errors for traversal methods

          Show
          jira-bot ASF subversion and git services added a comment - Commit d914ec4a67c42466f19e46169754965a7d5af35c in lucene-solr's branch refs/heads/branch_6x from Kevin Risden [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d914ec4 ] SOLR-9020 : Implement StatementImpl/ResultSetImpl get/set fetch* methods and proper errors for traversal methods

            People

            • Assignee:
              risdenk Kevin Risden
              Reporter:
              risdenk Kevin Risden
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development