Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.4
    • Component/s: None
    • Labels:
      None

      Description

      The existing solrj source layout makes circular dependencies. We can simplify this by bringing solr into the root src tree.

      For background discussion, see:
      http://www.nabble.com/Cleaning-up-a-Few-things-td20668918.html

        Activity

        Hide
        Ryan McKinley added a comment -

        From the discussion, I think we agree the destination source layout should look like:

        /src/common (moved from existing src/java/o.a.s.common)
        /src/solrj (moved from client/java)
        /src/java (no change)
        /src/webapp/src (no change)

        Unless I hear any objections, i'll make this change in the next few days...

        Show
        Ryan McKinley added a comment - From the discussion, I think we agree the destination source layout should look like: /src/common (moved from existing src/java/o.a.s.common) /src/solrj (moved from client/java) /src/java (no change) /src/webapp/src (no change) Unless I hear any objections, i'll make this change in the next few days...
        Hide
        Ryan McKinley added a comment -

        Looking over this now.... Something that does not fit nicely is where do we put the 'test' classes.

        For simplicity, I think we should put them all into the existing /src/test/org... tree

        Show
        Ryan McKinley added a comment - Looking over this now.... Something that does not fit nicely is where do we put the 'test' classes. For simplicity, I think we should put them all into the existing /src/test/org... tree
        Hide
        Ryan McKinley added a comment -

        Here is a patch that moves things around and updates the build.xml file.

        Since SVN patch does not deal well with 'svn mv', the patch is kinda useless, but I post it here for good measure...

        tests pass, and as far as i can tell the maven artifacts look reasonable.

        Show
        Ryan McKinley added a comment - Here is a patch that moves things around and updates the build.xml file. Since SVN patch does not deal well with 'svn mv', the patch is kinda useless, but I post it here for good measure... tests pass, and as far as i can tell the maven artifacts look reasonable.
        Hide
        Shalin Shekhar Mangar added a comment -

        This is in trunk now. Marking as resolved.

        Thanks Ryan!

        Show
        Shalin Shekhar Mangar added a comment - This is in trunk now. Marking as resolved. Thanks Ryan!
        Hide
        Grant Ingersoll added a comment -

        Bulk close for Solr 1.4

        Show
        Grant Ingersoll added a comment - Bulk close for Solr 1.4

          People

          • Assignee:
            Ryan McKinley
            Reporter:
            Ryan McKinley
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development