[SOLR-8975] SolrClient setters should be deprecated in favor of Solr Client Builder methods

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: main (10.0), 9.3
• Component/s: SolrJ
• Assignee: Unassigned
• Reporter: Jason Gerlowski
• Created: 12/Apr/16 19:58
• Updated: 21/Jul/23 20:40
• Resolved: 30/Mar/23 19:34

Description

SOLR-8097 added a builder layer on top of each SolrClient implementation.

Now that builders are in place for SolrClients, the setters used in each SolrClient can be deprecated, and their functionality moved over to the Builders. This change brings a few benefits:

• unifies SolrClient configuration under the new Builders. It'll be nice to have all the knobs, and levers used to tweak SolrClients available in a single place (the Builders).
• reduces SolrClient thread-safety concerns. Currently, clients are mutable. Using some SolrClient setters can result in erratic and "trappy" behavior when the clients are used across multiple threads.

Issue Links

• is related to: SOLR-8097 Implement a builder pattern for constructing a Solrj client
• links to: GitHub Pull Request #1211
• links to: GitHub Pull Request #1222