Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8975

SolrClient setters should be deprecated in favor of SolrClientBuilder methods

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: SolrJ
    • Labels:
      None

      Description

      SOLR-8097 added a builder layer on top of each SolrClient implementation.

      Now that builders are in place for SolrClients, the setters used in each SolrClient can be deprecated, and their functionality moved over to the Builders. This change brings a few benefits:

      • unifies SolrClient configuration under the new Builders. It'll be nice to have all the knobs, and levers used to tweak SolrClients available in a single place (the Builders).
      • reduces SolrClient thread-safety concerns. Currently, clients are mutable. Using some SolrClient setters can result in erratic and "trappy" behavior when the clients are used across multiple threads.

        Attachments

        1. SOLR-8975.patch
          105 kB
          Jason Gerlowski

          Issue Links

          1.
          timeout-related setters should be deprecated in favor of SolrClientBuilder methods Sub-task Resolved Anshum Gupta
          2.
          setQueryParams should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned
          3.
          setBasicAuthHeader should be deprecated in favor of SolrClientBuilder methods Sub-task Closed Unassigned
          4.
          setBaseURL should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned
          5.
          setParser should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned
          6.
          setSoTimeout should be deprecated in favor of SolrClientBuilder methods Sub-task Closed Unassigned
          7.
          setFollowRedirects should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned
          8.
          setRequestWriter should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned
          9.
          setUseMultiPartPost should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned
          10.
          setAliveCheckInterval should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned
          11.
          setPollQueueTime should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned
          12.
          setRetryExpiryTime should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned
          13.
          setCollectionCacheTT should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned
          14.
          setIdField should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned
          15.
          setDefaultCollection should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned
          16.
          setZkConnectTimeout should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned
          17.
          setZkClientTimeout should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned
          18.
          setParallelUpdates should be deprecated in favor of SolrClientBuilder methods Sub-task Closed David Smiley
          19.
          setParallelCacheRefreshes should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned

            Activity

              People

              • Assignee:
                Unassigned
                Reporter:
                gerlowskija Jason Gerlowski
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated: