Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8975

SolrClient setters should be deprecated in favor of SolrClientBuilder methods

Attach filesAttach ScreenshotAdd voteVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Open
    • Minor
    • Resolution: Unresolved
    • None
    • None
    • SolrJ
    • None

    Description

      SOLR-8097 added a builder layer on top of each SolrClient implementation.

      Now that builders are in place for SolrClients, the setters used in each SolrClient can be deprecated, and their functionality moved over to the Builders. This change brings a few benefits:

      • unifies SolrClient configuration under the new Builders. It'll be nice to have all the knobs, and levers used to tweak SolrClients available in a single place (the Builders).
      • reduces SolrClient thread-safety concerns. Currently, clients are mutable. Using some SolrClient setters can result in erratic and "trappy" behavior when the clients are used across multiple threads.

      Attachments

        Issue Links

        1.
        timeout-related setters should be deprecated in favor of SolrClientBuilder methods Sub-task Resolved Anshum Gupta Actions
        2.
        setQueryParams should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned Actions
        3.
        setBasicAuthHeader should be deprecated in favor of SolrClientBuilder methods Sub-task Closed Unassigned Actions
        4.
        setBaseURL should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned Actions
        5.
        setParser should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned Actions
        6.
        setSoTimeout should be deprecated in favor of SolrClientBuilder methods Sub-task Closed Unassigned Actions
        7.
        setFollowRedirects should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned Actions
        8.
        setRequestWriter should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned Actions
        9.
        setUseMultiPartPost should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned Actions
        10.
        setAliveCheckInterval should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned Actions
        11.
        setPollQueueTime should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned Actions
        12.
        setRetryExpiryTime should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned Actions
        13.
        setCollectionCacheTT should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned Actions
        14.
        setIdField should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned Actions
        15.
        setDefaultCollection should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned Actions
        16.
        setZkConnectTimeout should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned Actions
        17.
        setZkClientTimeout should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned Actions
        18.
        setParallelUpdates should be deprecated in favor of SolrClientBuilder methods Sub-task Closed David Smiley Actions
        19.
        setParallelCacheRefreshes should be deprecated in favor of SolrClientBuilder methods Sub-task Open Unassigned Actions

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            Unassigned Unassigned
            gerlowskija Jason Gerlowski

            Dates

              Created:
              Updated:

              Slack

                Issue deployment