[SOLR-8975] SolrClient setters should be deprecated in favor of Solr Client Builder methods

• Type: Improvement
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Component/s: SolrJ
• Assignee: Unassigned
• Reporter: Jason Gerlowski
• Created: 12/Apr/16 19:58
• Updated: 07/Dec/22 18:56

Description

SOLR-8097 added a builder layer on top of each SolrClient implementation.

Now that builders are in place for SolrClients, the setters used in each SolrClient can be deprecated, and their functionality moved over to the Builders. This change brings a few benefits:

• unifies SolrClient configuration under the new Builders. It'll be nice to have all the knobs, and levers used to tweak SolrClients available in a single place (the Builders).
• reduces SolrClient thread-safety concerns. Currently, clients are mutable. Using some SolrClient setters can result in erratic and "trappy" behavior when the clients are used across multiple threads.

Issue Links

• is related to: SOLR-8097 Implement a builder pattern for constructing a Solrj client
• links to: GitHub Pull Request #1211
• links to: GitHub Pull Request #1222

Sub-Tasks

• timeout-related setters should be deprecated in favor of SolrClientBuilder methods: Resolved
• setQueryParams should be deprecated in favor of SolrClientBuilder methods: Resolved
• setBasicAuthHeader should be deprecated in favor of SolrClientBuilder methods: Closed
• setBaseURL should be deprecated in favor of SolrClientBuilder methods: Resolved
• setParser should be deprecated in favor of SolrClientBuilder methods: Resolved
• setSoTimeout should be deprecated in favor of SolrClientBuilder methods: Closed
• setFollowRedirects should be deprecated in favor of SolrClientBuilder methods: Resolved
• setRequestWriter should be deprecated in favor of SolrClientBuilder methods: Resolved
• setUseMultiPartPost should be deprecated in favor of SolrClientBuilder methods: Resolved
• setAliveCheckInterval should be deprecated in favor of SolrClientBuilder methods: Resolved
• setPollQueueTime should be deprecated in favor of SolrClientBuilder methods: Resolved
• setRetryExpiryTime should be deprecated in favor of SolrClientBuilder methods: Resolved
• setCollectionCacheTTL should be deprecated in favor of Solr Client Builder methods: Resolved
• setIdField should be deprecated in favor of SolrClientBuilder methods: Resolved
• setDefaultCollection should be deprecated in favor of SolrClientBuilder methods: Open
• setZkConnectTimeout should be deprecated in favor of SolrClientBuilder methods: Resolved
• setZkClientTimeout should be deprecated in favor of SolrClientBuilder methods: Resolved
• setParallelUpdates should be deprecated in favor of SolrClientBuilder methods: Closed
• setParallelCacheRefreshes should be deprecated in favor of SolrClientBuilder methods: Resolved
• Rename CloudSolrClientBuilder in SolrTestCaseJ4 to RandomizingCloudSolrClientBuilder: Resolved
• Standardize Builder method names: Resolved
• Standardize Builder handling of times: Resolved
• Use Array instead of ObjectList when dealling with parallelCachesRefresh in CloudSolrClient: Resolved
• Remove Deprecated Methods from Solr Clients: Open
• Use Builders directly in tests instead of delegating to SolrTestCaseJ4: Open