Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8959

TestMiniSolrCloudCluster.testSegmentTerminateEarly should be refactored into it's own SolrCloudTestCase subclass

    Details

    • Type: Test
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.4, 7.0
    • Component/s: None
    • Labels:
      None

      Description

      The functionality tested in testSegmentTerminateEarly (and the helper code in "SegmentTerminateEarlyTestState") should really belong in it's own test class, which can subclass SolrCloudTestCase.

      (I suspect the only reason this wasn't done initially in SOLR-5730 is because maybe the patch predates the creation of SolrCloudTestCase?)

        Issue Links

          Activity

          Hide
          cpoerschke Christine Poerschke added a comment -

          (I suspect the only reason this wasn't done initially in SOLR-5730 is because maybe the patch predates the creation of SolrCloudTestCase?)

          That's correct. SOLR-5730 was first half of February and SOLR-8758 i.e. SolrCloudTestCase.java was second half of February this year.

          Show
          cpoerschke Christine Poerschke added a comment - (I suspect the only reason this wasn't done initially in SOLR-5730 is because maybe the patch predates the creation of SolrCloudTestCase?) That's correct. SOLR-5730 was first half of February and SOLR-8758 i.e. SolrCloudTestCase.java was second half of February this year.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 4c22659879c0e84963d7c9cf8568380956d8166a in lucene-solr's branch refs/heads/branch_6x from Chris Hostetter
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4c22659 ]

          SOLR-8959: Refactored TestSegmentSorting out of TestMiniSolrCloudCluster

          (cherry picked from commit 6525bb56f027655e5a01f028fa373305c0d01caa)

          Conflicts:
          solr/CHANGES.txt

          Show
          jira-bot ASF subversion and git services added a comment - Commit 4c22659879c0e84963d7c9cf8568380956d8166a in lucene-solr's branch refs/heads/branch_6x from Chris Hostetter [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4c22659 ] SOLR-8959 : Refactored TestSegmentSorting out of TestMiniSolrCloudCluster (cherry picked from commit 6525bb56f027655e5a01f028fa373305c0d01caa) Conflicts: solr/CHANGES.txt
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 6525bb56f027655e5a01f028fa373305c0d01caa in lucene-solr's branch refs/heads/master from Chris Hostetter
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6525bb5 ]

          SOLR-8959: Refactored TestSegmentSorting out of TestMiniSolrCloudCluster

          Show
          jira-bot ASF subversion and git services added a comment - Commit 6525bb56f027655e5a01f028fa373305c0d01caa in lucene-solr's branch refs/heads/master from Chris Hostetter [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6525bb5 ] SOLR-8959 : Refactored TestSegmentSorting out of TestMiniSolrCloudCluster

            People

            • Assignee:
              hossman Hoss Man
              Reporter:
              hossman Hoss Man
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development