Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8948

OverseerTaskQueue.containsTaskWithRequestId encounters json parse error if a SolrResponse node is in the overseer queue

    Details

    • Flags:
      Patch

      Description

      Currently OverseerTaskQueue.containsTaskWithRequestId doesn't skip through the response nodes in the queue and this causes a parse error since response nodes are written in a different serialization format.

      The code fix is one line. The rest is adding a test that exposes the bug and slight refactoring that makes writing the test possible.

      1. SOLR-8948.patch
        6 kB
        Jessica Cheng Mallet

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 4205b1c8040935b4939300cf1676e0e006afec06 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4205b1c ]

        SOLR-8948: OverseerTaskQueue.containsTaskWithRequestId encounters json parse error if a SolrResponse node is in the overseer queue

        Show
        jira-bot ASF subversion and git services added a comment - Commit 4205b1c8040935b4939300cf1676e0e006afec06 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=4205b1c ] SOLR-8948 : OverseerTaskQueue.containsTaskWithRequestId encounters json parse error if a SolrResponse node is in the overseer queue
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 6c7487351f3df0b35356763d5587b1e987be5bbf in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6c74873 ]

        SOLR-8948: OverseerTaskQueue.containsTaskWithRequestId encounters json parse error if a SolrResponse node is in the overseer queue
        (cherry picked from commit 4205b1c)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 6c7487351f3df0b35356763d5587b1e987be5bbf in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6c74873 ] SOLR-8948 : OverseerTaskQueue.containsTaskWithRequestId encounters json parse error if a SolrResponse node is in the overseer queue (cherry picked from commit 4205b1c)
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Thanks Jessica!

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Thanks Jessica!
        Hide
        hossman Hoss Man added a comment -

        Manually correcting fixVersion per Step #S5 of LUCENE-7271

        Show
        hossman Hoss Man added a comment - Manually correcting fixVersion per Step #S5 of LUCENE-7271

          People

          • Assignee:
            shalinmangar Shalin Shekhar Mangar
            Reporter:
            mewmewball Jessica Cheng Mallet
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development