Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8938

add optional --excluderegex argument to ZkCLI

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.6, 6.1, 7.0
    • Component/s: None
    • Labels:
      None

      Description

      Add optional --excluderegex argument to ZkCLI.java class.

      This change preserves existing behavior (files whose name starts with a . will not be uploaded to ZK) if the new optional argument is not specified. If an --excluderegex argument is specified then files matching the regular expression won’t be uploaded to ZK.

      Additionally, ZkConfigManager.uploadToZK now info logs the names of the files that were skipped from uploading to ZK.

      1. SOLR-8938.patch
        10 kB
        Christine Poerschke
      2. SOLR-8938-part2.patch
        2 kB
        Christine Poerschke

        Activity

        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 93511352ac824a1e022758600e656ea8b2892913 in lucene-solr's branch refs/heads/master from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9351135 ]

        SOLR-8938: Add optional -excluderegex argument to ZkCLI.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 93511352ac824a1e022758600e656ea8b2892913 in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9351135 ] SOLR-8938 : Add optional -excluderegex argument to ZkCLI.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 835dc33102f6bfca9705078e5adb824050bb2645 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=835dc33 ]

        SOLR-8938: Add optional -excluderegex argument to ZkCLI.

        Show
        jira-bot ASF subversion and git services added a comment - Commit 835dc33102f6bfca9705078e5adb824050bb2645 in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=835dc33 ] SOLR-8938 : Add optional -excluderegex argument to ZkCLI.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 521b9b1015959f0d2444873afecc615d18340ace in lucene-solr's branch refs/heads/branch_5x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=521b9b1 ]

        SOLR-8938: Add optional -excluderegex argument to ZkCLI.

        (Resolved conflicts for solr/CHANGES.txt file and added back ZkCLI's OnReconnect import which was removed in branch_6x and master but is still needed in branch_5x.)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 521b9b1015959f0d2444873afecc615d18340ace in lucene-solr's branch refs/heads/branch_5x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=521b9b1 ] SOLR-8938 : Add optional -excluderegex argument to ZkCLI. (Resolved conflicts for solr/CHANGES.txt file and added back ZkCLI's OnReconnect import which was removed in branch_6x and master but is still needed in branch_5x.)
        Hide
        cpoerschke Christine Poerschke added a comment -

        Re-opening, the -excluderegex descriptions in this JIRA and in CHANGES.txt are in fact long-form --excluderegex and this re-opening is to add a -x short-form also.

        (ZkCLITest.java uses the long-form variant of all the arguments, though it seems in short-form style i.e. just one - instead of two -- hyphens. CLI-264 sounds related.)

        Show
        cpoerschke Christine Poerschke added a comment - Re-opening, the -excluderegex descriptions in this JIRA and in CHANGES.txt are in fact long-form --excluderegex and this re-opening is to add a -x short-form also. ( ZkCLITest.java uses the long-form variant of all the arguments, though it seems in short-form style i.e. just one - instead of two -- hyphens. CLI-264 sounds related.)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 3ab579b7ecd1fbdd2a6e21825d30136a8c8b3cb3 in lucene-solr's branch refs/heads/master from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3ab579b ]

        SOLR-8938: add -x as short-form of --excluderegex ZkCLI arg

        Show
        jira-bot ASF subversion and git services added a comment - Commit 3ab579b7ecd1fbdd2a6e21825d30136a8c8b3cb3 in lucene-solr's branch refs/heads/master from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3ab579b ] SOLR-8938 : add -x as short-form of --excluderegex ZkCLI arg
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit d69274b5d6d9d21086b877f90f0db7611dab3b5f in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d69274b ]

        SOLR-8938: add -x as short-form of --excluderegex ZkCLI arg

        Show
        jira-bot ASF subversion and git services added a comment - Commit d69274b5d6d9d21086b877f90f0db7611dab3b5f in lucene-solr's branch refs/heads/branch_6x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d69274b ] SOLR-8938 : add -x as short-form of --excluderegex ZkCLI arg
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 9d86d2ec41e18d6a2e48ffe157160a54794cc45a in lucene-solr's branch refs/heads/branch_5x from Christine Poerschke
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9d86d2e ]

        SOLR-8938: add -x as short-form of --excluderegex ZkCLI arg

        Show
        jira-bot ASF subversion and git services added a comment - Commit 9d86d2ec41e18d6a2e48ffe157160a54794cc45a in lucene-solr's branch refs/heads/branch_5x from Christine Poerschke [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9d86d2e ] SOLR-8938 : add -x as short-form of --excluderegex ZkCLI arg
        Hide
        hossman Hoss Man added a comment -

        Manually correcting fixVersion per Step #S5 of LUCENE-7271

        Show
        hossman Hoss Man added a comment - Manually correcting fixVersion per Step #S5 of LUCENE-7271

          People

          • Assignee:
            cpoerschke Christine Poerschke
            Reporter:
            cpoerschke Christine Poerschke
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development