Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8911

Admin UI: solr-impl and lucene-impl versions are cut off in SNAPSHOT versions

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 5.5
    • Fix Version/s: 6.2, master (7.0)
    • Component/s: Admin UI
    • Labels:
      None

      Description

      I just tried to see Solr's "compiled on" date on my dev Solr server, which is running a 5.5.1-SNAPSHOT version, compiled from the branch_5_5 source.

      The "impl" strings are so long that the only thing I could tell is that it was compiled this year. I will attach a screenshot.

      It wasn't possible to see or highlight the full string. I did manage to see it all when I maximized my browser window (on a 1680x1050 screen), but I really dislike running with windows maximized. It's not like I keep the windows small either – the screenshot will reflect this.

        Issue Links

          Activity

          Hide
          elyograg Shawn Heisey added a comment -

          Screenshot showing the -impl version numbers cut off.

          Show
          elyograg Shawn Heisey added a comment - Screenshot showing the -impl version numbers cut off.
          Hide
          elyograg Shawn Heisey added a comment -

          For solutions, i see two. One is to remove the git hash from the version string so it's small enough to be visible in a browser on one of those ultra-light notebook screens. The other is to use a different HTML element to display informational elements – perhaps a textbox where the text can be selected and scrolled horizontally by the selection (without a scrollbar). I've seen something like that, but have absolutely no idea what it's called in the HTML/CSS world.

          Show
          elyograg Shawn Heisey added a comment - For solutions, i see two. One is to remove the git hash from the version string so it's small enough to be visible in a browser on one of those ultra-light notebook screens. The other is to use a different HTML element to display informational elements – perhaps a textbox where the text can be selected and scrolled horizontally by the selection (without a scrollbar). I've seen something like that, but have absolutely no idea what it's called in the HTML/CSS world.
          Hide
          risdenk Kevin Risden added a comment -

          How about using the git short hash instead of the full hash?

          Show
          risdenk Kevin Risden added a comment - How about using the git short hash instead of the full hash?
          Hide
          elyograg Shawn Heisey added a comment -

          That would help, and probably would be enough for my purposes.

          Even if we do change to the short hash, I want to be sure somebody on a small computer (think about an ultrabook, or a desktop with a tiny screen) has full access to all the info in the admin UI. If we can support android/IOS mobile devices, that's even better. Tablets would be more important than phones, but if we do it right, a phone could work. I know that the old UI is extremely painful on my android phone, but I have not tried the Angular UI yet.

          Now that I've thought about the Angular UI, I did just double-check the impl strings there on my desktop, and it has the same problem.

          Show
          elyograg Shawn Heisey added a comment - That would help, and probably would be enough for my purposes. Even if we do change to the short hash, I want to be sure somebody on a small computer (think about an ultrabook, or a desktop with a tiny screen) has full access to all the info in the admin UI. If we can support android/IOS mobile devices, that's even better. Tablets would be more important than phones, but if we do it right, a phone could work. I know that the old UI is extremely painful on my android phone, but I have not tried the Angular UI yet. Now that I've thought about the Angular UI, I did just double-check the impl strings there on my desktop, and it has the same problem.
          Hide
          elyograg Shawn Heisey added a comment -

          Loading the Angular UI on my Android phone in Chrome shows that it has the same problem with the impl strings that a desktop browser does. Although you can make a desktop browser show the full string by maximizing it on a monitor with enough pixels available, rotating the phone horizontal and zooming in/out make no difference.

          I am pleased to report that the Angular UI actually works on my phone browser. I can open a separate issue to discuss the few nits that I've noticed.

          Show
          elyograg Shawn Heisey added a comment - Loading the Angular UI on my Android phone in Chrome shows that it has the same problem with the impl strings that a desktop browser does. Although you can make a desktop browser show the full string by maximizing it on a monitor with enough pixels available, rotating the phone horizontal and zooming in/out make no difference. I am pleased to report that the Angular UI actually works on my phone browser. I can open a separate issue to discuss the few nits that I've noticed.
          Hide
          githubbot ASF GitHub Bot added a comment -

          GitHub user arafalov opened a pull request:

          https://github.com/apache/lucene-solr/pull/54

          SOLR-8911: Angular Admin UI: Fix cut-off overflow strings on dashboard page

          Fix too long value strings in the dashboard page (primarily versions and args sections) by adding overflow scrolling. The scrollbar appears when hovered or touched on the individual value area.

          Tested on several browsers on Mac, Windows and Android. On Windows, the scrollbar makes the page jump a little bit for the args section, but is quite usable. On Mac and Android, the scrollbar is inside the area and does not cause a jump.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/arafalov/lucene-solr-contributions master

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/lucene-solr/pull/54.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #54


          commit 3c4b5db04935499972c281cc28cce8fb3e529a4a
          Author: Alexandre Rafalovitch <arafalov@gmail.com>
          Date: 2016-07-26T14:33:09Z

          Angular Admin UI: Fix cut-off overflow strings on dashboard page (FIX
          SOLR-8911)


          Show
          githubbot ASF GitHub Bot added a comment - GitHub user arafalov opened a pull request: https://github.com/apache/lucene-solr/pull/54 SOLR-8911 : Angular Admin UI: Fix cut-off overflow strings on dashboard page Fix too long value strings in the dashboard page (primarily versions and args sections) by adding overflow scrolling. The scrollbar appears when hovered or touched on the individual value area. Tested on several browsers on Mac, Windows and Android. On Windows, the scrollbar makes the page jump a little bit for the args section, but is quite usable. On Mac and Android, the scrollbar is inside the area and does not cause a jump. You can merge this pull request into a Git repository by running: $ git pull https://github.com/arafalov/lucene-solr-contributions master Alternatively you can review and apply these changes as the patch at: https://github.com/apache/lucene-solr/pull/54.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #54 commit 3c4b5db04935499972c281cc28cce8fb3e529a4a Author: Alexandre Rafalovitch <arafalov@gmail.com> Date: 2016-07-26T14:33:09Z Angular Admin UI: Fix cut-off overflow strings on dashboard page (FIX SOLR-8911 )
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit c9faa102f99d7e19df5bcd63e16e699f52f2b1db in lucene-solr's branch refs/heads/master from Alexandre Rafalovitch
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c9faa10 ]

          SOLR-8911: Enable scrolling in Admin UI overflows
          In the dashboard screen, scroll horizontally the Versions and JVM
          property values strings.

          Show
          jira-bot ASF subversion and git services added a comment - Commit c9faa102f99d7e19df5bcd63e16e699f52f2b1db in lucene-solr's branch refs/heads/master from Alexandre Rafalovitch [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c9faa10 ] SOLR-8911 : Enable scrolling in Admin UI overflows In the dashboard screen, scroll horizontally the Versions and JVM property values strings.
          Hide
          githubbot ASF GitHub Bot added a comment -

          Github user arafalov closed the pull request at:

          https://github.com/apache/lucene-solr/pull/54

          Show
          githubbot ASF GitHub Bot added a comment - Github user arafalov closed the pull request at: https://github.com/apache/lucene-solr/pull/54
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 7a2b26826142a21a213990c787b2ec42a26a6eec in lucene-solr's branch refs/heads/branch_6x from Alexandre Rafalovitch
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7a2b268 ]

          SOLR-8911: Enable scrolling in Admin UI overflows

          Show
          jira-bot ASF subversion and git services added a comment - Commit 7a2b26826142a21a213990c787b2ec42a26a6eec in lucene-solr's branch refs/heads/branch_6x from Alexandre Rafalovitch [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=7a2b268 ] SOLR-8911 : Enable scrolling in Admin UI overflows
          Hide
          arafalov Alexandre Rafalovitch added a comment -

          Fixed with css changes that allow overflow scrolling.

          Show
          arafalov Alexandre Rafalovitch added a comment - Fixed with css changes that allow overflow scrolling.
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Why can't we add a tooltip instead of overflow scrolling?

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Why can't we add a tooltip instead of overflow scrolling?
          Hide
          arafalov Alexandre Rafalovitch added a comment -

          There is a couple of reasons in my mind:

          • This also affects much longer JVM properties section, not just version section
          • If one wanted to copy the initially obscured portion of the text (e.g. for email or whatever), tooltip does not help
          • The information is already there, tooltip would duplicate it, while overflow scroll just makes it visible and copyable
          • Overflow scroll works on mobile as well
          • The CSS was already there dealing with overflow, it just dealt with it by doing the "..." indicator that some content was invisible

          Are you experiencing any problems with the current implementation?

          Show
          arafalov Alexandre Rafalovitch added a comment - There is a couple of reasons in my mind: This also affects much longer JVM properties section, not just version section If one wanted to copy the initially obscured portion of the text (e.g. for email or whatever), tooltip does not help The information is already there, tooltip would duplicate it, while overflow scroll just makes it visible and copyable Overflow scroll works on mobile as well The CSS was already there dealing with overflow, it just dealt with it by doing the "..." indicator that some content was invisible Are you experiencing any problems with the current implementation?
          Hide
          shalinmangar Shalin Shekhar Mangar added a comment -

          Not at all. It was merely a suggestion but what you wrote makes a lot of sense. Thanks for fixing!

          Show
          shalinmangar Shalin Shekhar Mangar added a comment - Not at all. It was merely a suggestion but what you wrote makes a lot of sense. Thanks for fixing!
          Hide
          mikemccand Michael McCandless added a comment -

          Bulk close resolved issues after 6.2.0 release.

          Show
          mikemccand Michael McCandless added a comment - Bulk close resolved issues after 6.2.0 release.

            People

            • Assignee:
              arafalov Alexandre Rafalovitch
              Reporter:
              elyograg Shawn Heisey
            • Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development