Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8892

Allow SolrInfoMBeans to return different statistics for /jmx vs web ui calls

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.0
    • Fix Version/s: 6.1, 7.0
    • Component/s: Admin UI, JMX
    • Labels:
      None

      Description

      Discussed this with [~markmiller]. SOLR-8869 allows us to not return field cache entries from the SolrFieldCacheMBean. It would be nice to be a little more flexible about this; the reason SOLR-8869 was useful was that the field cache printing was expensive due to periodic monitoring calls to /jmx. But turning off the field cache entry printing via SOLR-8869 also turns it off from the web ui. It can be useful for users and admins to be able to view the cache entries there, non-periodically, without paying a performance penalty due to /jmx calls.

      The proposal here is to allow SolrInfoMBeans to define statistics to be returned specificially for jmx purposes and to implement a specific instance of this for the SolrFieldCacheMBean.

      1. SOLR-8892.patch
        10 kB
        Gregory Chanan
      2. SOLR-8892.patch
        8 kB
        Gregory Chanan

        Activity

        Hide
        gchanan Gregory Chanan added a comment -

        Here's a patch with a couple of tests. Mark Miller can you take a look? Is this along the lines of what you were thinking?

        Show
        gchanan Gregory Chanan added a comment - Here's a patch with a couple of tests. Mark Miller can you take a look? Is this along the lines of what you were thinking?
        Hide
        gchanan Gregory Chanan added a comment -

        perhaps we should have a flag to enable this as well for SolrFieldCacheMBean.

        Show
        gchanan Gregory Chanan added a comment - perhaps we should have a flag to enable this as well for SolrFieldCacheMBean.
        Hide
        gchanan Gregory Chanan added a comment -

        Here's a patch that adds the ability to turn on/off the jmx changes.

        Show
        gchanan Gregory Chanan added a comment - Here's a patch that adds the ability to turn on/off the jmx changes.
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        +1, look good to me.

        Show
        markrmiller@gmail.com Mark Miller added a comment - +1, look good to me.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit fd0d6997477606f9401e602519d903fb2de0e013 in lucene-solr's branch refs/heads/master from Gregory Chanan
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fd0d699 ]

        SOLR-8892: Allow SolrInfoMBeans to return different statistics for /jmx vs web ui calls

        Show
        jira-bot ASF subversion and git services added a comment - Commit fd0d6997477606f9401e602519d903fb2de0e013 in lucene-solr's branch refs/heads/master from Gregory Chanan [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fd0d699 ] SOLR-8892 : Allow SolrInfoMBeans to return different statistics for /jmx vs web ui calls
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit a5afd1cee8dbd1b40d3c0ab7fb40e05978837813 in lucene-solr's branch refs/heads/master from Gregory Chanan
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a5afd1c ]

        SOLR-8892: Fix typo in CHANGES.txt

        Show
        jira-bot ASF subversion and git services added a comment - Commit a5afd1cee8dbd1b40d3c0ab7fb40e05978837813 in lucene-solr's branch refs/heads/master from Gregory Chanan [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a5afd1c ] SOLR-8892 : Fix typo in CHANGES.txt
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 2b0963ee38ad751036066260944ce34bdeb1a55b in lucene-solr's branch refs/heads/branch_6x from Gregory Chanan
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2b0963e ]

        SOLR-8892: Allow SolrInfoMBeans to return different statistics for /jmx vs web ui calls

        Show
        jira-bot ASF subversion and git services added a comment - Commit 2b0963ee38ad751036066260944ce34bdeb1a55b in lucene-solr's branch refs/heads/branch_6x from Gregory Chanan [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2b0963e ] SOLR-8892 : Allow SolrInfoMBeans to return different statistics for /jmx vs web ui calls
        Hide
        gchanan Gregory Chanan added a comment -

        Thanks for the review, Mark. Committed to 6.1 and trunk.

        Show
        gchanan Gregory Chanan added a comment - Thanks for the review, Mark. Committed to 6.1 and trunk.
        Hide
        hossman Hoss Man added a comment -

        Manually correcting fixVersion per Step #S5 of LUCENE-7271

        Show
        hossman Hoss Man added a comment - Manually correcting fixVersion per Step #S5 of LUCENE-7271

          People

          • Assignee:
            gchanan Gregory Chanan
            Reporter:
            gchanan Gregory Chanan
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development