Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-445 Update Handlers abort with bad documents
  3. SOLR-8890

make whitelist of params that DUP will forward (in filterParams(...)) amendable by other processor factories

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 6.1, master (7.0)
    • Component/s: update
    • Labels:
      None

      Description

      DistributedUpdateProcessor is currently very conservative in what params it will copy when creating requests for other nodes, using a hardcoded internal list of only 2 param names. There are good reasons for this behavior in general, but it's really limiting – especially when you're implementing a custom RunAlways UpdateRequestProcessorFactory (or an update processor that you expect to be configured after DUP).

      This situation has come up for me in SOLR-445, so I'd like to add support for a new method that Factories can use to communicate with DUP regarding the params they expect it to forward.

        Activity

        Hide
        hossman Hoss Man added a comment -

        My plan is to (ultimately) commit this feature as part of SOLR-445, but I'm opening this sub-task and attaching a patch with the isolated changes for this "sub-feature" in case folks would like to review it independently.

        (see the commits to be pushed shortly on the jira/SOLR-445 branch for real world usage & tests that leverage this)

        Show
        hossman Hoss Man added a comment - My plan is to (ultimately) commit this feature as part of SOLR-445 , but I'm opening this sub-task and attaching a patch with the isolated changes for this "sub-feature" in case folks would like to review it independently. (see the commits to be pushed shortly on the jira/ SOLR-445 branch for real world usage & tests that leverage this)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 2622eac2915ee210cfffd1969ef5dd8e2030e5cf in lucene-solr's branch refs/heads/jira/SOLR-445 from Chris Hostetter (Unused)
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2622eac ]

        SOLR-445: harden checks in random test; add isoluated cloud test demonstrating bug random test found; add nocommit hack to DUP to work around test failure for now

        (SOLR-8890 to fix a better way)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 2622eac2915ee210cfffd1969ef5dd8e2030e5cf in lucene-solr's branch refs/heads/jira/ SOLR-445 from Chris Hostetter (Unused) [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2622eac ] SOLR-445 : harden checks in random test; add isoluated cloud test demonstrating bug random test found; add nocommit hack to DUP to work around test failure for now ( SOLR-8890 to fix a better way)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit da3ea40e80189c7c2bbd8114a99c72a64262786b in lucene-solr's branch refs/heads/jira/SOLR-445 from Chris Hostetter (Unused)
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=da3ea40 ]

        SOLR-8890: generalized whitelist of param names DUP will use when forwarding requests, usage in SOLR-445

        Show
        jira-bot ASF subversion and git services added a comment - Commit da3ea40e80189c7c2bbd8114a99c72a64262786b in lucene-solr's branch refs/heads/jira/ SOLR-445 from Chris Hostetter (Unused) [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=da3ea40 ] SOLR-8890 : generalized whitelist of param names DUP will use when forwarding requests, usage in SOLR-445
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit f051f56be96b12f1f3e35978ca4c840ae06a801f in lucene-solr's branch refs/heads/master from Chris Hostetter (Unused)
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f051f56 ]

        SOLR-445: new ToleranteUpdateProcessorFactory to support skipping update commands that cause failures when sending multiple updates in a single request.

        SOLR-8890: New static method in DistributedUpdateProcessorFactory to allow UpdateProcessorFactories to indicate request params that should be forwarded when DUP distributes updates.

        This commit is a squashed merge from the jira/SOLR-445 branch (as of b08c284b26b1779d03693a45e219db89839461d0)

        Show
        jira-bot ASF subversion and git services added a comment - Commit f051f56be96b12f1f3e35978ca4c840ae06a801f in lucene-solr's branch refs/heads/master from Chris Hostetter (Unused) [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=f051f56 ] SOLR-445 : new ToleranteUpdateProcessorFactory to support skipping update commands that cause failures when sending multiple updates in a single request. SOLR-8890 : New static method in DistributedUpdateProcessorFactory to allow UpdateProcessorFactories to indicate request params that should be forwarded when DUP distributes updates. This commit is a squashed merge from the jira/ SOLR-445 branch (as of b08c284b26b1779d03693a45e219db89839461d0)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 5b6eacb80bca5815059cd50a1646fa4ecb146e43 in lucene-solr's branch refs/heads/branch_6x from Chris Hostetter (Unused)
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5b6eacb ]

        SOLR-445: new ToleranteUpdateProcessorFactory to support skipping update commands that cause failures when sending multiple updates in a single request.

        SOLR-8890: New static method in DistributedUpdateProcessorFactory to allow UpdateProcessorFactories to indicate request params that should be forwarded when DUP distributes updates.

        This commit is a squashed merge from the jira/SOLR-445 branch (as of b08c284b26b1779d03693a45e219db89839461d0)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 5b6eacb80bca5815059cd50a1646fa4ecb146e43 in lucene-solr's branch refs/heads/branch_6x from Chris Hostetter (Unused) [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=5b6eacb ] SOLR-445 : new ToleranteUpdateProcessorFactory to support skipping update commands that cause failures when sending multiple updates in a single request. SOLR-8890 : New static method in DistributedUpdateProcessorFactory to allow UpdateProcessorFactories to indicate request params that should be forwarded when DUP distributes updates. This commit is a squashed merge from the jira/ SOLR-445 branch (as of b08c284b26b1779d03693a45e219db89839461d0)
        Hide
        hossman Hoss Man added a comment -

        Manually correcting fixVersion per Step #S5 of LUCENE-7271

        Show
        hossman Hoss Man added a comment - Manually correcting fixVersion per Step #S5 of LUCENE-7271

          People

          • Assignee:
            hossman Hoss Man
            Reporter:
            hossman Hoss Man
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development