Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8886

TrieField.toObject(IndexableField) can't handle docValues

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.5.1, 6.0
    • Component/s: None
    • Labels:
      None

      Description

      multiValued docValues numeric fields currently use SortedSet for some reason, but toObject throws an exception in that case.

      1. SOLR-8886.patch
        6 kB
        Yonik Seeley
      2. SOLR-8886.patch
        3 kB
        Yonik Seeley

        Issue Links

          Activity

          Hide
          dsmiley David Smiley added a comment -

          multiValued docValues numeric fields currently use SortedSet for some reason

          I recall it's because the numeric docValues came after SortedSet – SortedSet came first. So there would be a back-compat issue in simply switching to numeric docValues, and so that hasn't happened yet. See SOLR-7878.

          Show
          dsmiley David Smiley added a comment - multiValued docValues numeric fields currently use SortedSet for some reason I recall it's because the numeric docValues came after SortedSet – SortedSet came first. So there would be a back-compat issue in simply switching to numeric docValues, and so that hasn't happened yet. See SOLR-7878 .
          Hide
          yseeley@gmail.com Yonik Seeley added a comment -

          Actually, it turned out that the IndexableField for single-valued docValues numeric was also incorrect (the long bits were not turned back into the correct type).

          Patch attached.

          Show
          yseeley@gmail.com Yonik Seeley added a comment - Actually, it turned out that the IndexableField for single-valued docValues numeric was also incorrect (the long bits were not turned back into the correct type). Patch attached.
          Hide
          dsmiley David Smiley added a comment -

          There's no test in the patch. Is there an existing test that would trip?

          Show
          dsmiley David Smiley added a comment - There's no test in the patch. Is there an existing test that would trip?
          Hide
          yseeley@gmail.com Yonik Seeley added a comment -

          Ad-hoc testing for now. It fixes stuff in the linked issue.

          Show
          yseeley@gmail.com Yonik Seeley added a comment - Ad-hoc testing for now. It fixes stuff in the linked issue.
          Hide
          yseeley@gmail.com Yonik Seeley added a comment -

          new patch w/ tests

          Show
          yseeley@gmail.com Yonik Seeley added a comment - new patch w/ tests
          Hide
          dsmiley David Smiley added a comment -

          +1.
          The only thing I would do differently is use random numbers to round-trip rather then fix them all at -1.

          Show
          dsmiley David Smiley added a comment - +1. The only thing I would do differently is use random numbers to round-trip rather then fix them all at -1.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit ced7570e2c630442cb7b6ba117d38ac4433775af in lucene-solr's branch refs/heads/master from Yonik Seeley
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ced7570 ]

          SOLR-8886: fix TrieField.toObject(IndexableField) for docValues

          Show
          jira-bot ASF subversion and git services added a comment - Commit ced7570e2c630442cb7b6ba117d38ac4433775af in lucene-solr's branch refs/heads/master from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ced7570 ] SOLR-8886 : fix TrieField.toObject(IndexableField) for docValues
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 82a537795ff9e85cd6834d6f46c41851b435bf7c in lucene-solr's branch refs/heads/branch_6x from Yonik Seeley
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=82a5377 ]

          SOLR-8886: fix TrieField.toObject(IndexableField) for docValues

          Show
          jira-bot ASF subversion and git services added a comment - Commit 82a537795ff9e85cd6834d6f46c41851b435bf7c in lucene-solr's branch refs/heads/branch_6x from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=82a5377 ] SOLR-8886 : fix TrieField.toObject(IndexableField) for docValues
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit a144f16f72bf12d97b060da26f3cfe60abaad80d in lucene-solr's branch refs/heads/branch_6_0 from Yonik Seeley
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a144f16 ]

          SOLR-8886: fix TrieField.toObject(IndexableField) for docValues

          Show
          jira-bot ASF subversion and git services added a comment - Commit a144f16f72bf12d97b060da26f3cfe60abaad80d in lucene-solr's branch refs/heads/branch_6_0 from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=a144f16 ] SOLR-8886 : fix TrieField.toObject(IndexableField) for docValues
          Hide
          anshumg Anshum Gupta added a comment -

          Reopening to port for 5.5.1

          Show
          anshumg Anshum Gupta added a comment - Reopening to port for 5.5.1
          Hide
          anshumg Anshum Gupta added a comment -

          Yonik Seeley can you help with back porting this and SOLR-8865 for 5x ? Let me know if you think we shouldn't be doing this in the first place.

          Show
          anshumg Anshum Gupta added a comment - Yonik Seeley can you help with back porting this and SOLR-8865 for 5x ? Let me know if you think we shouldn't be doing this in the first place.
          Hide
          yseeley@gmail.com Yonik Seeley added a comment -

          OK, I'm in the process of backporting this. Just running the full tests now.

          Show
          yseeley@gmail.com Yonik Seeley added a comment - OK, I'm in the process of backporting this. Just running the full tests now.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit ebbe72567f1c3abe5be751606d59cc49cd4f451b in lucene-solr's branch refs/heads/branch_5x from Yonik Seeley
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ebbe725 ]

          SOLR-8886: fix TrieField.toObject(IndexableField) for docValues

          Show
          jira-bot ASF subversion and git services added a comment - Commit ebbe72567f1c3abe5be751606d59cc49cd4f451b in lucene-solr's branch refs/heads/branch_5x from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ebbe725 ] SOLR-8886 : fix TrieField.toObject(IndexableField) for docValues
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit fedbbfe29fea6f7382de63162fc973c9c2964bea in lucene-solr's branch refs/heads/branch_5_5 from Yonik Seeley
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fedbbfe ]

          SOLR-8886: fix TrieField.toObject(IndexableField) for docValues

          Show
          jira-bot ASF subversion and git services added a comment - Commit fedbbfe29fea6f7382de63162fc973c9c2964bea in lucene-solr's branch refs/heads/branch_5_5 from Yonik Seeley [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=fedbbfe ] SOLR-8886 : fix TrieField.toObject(IndexableField) for docValues
          Hide
          anshumg Anshum Gupta added a comment -

          Thanks Yonik. Are you also looking at SOLR-8885 ?

          Show
          anshumg Anshum Gupta added a comment - Thanks Yonik. Are you also looking at SOLR-8885 ?
          Hide
          yseeley@gmail.com Yonik Seeley added a comment -

          "Update JS lib versions"? I don't know anything about that one.

          Show
          yseeley@gmail.com Yonik Seeley added a comment - "Update JS lib versions"? I don't know anything about that one.
          Hide
          anshumg Anshum Gupta added a comment -

          I meant, SOLR-8865. The one that was blocked by this particular issue.

          Show
          anshumg Anshum Gupta added a comment - I meant, SOLR-8865 . The one that was blocked by this particular issue.
          Hide
          yseeley@gmail.com Yonik Seeley added a comment -

          Ah OK... yeah, I'll look into that and SOLR-8891

          Show
          yseeley@gmail.com Yonik Seeley added a comment - Ah OK... yeah, I'll look into that and SOLR-8891

            People

            • Assignee:
              yseeley@gmail.com Yonik Seeley
              Reporter:
              yseeley@gmail.com Yonik Seeley
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development