Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8870

AngularJS Query tab breaks through proxy

    Details

      Description

      The AngularJS Query tab generates a request URL on this form: http://localhost:8983/solr/techproducts%2Fselect?_=1458291250691&indent=on&q=ram&wt=json Notice the urlencoded %2Fselect part.

      This works well locally with Jetty, but a customer has httpd as a proxy in front, and we get a 404 error since the web server does not parse %2F as a path separator and thus does not match the proxy rules for select.

      1. SOLR-8870.patch
        3 kB
        Jan Høydahl

        Activity

        Hide
        janhoy Jan Høydahl added a comment -

        Also, the AngularJS code for query panel does not handle qt not prefixed with slash at all (legacy handleSelect=true and qt=foo). It will simply generate a url with core name and qt concatenated together, causing a 404. I'll attempt to fix that as well.

        Show
        janhoy Jan Høydahl added a comment - Also, the AngularJS code for query panel does not handle qt not prefixed with slash at all (legacy handleSelect=true and qt=foo). It will simply generate a url with core name and qt concatenated together, causing a 404. I'll attempt to fix that as well.
        Hide
        janhoy Jan Høydahl added a comment -

        Attaching patch which avoids encoding handler part. It also checks whether the handler starts with "/", and if not, adds handler name as &qt param with /select as hardcoded handler. Tested locally on master.

        Show
        janhoy Jan Høydahl added a comment - Attaching patch which avoids encoding handler part. It also checks whether the handler starts with "/", and if not, adds handler name as &qt param with /select as hardcoded handler. Tested locally on master.
        Hide
        upayavira Upayavira added a comment -

        Looks good to me (not tried it though)

        Show
        upayavira Upayavira added a comment - Looks good to me (not tried it though)
        Hide
        janhoy Jan Høydahl added a comment -

        Committed to branch_5_5, branch_5x, branch_6x and master

        Show
        janhoy Jan Høydahl added a comment - Committed to branch_5_5, branch_5x, branch_6x and master
        Hide
        steve_rowe Steve Rowe added a comment -

        Reopening to backport to 6.0.1.

        Show
        steve_rowe Steve Rowe added a comment - Reopening to backport to 6.0.1.
        Hide
        steve_rowe Steve Rowe added a comment -

        Bulk close issues included in the 6.0.1 release.

        Show
        steve_rowe Steve Rowe added a comment - Bulk close issues included in the 6.0.1 release.

          People

          • Assignee:
            janhoy Jan Høydahl
            Reporter:
            janhoy Jan Høydahl
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development