Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8869

Optionally disable printing field cache entries in SolrFieldCacheMBean

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.0, 6.1
    • Fix Version/s: 6.1, master (7.0)
    • Component/s: None
    • Labels:
      None

      Description

      Even with SOLR-6747, we are seeing some pretty load / memory allocation due to the JmxMonitoredMap. A majority of this seems to be printing the field cache entries. We should allow admins to disable printing the field cache entries.

      1. SOLR-8869.patch
        4 kB
        Gregory Chanan

        Activity

        Hide
        gchanan Gregory Chanan added a comment -

        Here's a patch and a test. Printing of field cache entries can be disabled via setting the system property "disableSolrFieldCacheMBeanEntryList" to "true"

        Show
        gchanan Gregory Chanan added a comment - Here's a patch and a test. Printing of field cache entries can be disabled via setting the system property "disableSolrFieldCacheMBeanEntryList" to "true"
        Hide
        markrmiller@gmail.com Mark Miller added a comment -

        +1 LGTM.

        Show
        markrmiller@gmail.com Mark Miller added a comment - +1 LGTM.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit cb1738360e0c4880976c5939f73ac49ee34fbda1 in lucene-solr's branch refs/heads/master from Gregory Chanan
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cb17383 ]

        SOLR-8869: Optionally disable printing field cache entries in SolrFieldCacheMBean

        Show
        jira-bot ASF subversion and git services added a comment - Commit cb1738360e0c4880976c5939f73ac49ee34fbda1 in lucene-solr's branch refs/heads/master from Gregory Chanan [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cb17383 ] SOLR-8869 : Optionally disable printing field cache entries in SolrFieldCacheMBean
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit dfab0a60f8c91fc8a3eb6b699ebf9530e2a8d188 in lucene-solr's branch refs/heads/branch_6x from Gregory Chanan
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dfab0a6 ]

        SOLR-8869: Optionally disable printing field cache entries in SolrFieldCacheMBean

        Show
        jira-bot ASF subversion and git services added a comment - Commit dfab0a60f8c91fc8a3eb6b699ebf9530e2a8d188 in lucene-solr's branch refs/heads/branch_6x from Gregory Chanan [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=dfab0a6 ] SOLR-8869 : Optionally disable printing field cache entries in SolrFieldCacheMBean
        Hide
        gchanan Gregory Chanan added a comment -

        Thanks for the review, Mark, committed to 6.1 and trunk.

        Show
        gchanan Gregory Chanan added a comment - Thanks for the review, Mark, committed to 6.1 and trunk.
        Hide
        hossman Hoss Man added a comment -

        Manually correcting fixVersion per Step #S5 of LUCENE-7271

        Show
        hossman Hoss Man added a comment - Manually correcting fixVersion per Step #S5 of LUCENE-7271

          People

          • Assignee:
            gchanan Gregory Chanan
            Reporter:
            gchanan Gregory Chanan
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development