[SOLR-8866] UpdateLog should throw an exception when serializing unknown types

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 6.1
• Assignee: David Smiley
• Reporter: David Smiley
• Created: 17/Mar/16 04:18
• Updated: 29/Sep/16 17:05
• Resolved: 29/Sep/16 17:05

Description

When JavaBinCodec encounters a class it doesn't have explicit knowledge of how to serialize, nor does it implement the ObjectResolver interface, it currently serializes the object as the classname, colon, then toString() of the object.

This may appear innocent but not throwing an exception hides bugs. One example is that the UpdateLog, which uses JavaBinCodec, to save a document. The result is that this bad value winds up there, gets deserialized as a String in PeerSync (which uses /get) and then this value pretends to be a suitable value to the final document in the leader. But of course it isn't.

Issue Links

• relates to: SOLR-9230 Change of default to BinaryRequestWriter breaks some use cases