Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8838

Returning non-stored docValues is incorrect for floats and doubles

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 5.5
    • Fix Version/s: 5.5.1, 5.6, 6.0, 7.0
    • Component/s: None
    • Labels:
      None

      Description

      In SOLR-8220, we introduced returning non-stored docValues as if they were regular stored fields. The handling of doubles and floats, as introduced there, was incorrect for negative values.

      1. SOLR-8838.patch
        13 kB
        Steve Rowe
      2. SOLR-8838.patch
        4 kB
        Ishan Chattopadhyaya
      3. SOLR-8838.patch
        3 kB
        Ishan Chattopadhyaya

        Issue Links

          Activity

          Hide
          ichattopadhyaya Ishan Chattopadhyaya added a comment -

          Here's a patch for this. Modified the test to randomly try indexing/retrieving negative or positive floats/doubles.

          Show
          ichattopadhyaya Ishan Chattopadhyaya added a comment - Here's a patch for this. Modified the test to randomly try indexing/retrieving negative or positive floats/doubles.
          Hide
          ichattopadhyaya Ishan Chattopadhyaya added a comment - - edited

          Shalin Shekhar Mangar, Nicholas Knize, Marking this as a blocker for 6.0, but please feel free to change this as necessary.

          Show
          ichattopadhyaya Ishan Chattopadhyaya added a comment - - edited Shalin Shekhar Mangar , Nicholas Knize , Marking this as a blocker for 6.0, but please feel free to change this as necessary.
          Hide
          ichattopadhyaya Ishan Chattopadhyaya added a comment - - edited

          There is this same problem for multiValued fields as well, I'm working on the fix for that.
          Actually, multivalued fields are working fine.

          Show
          ichattopadhyaya Ishan Chattopadhyaya added a comment - - edited There is this same problem for multiValued fields as well, I'm working on the fix for that. Actually, multivalued fields are working fine.
          Hide
          steve_rowe Steve Rowe added a comment -

          Patch with more randomization of values in TestUseDocValuesAsStored. I beasted this for a while with lots more iterations and it held up, so I think we're good to go.

          I'll commit once it passes precommit.

          Show
          steve_rowe Steve Rowe added a comment - Patch with more randomization of values in TestUseDocValuesAsStored . I beasted this for a while with lots more iterations and it held up, so I think we're good to go. I'll commit once it passes precommit.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 6e55135be3a8194db42a91de65d7746f0fc50332 in lucene-solr's branch refs/heads/master from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6e55135 ]

          SOLR-8838: Returning non-stored docValues is incorrect for negative floats and doubles.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 6e55135be3a8194db42a91de65d7746f0fc50332 in lucene-solr's branch refs/heads/master from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6e55135 ] SOLR-8838 : Returning non-stored docValues is incorrect for negative floats and doubles.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 3cdde08ff2b77c52aa2eeb12c936da8c118e6dc2 in lucene-solr's branch refs/heads/master from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3cdde08 ]

          SOLR-8838: Remove obsolete comment

          Show
          jira-bot ASF subversion and git services added a comment - Commit 3cdde08ff2b77c52aa2eeb12c936da8c118e6dc2 in lucene-solr's branch refs/heads/master from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3cdde08 ] SOLR-8838 : Remove obsolete comment
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit efad5807b6b3e109201ba11c218750ee1e444185 in lucene-solr's branch refs/heads/branch_6x from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=efad580 ]

          SOLR-8838: Returning non-stored docValues is incorrect for negative floats and doubles.

          Show
          jira-bot ASF subversion and git services added a comment - Commit efad5807b6b3e109201ba11c218750ee1e444185 in lucene-solr's branch refs/heads/branch_6x from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=efad580 ] SOLR-8838 : Returning non-stored docValues is incorrect for negative floats and doubles.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit e30551db2a1a195c4b6c320f05beb10879aa3318 in lucene-solr's branch refs/heads/branch_6x from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e30551d ]

          SOLR-8838: Remove obsolete comment

          Show
          jira-bot ASF subversion and git services added a comment - Commit e30551db2a1a195c4b6c320f05beb10879aa3318 in lucene-solr's branch refs/heads/branch_6x from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e30551d ] SOLR-8838 : Remove obsolete comment
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d5e437315a3d936b8cae8375e8ea0eb0c7d69722 in lucene-solr's branch refs/heads/branch_6_0 from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d5e4373 ]

          SOLR-8838: Returning non-stored docValues is incorrect for negative floats and doubles.

          Show
          jira-bot ASF subversion and git services added a comment - Commit d5e437315a3d936b8cae8375e8ea0eb0c7d69722 in lucene-solr's branch refs/heads/branch_6_0 from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d5e4373 ] SOLR-8838 : Returning non-stored docValues is incorrect for negative floats and doubles.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 92ac775ebcbb97672b818c52429025f2a3afe4bd in lucene-solr's branch refs/heads/branch_6_0 from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=92ac775 ]

          SOLR-8838: Remove obsolete comment

          Show
          jira-bot ASF subversion and git services added a comment - Commit 92ac775ebcbb97672b818c52429025f2a3afe4bd in lucene-solr's branch refs/heads/branch_6_0 from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=92ac775 ] SOLR-8838 : Remove obsolete comment
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 11fd447860f5400c2fcf880bde9477e164606971 in lucene-solr's branch refs/heads/branch_5_5 from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=11fd447 ]

          SOLR-8838: Returning non-stored docValues is incorrect for negative floats and doubles.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 11fd447860f5400c2fcf880bde9477e164606971 in lucene-solr's branch refs/heads/branch_5_5 from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=11fd447 ] SOLR-8838 : Returning non-stored docValues is incorrect for negative floats and doubles.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 44f9569d32a6b84126a91e39ddc598c374adeaab in lucene-solr's branch refs/heads/branch_5_5 from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=44f9569 ]

          SOLR-8838: Returning non-stored docValues is incorrect for negative floats and doubles.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 44f9569d32a6b84126a91e39ddc598c374adeaab in lucene-solr's branch refs/heads/branch_5_5 from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=44f9569 ] SOLR-8838 : Returning non-stored docValues is incorrect for negative floats and doubles.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 34b813c34f6a3d32b77c8f16bbbde2ee1a06924b in lucene-solr's branch refs/heads/branch_5_5 from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=34b813c ]

          SOLR-8838: Remove obsolete comment

          Show
          jira-bot ASF subversion and git services added a comment - Commit 34b813c34f6a3d32b77c8f16bbbde2ee1a06924b in lucene-solr's branch refs/heads/branch_5_5 from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=34b813c ] SOLR-8838 : Remove obsolete comment
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit d3d5439bf2790868b8a5dde7d888401f2094d1f3 in lucene-solr's branch refs/heads/branch_5_5 from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d3d5439 ]

          SOLR-8838: java8 date handling -> java7

          Show
          jira-bot ASF subversion and git services added a comment - Commit d3d5439bf2790868b8a5dde7d888401f2094d1f3 in lucene-solr's branch refs/heads/branch_5_5 from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=d3d5439 ] SOLR-8838 : java8 date handling -> java7
          Hide
          ichattopadhyaya Ishan Chattopadhyaya added a comment -

          Thanks Steve!

          Show
          ichattopadhyaya Ishan Chattopadhyaya added a comment - Thanks Steve!
          Hide
          anshumg Anshum Gupta added a comment -

          Reopening to port to 5x branch so we don't regress if there is a 5.6 release at some point.

          Show
          anshumg Anshum Gupta added a comment - Reopening to port to 5x branch so we don't regress if there is a 5.6 release at some point.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit db853d4983f3d7b6b55f70f3025444e733d44250 in lucene-solr's branch refs/heads/branch_5x from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=db853d4 ]

          SOLR-8838: Returning non-stored docValues is incorrect for negative floats and doubles.

          Show
          jira-bot ASF subversion and git services added a comment - Commit db853d4983f3d7b6b55f70f3025444e733d44250 in lucene-solr's branch refs/heads/branch_5x from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=db853d4 ] SOLR-8838 : Returning non-stored docValues is incorrect for negative floats and doubles.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 404a3f995673d54bc7565dea934332e1cd37d4c3 in lucene-solr's branch refs/heads/branch_5x from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=404a3f9 ]

          SOLR-8838: Returning non-stored docValues is incorrect for negative floats and doubles.

          Show
          jira-bot ASF subversion and git services added a comment - Commit 404a3f995673d54bc7565dea934332e1cd37d4c3 in lucene-solr's branch refs/heads/branch_5x from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=404a3f9 ] SOLR-8838 : Returning non-stored docValues is incorrect for negative floats and doubles.
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 496a7535115c13c25fe6c12b7f463477c9426098 in lucene-solr's branch refs/heads/branch_5x from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=496a753 ]

          SOLR-8838: Remove obsolete comment

          Show
          jira-bot ASF subversion and git services added a comment - Commit 496a7535115c13c25fe6c12b7f463477c9426098 in lucene-solr's branch refs/heads/branch_5x from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=496a753 ] SOLR-8838 : Remove obsolete comment
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 33462956c6e2e1cc1d23afeb947c9688f00ba490 in lucene-solr's branch refs/heads/branch_5x from Steve Rowe
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3346295 ]

          SOLR-8838: java8 date handling -> java7

          Show
          jira-bot ASF subversion and git services added a comment - Commit 33462956c6e2e1cc1d23afeb947c9688f00ba490 in lucene-solr's branch refs/heads/branch_5x from Steve Rowe [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=3346295 ] SOLR-8838 : java8 date handling -> java7
          Hide
          hossman Hoss Man added a comment -

          Manually correcting fixVersion per Step #S6 of LUCENE-7271

          Show
          hossman Hoss Man added a comment - Manually correcting fixVersion per Step #S6 of LUCENE-7271

            People

            • Assignee:
              steve_rowe Steve Rowe
              Reporter:
              ichattopadhyaya Ishan Chattopadhyaya
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development