Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 6.0
    • Fix Version/s: 6.1
    • Component/s: SolrJ
    • Labels:
      None
    • Flags:
      Patch

      Description

      There are multiple JDBC clients that require a PreparedStatement to work.

      1. SOLR-8809.patch
        14 kB
        Kevin Risden
      2. SOLR-8809.patch
        12 kB
        Kevin Risden
      3. SOLR-8809.patch
        11 kB
        Kevin Risden

        Issue Links

          Activity

          Hide
          risdenk Kevin Risden added a comment -

          Joel Bernstein - Here is a patch and test.

          Show
          risdenk Kevin Risden added a comment - Joel Bernstein - Here is a patch and test.
          Hide
          risdenk Kevin Risden added a comment -

          Added implementation of PreparedStatement.execute()

          Show
          risdenk Kevin Risden added a comment - Added implementation of PreparedStatement.execute()
          Hide
          risdenk Kevin Risden added a comment -

          Joel Bernstein - Is this minor enough to get into Solr 6? Since JDBC isn't released yet and should be minimal impact.

          Show
          risdenk Kevin Risden added a comment - Joel Bernstein - Is this minor enough to get into Solr 6? Since JDBC isn't released yet and should be minimal impact.
          Hide
          risdenk Kevin Risden added a comment -

          Some more thought needs to go into this due to PreparedStatement being special and not all methods being supported if its a PreparedStatement.

          Show
          risdenk Kevin Risden added a comment - Some more thought needs to go into this due to PreparedStatement being special and not all methods being supported if its a PreparedStatement.
          Hide
          risdenk Kevin Risden added a comment -

          Patch that implements ConnectionprepareStatement. Adds PreparedStatementImpl and tests to JdbcTest

          Show
          risdenk Kevin Risden added a comment - Patch that implements ConnectionprepareStatement. Adds PreparedStatementImpl and tests to JdbcTest
          Hide
          risdenk Kevin Risden added a comment -

          Think the latest patch is good to go. Joel Bernstein - can you take a peek?

          Show
          risdenk Kevin Risden added a comment - Think the latest patch is good to go. Joel Bernstein - can you take a peek?
          Hide
          joel.bernstein Joel Bernstein added a comment -

          Yep, I'll take a look

          Show
          joel.bernstein Joel Bernstein added a comment - Yep, I'll take a look
          Hide
          joel.bernstein Joel Bernstein added a comment -

          Looks good. It doesn't yet do the parameter substitution I believe. Should be pretty straight forward to add that in separate ticket though.

          Show
          joel.bernstein Joel Bernstein added a comment - Looks good. It doesn't yet do the parameter substitution I believe. Should be pretty straight forward to add that in separate ticket though.
          Hide
          risdenk Kevin Risden added a comment -

          Correct no parameter substitution yet. The problem I am trying to solve with this is avoid the NPE that gets thrown when clients try to connect to move on to the next NPE clients throw when first connecting. Parameter substitution definitely should be added and shouldn't be too bad to do in a separate JIRA.

          Show
          risdenk Kevin Risden added a comment - Correct no parameter substitution yet. The problem I am trying to solve with this is avoid the NPE that gets thrown when clients try to connect to move on to the next NPE clients throw when first connecting. Parameter substitution definitely should be added and shouldn't be too bad to do in a separate JIRA.
          Hide
          joel.bernstein Joel Bernstein added a comment -

          Makes sense.

          +1 to commit

          Show
          joel.bernstein Joel Bernstein added a comment - Makes sense. +1 to commit
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 221ecfa89821665d69f55ed1b3502f50b3698720 in lucene-solr's branch refs/heads/master from Kevin Risden
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=221ecfa ]

          SOLR-8809: Implement Connection.prepareStatement

          Show
          jira-bot ASF subversion and git services added a comment - Commit 221ecfa89821665d69f55ed1b3502f50b3698720 in lucene-solr's branch refs/heads/master from Kevin Risden [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=221ecfa ] SOLR-8809 : Implement Connection.prepareStatement
          Hide
          jira-bot ASF subversion and git services added a comment -

          Commit 6276fe5ec7bcbdd30e30059391707084b9c8e989 in lucene-solr's branch refs/heads/branch_6x from Kevin Risden
          [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6276fe5 ]

          SOLR-8809: Implement Connection.prepareStatement

          Show
          jira-bot ASF subversion and git services added a comment - Commit 6276fe5ec7bcbdd30e30059391707084b9c8e989 in lucene-solr's branch refs/heads/branch_6x from Kevin Risden [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6276fe5 ] SOLR-8809 : Implement Connection.prepareStatement

            People

            • Assignee:
              risdenk Kevin Risden
              Reporter:
              risdenk Kevin Risden
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development