Commit 81feea2505103f4f0bcc4f6a84d9ea9b99e7ecb5 in lucene-solr's branch refs/heads/master from anshum
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=81feea2 ]

SOLR-8790: Ignoring failing CollectionsAPISolrJTest test until this is fixed

Commit 2055b64ca10c66b5fe5f63c3ec3a845c567aadda in lucene-solr's branch refs/heads/branch_6x from anshum
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=2055b64 ]

SOLR-8790: Ignoring failing CollectionsAPISolrJTest test until this is fixed

Ignored the test to unblock Jenkins. I'll take a look at it later tonight.

git bisect led to this commit:

[a2e5c37c85acc7692d6fbcc29866a70db4f8be2e] SOLR-8534: Add generic support for collection APIs to be async

I'll take a look and fix. I'm fairly certain that the commit changed the response returned from Solr.

Nicholas Knize I'd like to get this into 6.0 as this is regression.

Commit 209f5c2946c8816a7ab175dc5e886ea661d154a5 in lucene-solr's branch refs/heads/master from anshum
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=209f5c2 ]

SOLR-8790: Add the node name to core responses in calls from the Overseer

Commit 8fe11a06ce9e8bfef99184b1849e459b15691bf2 in lucene-solr's branch refs/heads/branch_6x from anshum
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=8fe11a0 ]

SOLR-8790: Add the node name to core responses in calls from the Overseer

Hi Anshum,

Thanks for fixing the code! Patch looks good

Just looking at the OverseerCollectionMessageHandler there are different things being set as nodeName in different places:

For example,
processRebalanceLeaders does this - sreq.nodeName = message.getStr(ZkStateReader.CORE_NAME_PROP);
addReplica does this - String node = message.getStr(CoreAdminParams.NODE);

Everyone else sets nodeName as ZkStateReader.NODE_NAME_PROP

I think we should also add some javadocs to sendShardRequest and ShardRequest.java

AddReplica is fine. The API actually takes in a "node" parameter but internally it's used as "node_name".

Here is a quick patch of what I was referring to.

Anshum Gupta I'm okay with this making it in 6_0.

Varun Thacker The patch leads to failing TestRebalanceLeaders.
You are trying to extract the NODE_NAME from message but that is always be null.

message.getStr(ZkStateReader.NODE_NAME_PROP)

Also, your patch loses this information:

sreq.purpose = ShardRequest.PURPOSE_PRIVATE;

Commit b4d52d60ac4413f7bd0cd83bcc3c94a00c6dcddf in lucene-solr's branch refs/heads/branch_6_0 from anshum
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=b4d52d6 ]

SOLR-8790: Add the node name to core responses in calls from the Overseer

backport for 5.5.1.

Commit cbb29d2a5ae4ab8741aab6c9f0806d4236c0cad0 in lucene-solr's branch refs/heads/branch_5x from anshum
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=cbb29d2 ]

SOLR-8790: Add the node name to core responses in calls from the Overseer

Commit bc08d7893fa6ba0bd0e9f37b72f014758f66b988 in lucene-solr's branch refs/heads/branch_5_5 from anshum
[ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=bc08d78 ]

SOLR-8790: Add the node name to core responses in calls from the Overseer

Manually correcting fixVersion per Step #S6 of LUCENE-7271