Uploaded image for project: 'Solr'
  1. Solr
  2. SOLR-8787

TestAuthenticationFramework should not extend TestMiniSolrCloudCluster

    Details

      Description

      TestAuthenticationFramework should not extend TestMiniSolrCloudCluster. The TestMiniSolrCloudCluster is actually a test for MiniSolrCloudCluster and not a generic test framework class. I saw a local failure for TestAuthenticationFramework.testSegmentTerminateEarly which should never be executed in the first place.

      1. SOLR-8787.patch
        10 kB
        Trey Cahill

        Activity

        Hide
        cahilltr Trey Cahill added a comment -

        Added patch, which changes TestAuthenticationFramework to extend LuceneTestCase and not TestMiniSolrCloudCluster. Used functions from TestMiniSolrCloudCluster, but removed any non-needed operations/etc.

        Show
        cahilltr Trey Cahill added a comment - Added patch, which changes TestAuthenticationFramework to extend LuceneTestCase and not TestMiniSolrCloudCluster. Used functions from TestMiniSolrCloudCluster, but removed any non-needed operations/etc.
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 6528dacb0e5c71f9e412655d8abee0857f4bda8f in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6528dac ]

        SOLR-8787: TestAuthenticationFramework should not extend TestMiniSolrCloudCluster

        Show
        jira-bot ASF subversion and git services added a comment - Commit 6528dacb0e5c71f9e412655d8abee0857f4bda8f in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=6528dac ] SOLR-8787 : TestAuthenticationFramework should not extend TestMiniSolrCloudCluster
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit c7d82e7b38676acffdb867514ebc3344c0b5faa9 in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c7d82e7 ]

        SOLR-8787: TestAuthenticationFramework should not extend TestMiniSolrCloudCluster
        (cherry picked from commit 6528dac)

        Show
        jira-bot ASF subversion and git services added a comment - Commit c7d82e7b38676acffdb867514ebc3344c0b5faa9 in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c7d82e7 ] SOLR-8787 : TestAuthenticationFramework should not extend TestMiniSolrCloudCluster (cherry picked from commit 6528dac)
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 0a15699caa5d7d3a6b72977f90857d0a78a2fd70 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0a15699 ]

        SOLR-8787: Shutdown MiniSolrCloudCluster in a finally block

        Show
        jira-bot ASF subversion and git services added a comment - Commit 0a15699caa5d7d3a6b72977f90857d0a78a2fd70 in lucene-solr's branch refs/heads/master from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=0a15699 ] SOLR-8787 : Shutdown MiniSolrCloudCluster in a finally block
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit 18434526d6ef73373796481ef3ccd637694e3dfe in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1843452 ]

        SOLR-8787: Shutdown MiniSolrCloudCluster in a finally block
        (cherry picked from commit 0a15699)

        Show
        jira-bot ASF subversion and git services added a comment - Commit 18434526d6ef73373796481ef3ccd637694e3dfe in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=1843452 ] SOLR-8787 : Shutdown MiniSolrCloudCluster in a finally block (cherry picked from commit 0a15699)
        Hide
        shalinmangar Shalin Shekhar Mangar added a comment -

        Thanks Trey!

        Show
        shalinmangar Shalin Shekhar Mangar added a comment - Thanks Trey!
        Hide
        jira-bot ASF subversion and git services added a comment -

        Commit ed38a29a9f497eda1c8d7bce374cc2bbdb281054 in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar
        [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ed38a29 ]

        SOLR-8787: Fix broken build due to unused import

        Show
        jira-bot ASF subversion and git services added a comment - Commit ed38a29a9f497eda1c8d7bce374cc2bbdb281054 in lucene-solr's branch refs/heads/branch_6x from Shalin Shekhar Mangar [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=ed38a29 ] SOLR-8787 : Fix broken build due to unused import
        Hide
        mikemccand Michael McCandless added a comment -

        Bulk close resolved issues after 6.2.0 release.

        Show
        mikemccand Michael McCandless added a comment - Bulk close resolved issues after 6.2.0 release.

          People

          • Assignee:
            shalinmangar Shalin Shekhar Mangar
            Reporter:
            shalinmangar Shalin Shekhar Mangar
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development