[SOLR-8779] Fix missing InterruptedException handling in ZkStateReader

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 5.5.1, 6.0
• Assignee: Varun Thacker
• Reporter: Varun Thacker
• Created: 03/Mar/16 11:57
• Updated: 21/Nov/19 03:41
• Resolved: 22/Apr/16 03:20

Description

I was debugging a zk session expired issue and saw this stack-trace

ERROR - 2016-03-03 06:55:53.873; [   ] org.apache.solr.common.SolrException; OverseerAutoReplicaFailoverThread had an error in its thread work loop.:org.apache.solr.common.SolrException: Error reading cluster properties
	at org.apache.solr.common.cloud.ZkStateReader.getClusterProps(ZkStateReader.java:738)
	at org.apache.solr.cloud.OverseerAutoReplicaFailoverThread.doWork(OverseerAutoReplicaFailoverThread.java:153)
	at org.apache.solr.cloud.OverseerAutoReplicaFailoverThread.run(OverseerAutoReplicaFailoverThread.java:132)
	at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.InterruptedException: sleep interrupted
	at java.lang.Thread.sleep(Native Method)
	at org.apache.solr.common.cloud.ZkCmdExecutor.retryDelay(ZkCmdExecutor.java:108)
	at org.apache.solr.common.cloud.ZkCmdExecutor.retryOperation(ZkCmdExecutor.java:76)
	at org.apache.solr.common.cloud.SolrZkClient.exists(SolrZkClient.java:308)
	at org.apache.solr.common.cloud.ZkStateReader.getClusterProps(ZkStateReader.java:731)
	... 3 more

So I audited ZKStateReader and found a couple of places where an InterruptedException was caught but the interrupt flag wasn't set back.